From: Alex Deucher <alexdeucher@gmail.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm: Don't return 0 from a void drm_fbdev_generic_setup
Date: Wed, 8 Apr 2020 17:25:43 -0400 [thread overview]
Message-ID: <CADnq5_MKZUgZh5YXoNimhGFkQqod++WkCa-Ed=o9aM9M5H08-A@mail.gmail.com> (raw)
In-Reply-To: <20200408212407.4309-1-chris@chris-wilson.co.uk>
On Wed, Apr 8, 2020 at 5:24 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> drm_fbdev_generic_setup() was changed to be a void return, but the stub
> was left returning 0.
>
> ./include/drm/drm_fb_helper.h: In function ‘drm_fbdev_generic_setup’:
> ./include/drm/drm_fb_helper.h:450:9: warning: ‘return’ with a value, in function returning void [-Wreturn-type]
> ./include/drm/drm_fb_helper.h:448:1: note: declared here
> 448 | drm_fbdev_generic_setup(struct drm_device *dev, unsigned int preferred_bpp)
>
> Fixes: 1aed9509b29a ("drm/fb-helper: Remove return value from drm_fbdev_generic_setup()")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> include/drm/drm_fb_helper.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
> index fb037be83997..306aa3a60be9 100644
> --- a/include/drm/drm_fb_helper.h
> +++ b/include/drm/drm_fb_helper.h
> @@ -447,7 +447,6 @@ static inline void drm_fb_helper_output_poll_changed(struct drm_device *dev)
> static inline void
> drm_fbdev_generic_setup(struct drm_device *dev, unsigned int preferred_bpp)
> {
> - return 0;
> }
>
> #endif
> --
> 2.20.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-08 21:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 21:24 [PATCH] drm: Don't return 0 from a void drm_fbdev_generic_setup Chris Wilson
2020-04-08 21:25 ` Alex Deucher [this message]
2020-04-14 6:43 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADnq5_MKZUgZh5YXoNimhGFkQqod++WkCa-Ed=o9aM9M5H08-A@mail.gmail.com' \
--to=alexdeucher@gmail.com \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).