From: Alex Deucher <alexdeucher@gmail.com>
To: Zheng Bin <zhengbin13@huawei.com>
Cc: Dave Airlie <airlied@linux.ie>,
amd-gfx list <amd-gfx@lists.freedesktop.org>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
"Deucher, Alexander" <alexander.deucher@amd.com>,
Christian Koenig <christian.koenig@amd.com>
Subject: Re: [PATCH 00/14] drm/radeon: remove comparison to bool
Date: Wed, 6 May 2020 12:00:24 -0400 [thread overview]
Message-ID: <CADnq5_MZvyhVQ6kcd1_qHgDOGGSe+DEbQJNnGeBf6mq5zT8GrA@mail.gmail.com> (raw)
In-Reply-To: <20200506143326.66467-1-zhengbin13@huawei.com>
On Wed, May 6, 2020 at 10:27 AM Zheng Bin <zhengbin13@huawei.com> wrote:
>
> Zheng Bin (14):
> drm/radeon: remove comparison to bool in btc_dpm.c
> drm/radeon: remove comparison to bool in ci_dpm.c
> drm/radeon: remove comparison to bool in ni_dpm.c
> drm/radeon: remove comparison to bool in radeon_atpx_handler.c
> drm/radeon: remove comparison to bool in radeon_object.c
> drm/radeon: remove comparison to bool in radeon_ttm.c
> drm/radeon: remove comparison to bool in r100.c
> drm/radeon: remove comparison to bool in r300.c
> drm/radeon: remove comparison to bool in r600.c
> drm/radeon: remove comparison to bool in rs600.c
> drm/radeon: remove comparison to bool in rs690.c
> drm/radeon: remove comparison to bool in rv6xx_dpm.c
> drm/radeon: remove comparison to bool in rv515.c
> drm/radeon: remove comparison to bool in si_dpm.c
Does the checker need to be fixed? All of these are comparing boolean
variables to true/false. Seems like needless code churn to me.
Alex
>
> drivers/gpu/drm/radeon/btc_dpm.c | 2 +-
> drivers/gpu/drm/radeon/ci_dpm.c | 4 ++--
> drivers/gpu/drm/radeon/ni_dpm.c | 6 +++---
> drivers/gpu/drm/radeon/r100.c | 2 +-
> drivers/gpu/drm/radeon/r300.c | 2 +-
> drivers/gpu/drm/radeon/r600.c | 3 ++-
> drivers/gpu/drm/radeon/radeon_atpx_handler.c | 4 ++--
> drivers/gpu/drm/radeon/radeon_object.c | 2 +-
> drivers/gpu/drm/radeon/radeon_ttm.c | 2 +-
> drivers/gpu/drm/radeon/rs600.c | 2 +-
> drivers/gpu/drm/radeon/rs690.c | 3 ++-
> drivers/gpu/drm/radeon/rv515.c | 2 +-
> drivers/gpu/drm/radeon/rv6xx_dpm.c | 2 +-
> drivers/gpu/drm/radeon/si_dpm.c | 6 +++---
> 14 files changed, 22 insertions(+), 20 deletions(-)
>
> --
> 2.26.0.106.g9fadedd
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-05-06 16:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 14:33 [PATCH 00/14] drm/radeon: remove comparison to bool Zheng Bin
2020-05-06 14:33 ` [PATCH 01/14] drm/radeon: remove comparison to bool in btc_dpm.c Zheng Bin
2020-05-06 14:33 ` [PATCH 02/14] drm/radeon: remove comparison to bool in ci_dpm.c Zheng Bin
2020-05-06 14:33 ` [PATCH 03/14] drm/radeon: remove comparison to bool in ni_dpm.c Zheng Bin
2020-05-06 14:33 ` [PATCH 04/14] drm/radeon: remove comparison to bool in radeon_atpx_handler.c Zheng Bin
2020-05-06 14:33 ` [PATCH 05/14] drm/radeon: remove comparison to bool in radeon_object.c Zheng Bin
2020-05-06 14:33 ` [PATCH 06/14] drm/radeon: remove comparison to bool in radeon_ttm.c Zheng Bin
2020-05-06 14:33 ` [PATCH 07/14] drm/radeon: remove comparison to bool in r100.c Zheng Bin
2020-05-06 14:33 ` [PATCH 08/14] drm/radeon: remove comparison to bool in r300.c Zheng Bin
2020-05-06 14:33 ` [PATCH 09/14] drm/radeon: remove comparison to bool in r600.c Zheng Bin
2020-05-06 14:33 ` [PATCH 10/14] drm/radeon: remove comparison to bool in rs600.c Zheng Bin
2020-05-06 14:33 ` [PATCH 11/14] drm/radeon: remove comparison to bool in rs690.c Zheng Bin
2020-05-06 14:33 ` [PATCH 12/14] drm/radeon: remove comparison to bool in rv6xx_dpm.c Zheng Bin
2020-05-06 14:33 ` [PATCH 13/14] drm/radeon: remove comparison to bool in rv515.c Zheng Bin
2020-05-06 14:33 ` [PATCH 14/14] drm/radeon: remove comparison to bool in si_dpm.c Zheng Bin
2020-05-06 16:00 ` Alex Deucher [this message]
2020-05-06 16:36 [PATCH 00/14] drm/radeon: remove comparison to bool Koenig, Christian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_MZvyhVQ6kcd1_qHgDOGGSe+DEbQJNnGeBf6mq5zT8GrA@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).