* [PATCH] drm/radeon: Add break to switch statement in radeonfb_create_pinned_object()
@ 2021-08-15 19:29 Nathan Chancellor
2021-08-16 7:22 ` Christian König
0 siblings, 1 reply; 3+ messages in thread
From: Nathan Chancellor @ 2021-08-15 19:29 UTC (permalink / raw)
To: Alex Deucher, Christian König, Pan, Xinhui
Cc: Nick Desaulniers, Gustavo A. R. Silva, Kees Cook, amd-gfx,
dri-devel, linux-kernel, clang-built-linux, Nathan Chancellor
Clang + -Wimplicit-fallthrough warns:
drivers/gpu/drm/radeon/radeon_fb.c:170:2: warning: unannotated
fall-through between switch labels [-Wimplicit-fallthrough]
default:
^
drivers/gpu/drm/radeon/radeon_fb.c:170:2: note: insert 'break;' to avoid
fall-through
default:
^
break;
1 warning generated.
Clang's version of this warning is a little bit more pedantic than
GCC's. Add the missing break to satisfy it to match what has been done
all over the kernel tree.
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
drivers/gpu/drm/radeon/radeon_fb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c
index 0b206b052972..c8b545181497 100644
--- a/drivers/gpu/drm/radeon/radeon_fb.c
+++ b/drivers/gpu/drm/radeon/radeon_fb.c
@@ -167,6 +167,7 @@ static int radeonfb_create_pinned_object(struct radeon_fbdev *rfbdev,
break;
case 2:
tiling_flags |= RADEON_TILING_SWAP_16BIT;
+ break;
default:
break;
}
base-commit: ba31f97d43be41ca99ab72a6131d7c226306865f
--
2.33.0.rc2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/radeon: Add break to switch statement in radeonfb_create_pinned_object()
2021-08-15 19:29 [PATCH] drm/radeon: Add break to switch statement in radeonfb_create_pinned_object() Nathan Chancellor
@ 2021-08-16 7:22 ` Christian König
2021-08-16 18:53 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Christian König @ 2021-08-16 7:22 UTC (permalink / raw)
To: Nathan Chancellor, Alex Deucher, Pan, Xinhui
Cc: Nick Desaulniers, Gustavo A. R. Silva, Kees Cook, amd-gfx,
dri-devel, linux-kernel, clang-built-linux
Am 15.08.21 um 21:29 schrieb Nathan Chancellor:
> Clang + -Wimplicit-fallthrough warns:
>
> drivers/gpu/drm/radeon/radeon_fb.c:170:2: warning: unannotated
> fall-through between switch labels [-Wimplicit-fallthrough]
> default:
> ^
> drivers/gpu/drm/radeon/radeon_fb.c:170:2: note: insert 'break;' to avoid
> fall-through
> default:
> ^
> break;
> 1 warning generated.
>
> Clang's version of this warning is a little bit more pedantic than
> GCC's. Add the missing break to satisfy it to match what has been done
> all over the kernel tree.
>
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/radeon/radeon_fb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c
> index 0b206b052972..c8b545181497 100644
> --- a/drivers/gpu/drm/radeon/radeon_fb.c
> +++ b/drivers/gpu/drm/radeon/radeon_fb.c
> @@ -167,6 +167,7 @@ static int radeonfb_create_pinned_object(struct radeon_fbdev *rfbdev,
> break;
> case 2:
> tiling_flags |= RADEON_TILING_SWAP_16BIT;
> + break;
> default:
> break;
> }
>
> base-commit: ba31f97d43be41ca99ab72a6131d7c226306865f
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/radeon: Add break to switch statement in radeonfb_create_pinned_object()
2021-08-16 7:22 ` Christian König
@ 2021-08-16 18:53 ` Alex Deucher
0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2021-08-16 18:53 UTC (permalink / raw)
To: Christian König
Cc: Nathan Chancellor, Alex Deucher, Pan, Xinhui, Nick Desaulniers,
Gustavo A. R. Silva, Kees Cook, amd-gfx list,
Maling list - DRI developers, LKML, clang-built-linux
Applied. Thanks!
Alex
On Mon, Aug 16, 2021 at 3:23 AM Christian König
<christian.koenig@amd.com> wrote:
>
> Am 15.08.21 um 21:29 schrieb Nathan Chancellor:
> > Clang + -Wimplicit-fallthrough warns:
> >
> > drivers/gpu/drm/radeon/radeon_fb.c:170:2: warning: unannotated
> > fall-through between switch labels [-Wimplicit-fallthrough]
> > default:
> > ^
> > drivers/gpu/drm/radeon/radeon_fb.c:170:2: note: insert 'break;' to avoid
> > fall-through
> > default:
> > ^
> > break;
> > 1 warning generated.
> >
> > Clang's version of this warning is a little bit more pedantic than
> > GCC's. Add the missing break to satisfy it to match what has been done
> > all over the kernel tree.
> >
> > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
> > ---
> > drivers/gpu/drm/radeon/radeon_fb.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c
> > index 0b206b052972..c8b545181497 100644
> > --- a/drivers/gpu/drm/radeon/radeon_fb.c
> > +++ b/drivers/gpu/drm/radeon/radeon_fb.c
> > @@ -167,6 +167,7 @@ static int radeonfb_create_pinned_object(struct radeon_fbdev *rfbdev,
> > break;
> > case 2:
> > tiling_flags |= RADEON_TILING_SWAP_16BIT;
> > + break;
> > default:
> > break;
> > }
> >
> > base-commit: ba31f97d43be41ca99ab72a6131d7c226306865f
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-16 18:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-15 19:29 [PATCH] drm/radeon: Add break to switch statement in radeonfb_create_pinned_object() Nathan Chancellor
2021-08-16 7:22 ` Christian König
2021-08-16 18:53 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).