From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EF5DC433DF for ; Fri, 12 Jun 2020 17:41:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 67E64207F7 for ; Fri, 12 Jun 2020 17:41:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p40Fx6wb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67E64207F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ED5936EA17; Fri, 12 Jun 2020 17:41:30 +0000 (UTC) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id B7ED06EA17; Fri, 12 Jun 2020 17:41:29 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id p5so10534119wrw.9; Fri, 12 Jun 2020 10:41:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=N06e4f1LZnIJJBVTlO/jLeXZsHg330hzDvfCmeP0IlU=; b=p40Fx6wb8BUjL8MLw6Uby7ELzYeqk8GJS7iSx2HZWKT6AniT2oAZTF0lNf5IOaXgEd jNGv5VOyKENkvX1oYmY22uXlxA5utc6md8HGkNYDw3YoiQeDZ6YXBFJucgVihB/EOcd3 N0TZ3TujZSQQfxJIaX4SzYzhd38FEr/GJQM8pqSXbHMNw+7JiYiNBgZwKWYGtvD4ta/s fAWecJbLwM/y/cgR3pVQbYnvGg8YLqPHNubmeEj3Txetkkcpdqnu5XRKSP6oLIUjqpsb hBzA1PalfctTmrjJbVmrMMCRhxHA/UNFZAGtwiaB/UCveIE6ZFvd4qYrDfUU/YEfAint AnPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N06e4f1LZnIJJBVTlO/jLeXZsHg330hzDvfCmeP0IlU=; b=gILjKb+PlnvSplrsKQa2w4q4dqzd/9zvhZZwMztlcl6WCDvqPF1VoburttMLmGhffZ jxfJqfak0ijhEUOC8ME/3nZWeLeQWJsCaeNW2Zuy1TkKo9FPVTJvvHOz4pTJjmGDYisO ALgRYqXvV86ahToC4DgJUwEjZGjqW78uaDrSb4I8Ockq5ZSGo+Tw9mCQ/dPbuTGEIiQu bBadMR6vGgGpFgwDmbj5DjoxrNCltwk2w6G6BKOEvf2iMAw0u/ukI1eiGVkTGuh9kQEJ RyfvRBrRVeAY6eKOxkbuYrMlgsaJ9bQx1YbfoPfwSWjWvxX3k9y0xehrzdL5vfR5nvd7 +JMg== X-Gm-Message-State: AOAM5304b0oI6Z9YCXrXEt+wrxW9uDrsU/Ni//mVFsEYDyC9bSa948FS NCwjK93/Yr74ZEFLx8sJwPowX+ZXmhRvijQ6JdA= X-Google-Smtp-Source: ABdhPJybPHDIKFvsEJLfkdWBErvccLGV9L5JXqBOdeWNgHrmcUZB0dofVEQHzSS7WYDZmgJpnA4lX/A7mSCIwX+ye04= X-Received: by 2002:a05:6000:1003:: with SMTP id a3mr15716844wrx.111.1591983688378; Fri, 12 Jun 2020 10:41:28 -0700 (PDT) MIME-Version: 1.0 References: <20200612160056.2082681-1-daniel.vetter@ffwll.ch> <20200612160056.2082681-2-daniel.vetter@ffwll.ch> In-Reply-To: From: Alex Deucher Date: Fri, 12 Jun 2020 13:41:17 -0400 Message-ID: Subject: Re: [PATCH 2/8] drm/amdgpu: Use __drm_atomic_helper_crtc_reset To: Harry Wentland X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stylon Wang , Daniel Vetter , Intel Graphics Development , Rodrigo Siqueira , Roman Li , DRI Development , Alex Deucher , Daniel Vetter , Mikita Lipski , Bhawanpreet Lakha , Nicholas Kazlauskas Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Jun 12, 2020 at 1:24 PM Harry Wentland wrote: > > On 2020-06-12 12:00 p.m., Daniel Vetter wrote: > > Now also comes with the added benefit of doing a drm_crtc_vblank_off(), > > which means vblank state isn't ill-defined and fail-y at driver load > > before the first modeset on each crtc. > > > > Signed-off-by: Daniel Vetter > > Cc: Alex Deucher > > Cc: Nicholas Kazlauskas > > Cc: Harry Wentland > > Cc: Rodrigo Siqueira > > Cc: Bhawanpreet Lakha > > Cc: Roman Li > > Cc: Mikita Lipski > > Cc: Stylon Wang > > Reviewed-by: Harry Wentland > Daniel, do you want to take the whole series, or should I pull this in through my tree? Either way works for me. Thanks for the patch! Alex > Harry > > > --- > > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > index 68a73065b516..36d605a6eb16 100644 > > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > @@ -4594,9 +4594,7 @@ static void dm_crtc_reset_state(struct drm_crtc *crtc) > > if (WARN_ON(!state)) > > return; > > > > - crtc->state = &state->base; > > - crtc->state->crtc = crtc; > > - > > + __drm_atomic_helper_crtc_reset(crtc, &state->base); > > } > > > > static struct drm_crtc_state * > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel