From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C34A1C47080 for ; Wed, 2 Jun 2021 02:07:52 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6AC51610C9 for ; Wed, 2 Jun 2021 02:07:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6AC51610C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8E9B96EB4F; Wed, 2 Jun 2021 02:07:51 +0000 (UTC) Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by gabe.freedesktop.org (Postfix) with ESMTPS id 78DC66EB4F; Wed, 2 Jun 2021 02:07:50 +0000 (UTC) Received: by mail-ot1-x335.google.com with SMTP id x41-20020a05683040a9b02903b37841177eso1124977ott.9; Tue, 01 Jun 2021 19:07:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=pU1TRPFdg/mvMNMBTDRgncKjTs5cmC/VyWt+TILhNqg=; b=leBsDCLV2SQ+QW8NeJ78bjOGFhHQDUCW/Evqpq2ZLpXULUTD/gYVSWB0dKF+OZ2v8/ C7XYgo/lznFWK0glQZ5BhIsDN4m+9THwBBrByZI1kPwsRbO+4oDbSI3miRWMTMXEL+TJ 1bdst67rVthfP5BTO5o7lI3krd9Eb7oCk4+SErPCDN/Egx3dajMebOIS64mmZR9VKZAA OixVbaRn4O994jn/KWkrQaEWsVAZ7QoxOgZvu9FzCcPJf+N7wHU74hl8nazHzgKTthi+ 5Wtb2q8dVFp8ElfhO3dwBkVDj8xJxy5wa6AceM5RNEykul5QZjSehyXxn02IrOPIi55P FBbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=pU1TRPFdg/mvMNMBTDRgncKjTs5cmC/VyWt+TILhNqg=; b=Cfk1UFaniN9E+42PEpyVpRtJ42qJ/MyiPJTegb2Eo3Fl1iEkmc7+UyeqY/aP130JZj EbUECZHAmquJeZRykR6NdNEbvgXXEkBlZiBpw/w7PKzoO9G9S/ykt6z+jsN0RabxK+MF ZYGyZgtAsQFkiQGcpAsRKN5ZyWewz264CdrN/cY4pJVaJ3dBko2RLngOCOdihGkL6eqI ounJS3PJGENZdA/XXqgTIsVK0qrxCHxt/+4GN5PNuyBk4310KxUOFeM+mkceZM8fB4jk 8+PyfMMmyvAkfYkZP0NbkjeqcDrVv8fUY8tM/p3+eS6TieMR6P6io8vHUUY/wk6ZtT8I 1sEA== X-Gm-Message-State: AOAM533NK1hMg1pnS/zyEscCGTk6iyK+Ltm4YQ+FlQzp/47x97Ab+hd1 ljd5wDZA4/uomj0TH29wFCagGZqeyifaZey3Mgk= X-Google-Smtp-Source: ABdhPJy++Oeg5/01VJ0eNw4v7bM57dKx0Um7cQXKi3LBbMT6j2vCn15UhSf89hqlJcqfgZt7Y2XlXZgo5CTv05pt1g0= X-Received: by 2002:a9d:6548:: with SMTP id q8mr24108150otl.311.1622599669886; Tue, 01 Jun 2021 19:07:49 -0700 (PDT) MIME-Version: 1.0 References: <20210529092816.3133745-1-yukuai3@huawei.com> In-Reply-To: <20210529092816.3133745-1-yukuai3@huawei.com> From: Alex Deucher Date: Tue, 1 Jun 2021 22:07:38 -0400 Message-ID: Subject: Re: [PATCH] drm/amd/display: fix gcc set but not used warning of variable 'old_plane_state' To: Yu Kuai Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amd-gfx list , Thomas Zimmermann , yi.zhang@huawei.com, "Leo \(Sunpeng\) Li" , xinhui pan , LKML , Dave Airlie , Maling list - DRI developers , "Deucher, Alexander" , Christian Koenig Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Applied. Thanks! Alex On Sat, May 29, 2021 at 5:19 AM Yu Kuai wrote: > > define a new macro for_each_new_plane_in_state_reverse to replace > for_each_oldnew_plane_in_state_reverse, so that the unused variable > 'old_plane_state' can be removed. > > Fix gcc warning: > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:10066:26: war= ning: > variable =E2=80=98old_plane_state=E2=80=99 set but not used [-Wunused-bu= t-set-variable] > > Signed-off-by: Yu Kuai > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- > include/drm/drm_atomic.h | 12 ++++++++++++ > 2 files changed, 14 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/= gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > index f7a5e5b48ea6..9f4b334bc071 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > @@ -10063,11 +10063,11 @@ static int validate_overlay(struct drm_atomic_s= tate *state) > { > int i; > struct drm_plane *plane; > - struct drm_plane_state *old_plane_state, *new_plane_state; > + struct drm_plane_state *new_plane_state; > struct drm_plane_state *primary_state, *cursor_state, *overlay_st= ate =3D NULL; > > /* Check if primary plane is contained inside overlay */ > - for_each_oldnew_plane_in_state_reverse(state, plane, old_plane_st= ate, new_plane_state, i) { > + for_each_new_plane_in_state_reverse(state, plane, new_plane_state= , i) { > if (plane->type =3D=3D DRM_PLANE_TYPE_OVERLAY) { > if (drm_atomic_plane_disabling(plane->state, new_= plane_state)) > return 0; > diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h > index ac5a28eff2c8..8f1350e599eb 100644 > --- a/include/drm/drm_atomic.h > +++ b/include/drm/drm_atomic.h > @@ -895,6 +895,18 @@ void drm_state_dump(struct drm_device *dev, struct d= rm_printer *p); > (old_plane_state) =3D (__state)->planes[__i= ].old_state,\ > (new_plane_state) =3D (__state)->planes[__i= ].new_state, 1)) > > +/** > + * for_each_new_plane_in_state_reverse - other than only tracking new st= ate, > + * it's the same as for_each_oldnew_plane_in_state_reverse > + */ > +#define for_each_new_plane_in_state_reverse(__state, plane, new_plane_st= ate, __i) \ > + for ((__i) =3D ((__state)->dev->mode_config.num_total_plane - 1);= \ > + (__i) >=3D 0; = \ > + (__i)--) \ > + for_each_if ((__state)->planes[__i].ptr && \ > + ((plane) =3D (__state)->planes[__i].ptr, = \ > + (new_plane_state) =3D (__state)->planes[__i= ].new_state, 1)) > + > /** > * for_each_old_plane_in_state - iterate over all planes in an atomic up= date > * @__state: &struct drm_atomic_state pointer > -- > 2.25.4 >