From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D95DC43460 for ; Thu, 29 Apr 2021 02:09:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02DC561453 for ; Thu, 29 Apr 2021 02:09:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02DC561453 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9F50B6E14C; Thu, 29 Apr 2021 02:09:42 +0000 (UTC) Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by gabe.freedesktop.org (Postfix) with ESMTPS id D2CD06E14C for ; Thu, 29 Apr 2021 02:09:40 +0000 (UTC) Received: by mail-oi1-x231.google.com with SMTP id u16so47759610oiu.7 for ; Wed, 28 Apr 2021 19:09:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XpteW1PZJWutvArOWsFj/ZNWB/Fybylygdy+Uph5aBg=; b=DsAkVTofK/Xe5v6g4JN1wqggjo+FWBs2DbjZ1lhg84Xl3S8EHIL1qmsHGNf07k2hoH YRj8NOX69DxJjpBoQDTyKw3kNF3M/9izPVV/4xkcucp7HzOGwJdDm5QcBdlPNzsElUod mdd0jEOkPM67KTRS0AOtoqXDsakD8Dqnza6RhJBWy5BOvnFIJydZpsW7E8JS86P/4h7x wmPamGBgRfmg03zn/MhHdoetOcCThYMfskOg7CDftttxb69DmrE6avPSrdT0i9oRUoh5 AiKcgJX8LKFbqKoXElWUIcQXiKTsRrwqn9sH2jAqY7gqB3ENVnHZVOYEBNGF799vSZ3l P41w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XpteW1PZJWutvArOWsFj/ZNWB/Fybylygdy+Uph5aBg=; b=n9F91v0MsM2iYtyZwu5ARt5qXahymeYWBv9NaIAw9uOfm1+WfImSuDilRFy6jMiwvE NSOsrAYXr+YuHR5d8Aa7R7teEdpWdN8g6v07pFRs3vCuuU37+X9b643QWrH7SJISuzOK gMkHQdQ++C8jYwl89G+iCqqiCbq1N7PDNSL9LmjuNA5g35Xk/6ItbOG1TCE3pjt4XsHX 2QQjEgjMOfxZ2byKnpqCOUbtSCnkKdXopUFVykFpq+NBD1InZc0RT8SFpCIa4jlo4EdS LZS0jTbP/H5zKLnwGiFZFbiAUDFRHOJR13ZWBhAWXgLEtbbKchzzr+w6Pkf8ZRBsxg6F IgGw== X-Gm-Message-State: AOAM532ilPFGxpukRn82FSMKIWf/987zFqTEBHgoiGhklpqkmzRLJsbl o+Z+YfEnUMYKBGhIRL6up5KYFcyAA9w8ZMWcNh4= X-Google-Smtp-Source: ABdhPJyuYXVAOuFtIEN/9ZLKxDjiTfOQu7kcczQGclHdfUPsTiqficxHMdUkZazFrXKpKU36KATgpeiiM90eypHsB6s= X-Received: by 2002:aca:4a4e:: with SMTP id x75mr14232021oia.123.1619662180056; Wed, 28 Apr 2021 19:09:40 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Alex Deucher Date: Wed, 28 Apr 2021 22:09:29 -0400 Message-ID: Subject: Re: [git pull] drm for 5.13-rc1 To: Mikita Lipski X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sun peng Li , Linus Torvalds , Qingqing Zhuo , LKML , dri-devel , Daniel Vetter , Alex Deucher , Mikita Lipski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Apr 28, 2021 at 8:14 PM Mikita Lipski wrote: > > Hi Linus, > > The patch to fix the warning is here > (https://www.spinics.net/lists/amd-gfx/msg61614.html) > > I guess it just didn't propagate all the way to the release. > Can it still be pulled into 5.13-rc1 release? I'll include it in my -fixes pull next week. Alex > > > From: Mikita Lipski > > [why] > Previous statement would always evaluate to true > making it meaningless > [how] > Just check if a connector is MST by checking if its port exists. > > Reported-by: kernel test robot > Signed-off-by: Mikita Lipski > Reviewed-by: Nicholas Kazlauskas > Acked-by: Wayne Lin > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c > b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c > index 656bc8f00a42..8bf0b566612b 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c > @@ -3030,7 +3030,7 @@ static int trigger_hpd_mst_set(void *data, u64 val) > if (!aconnector->dc_link) > continue; > > - if (!(aconnector->port && &aconnector->mst_port->mst_mgr)) > + if (!aconnector->mst_port) > continue; > > link = aconnector->dc_link; > -- > 2.17.1 > > > > Thanks, > Mikita > > > On 2021-04-28 6:21 p.m., Linus Torvalds wrote: > > On Tue, Apr 27, 2021 at 8:32 PM Dave Airlie wrote: > >> > >> This is the main drm pull request for 5.13. The usual lots of work all > >> over the place. [...] > >> > >> Mikita Lipski: > >> drm/amd/display: Add MST capability to trigger_hotplug interface > > > > Hmm. I've already merged this, but my clang build shows that this looks buggy: > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_dm/amdgpu_dm_debugfs.c:3015:53: > > warning: address of 'aconnector->mst_port->mst_mgr' will always > > evaluate to 'true' [-Wpointer-bool-conversion] > > if (!(aconnector->port && > > &aconnector->mst_port->mst_mgr)) > > ~~ ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ > > > > and yeah, checking for the address of a member of a structure benign > > NULL doesn't really work. > > > > I'm assuming the '&' is just a left-over cut-and-paste error or something. > > > > Please fix after reviewing (I'm not going to blindly just remove the > > '&' just to silence the warning, since I don't know the code). > > > > Linus > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel