dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Alex Deucher <alexdeucher@gmail.com>
To: Souptick Joarder <jrdr.linux@gmail.com>,
	Harry Wentland <hwentlan@amd.com>
Cc: Stylon Wang <stylon.wang@amd.com>, Eryk Brol <eryk.brol@amd.com>,
	"Leo \(Sunpeng\) Li" <sunpeng.li@amd.com>,
	Bhanuprakash Modem <bhanuprakash.modem@intel.com>,
	Nirmoy Das <nirmoy.das@amd.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
	"Kazlauskas, Nicholas" <Nicholas.Kazlauskas@amd.com>,
	Dave Airlie <airlied@linux.ie>,
	Aurabindo Pillai <aurabindo.pillai@amd.com>,
	amd-gfx list <amd-gfx@lists.freedesktop.org>,
	Wayne Lin <Wayne.Lin@amd.com>,
	"Deucher, Alexander" <alexander.deucher@amd.com>,
	"Lipski, Mikita" <mikita.lipski@amd.com>,
	Christian Koenig <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/amd/display: Remove condition which is always set to True
Date: Wed, 28 Apr 2021 17:05:25 -0400	[thread overview]
Message-ID: <CADnq5_Nhc=SUfuL7ibNTiw677sAnm9Dva-sj0PUwBnO6JXfGuQ@mail.gmail.com> (raw)
In-Reply-To: <1619211404-5022-1-git-send-email-jrdr.linux@gmail.com>

On Fri, Apr 23, 2021 at 4:57 PM Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
> Kernel test robot throws below warning ->
>
> >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:3015:53:
> >> warning: address of 'aconnector->mst_port->mst_mgr' will always
> >> evaluate to 'true' [-Wpointer-bool-conversion]
>                            if (!(aconnector->port &&
> &aconnector->mst_port->mst_mgr))
>                                                   ~~
> ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
>
> Remove the condition which is always set to True.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
> index 9a13f47..8f7df11 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
> @@ -3012,7 +3012,7 @@ static int trigger_hpd_mst_set(void *data, u64 val)
>                         if (!aconnector->dc_link)
>                                 continue;
>
> -                       if (!(aconnector->port && &aconnector->mst_port->mst_mgr))
> +                       if (!aconnector->port)

@Harry Wentland any idea what this is supposed to be checking for?

Alex


>                                 continue;
>
>                         link = aconnector->dc_link;
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2021-04-28 21:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-23 20:56 Souptick Joarder
2021-04-28 21:05 ` Alex Deucher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADnq5_Nhc=SUfuL7ibNTiw677sAnm9Dva-sj0PUwBnO6JXfGuQ@mail.gmail.com' \
    --to=alexdeucher@gmail.com \
    --cc=Nicholas.Kazlauskas@amd.com \
    --cc=Wayne.Lin@amd.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=aurabindo.pillai@amd.com \
    --cc=bhanuprakash.modem@intel.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eryk.brol@amd.com \
    --cc=hwentlan@amd.com \
    --cc=jrdr.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikita.lipski@amd.com \
    --cc=nirmoy.das@amd.com \
    --cc=stylon.wang@amd.com \
    --cc=sunpeng.li@amd.com \
    --subject='Re: [PATCH] drm/amd/display: Remove condition which is always set to True' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).