From: Alex Deucher <alexdeucher@gmail.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: "David Airlie" <airlied@linux.ie>,
LKML <linux-kernel@vger.kernel.org>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Linux I2C" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH 6/6] drm/radeon: convert to use i2c_new_client_device()
Date: Fri, 27 Mar 2020 11:27:35 -0400 [thread overview]
Message-ID: <CADnq5_O-pXK1FeT1NfGBdXYZbqF6jmyXJNPgJt5qLaYMLiZy_Q@mail.gmail.com> (raw)
In-Reply-To: <20200327152535.GA2191@ravnborg.org>
On Fri, Mar 27, 2020 at 11:25 AM Sam Ravnborg <sam@ravnborg.org> wrote:
>
> On Fri, Mar 27, 2020 at 10:25:16AM -0400, Alex Deucher wrote:
> > On Thu, Mar 26, 2020 at 5:35 PM Wolfram Sang
> > <wsa+renesas@sang-engineering.com> wrote:
> > >
> > > Move away from the deprecated API.
> > >
> > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> >
> > patches 1,6, are:
> > Acked-by: Alex Deucher <alexander.deucher@amd.com>
> Should we commit all to drm-misc-next?
I'm fine to see it go through whatever tree makes sense.
Alex
>
> Sam
>
>
> >
> > > ---
> > > drivers/gpu/drm/radeon/radeon_atombios.c | 4 ++--
> > > drivers/gpu/drm/radeon/radeon_combios.c | 4 ++--
> > > 2 files changed, 4 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c b/drivers/gpu/drm/radeon/radeon_atombios.c
> > > index 848ef68d9086..5d2591725189 100644
> > > --- a/drivers/gpu/drm/radeon/radeon_atombios.c
> > > +++ b/drivers/gpu/drm/radeon/radeon_atombios.c
> > > @@ -2111,7 +2111,7 @@ static int radeon_atombios_parse_power_table_1_3(struct radeon_device *rdev)
> > > ucOverdriveThermalController];
> > > info.addr = power_info->info.ucOverdriveControllerAddress >> 1;
> > > strlcpy(info.type, name, sizeof(info.type));
> > > - i2c_new_device(&rdev->pm.i2c_bus->adapter, &info);
> > > + i2c_new_client_device(&rdev->pm.i2c_bus->adapter, &info);
> > > }
> > > }
> > > num_modes = power_info->info.ucNumOfPowerModeEntries;
> > > @@ -2351,7 +2351,7 @@ static void radeon_atombios_add_pplib_thermal_controller(struct radeon_device *r
> > > const char *name = pp_lib_thermal_controller_names[controller->ucType];
> > > info.addr = controller->ucI2cAddress >> 1;
> > > strlcpy(info.type, name, sizeof(info.type));
> > > - i2c_new_device(&rdev->pm.i2c_bus->adapter, &info);
> > > + i2c_new_client_device(&rdev->pm.i2c_bus->adapter, &info);
> > > }
> > > } else {
> > > DRM_INFO("Unknown thermal controller type %d at 0x%02x %s fan control\n",
> > > diff --git a/drivers/gpu/drm/radeon/radeon_combios.c b/drivers/gpu/drm/radeon/radeon_combios.c
> > > index c3e49c973812..d3c04df7e75d 100644
> > > --- a/drivers/gpu/drm/radeon/radeon_combios.c
> > > +++ b/drivers/gpu/drm/radeon/radeon_combios.c
> > > @@ -2704,7 +2704,7 @@ void radeon_combios_get_power_modes(struct radeon_device *rdev)
> > > const char *name = thermal_controller_names[thermal_controller];
> > > info.addr = i2c_addr >> 1;
> > > strlcpy(info.type, name, sizeof(info.type));
> > > - i2c_new_device(&rdev->pm.i2c_bus->adapter, &info);
> > > + i2c_new_client_device(&rdev->pm.i2c_bus->adapter, &info);
> > > }
> > > }
> > > } else {
> > > @@ -2721,7 +2721,7 @@ void radeon_combios_get_power_modes(struct radeon_device *rdev)
> > > const char *name = "f75375";
> > > info.addr = 0x28;
> > > strlcpy(info.type, name, sizeof(info.type));
> > > - i2c_new_device(&rdev->pm.i2c_bus->adapter, &info);
> > > + i2c_new_client_device(&rdev->pm.i2c_bus->adapter, &info);
> > > DRM_INFO("Possible %s thermal controller at 0x%02x\n",
> > > name, info.addr);
> > > }
> > > --
> > > 2.20.1
> > >
> > > _______________________________________________
> > > dri-devel mailing list
> > > dri-devel@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-03-27 15:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 21:09 [PATCH 0/6] gpu: convert to use new I2C API Wolfram Sang
2020-03-26 21:09 ` [PATCH 1/6] drm/amdgpu: convert to use i2c_new_client_device() Wolfram Sang
2020-03-26 21:10 ` [PATCH 2/6] drm/gma500: " Wolfram Sang
2020-03-26 21:10 ` [PATCH 3/6] drm/i2c/sil164: " Wolfram Sang
2020-03-26 21:10 ` [PATCH 4/6] drm/i2c/tda998x: " Wolfram Sang
2020-03-26 21:10 ` [PATCH 5/6] drm/nouveau/therm: " Wolfram Sang
2020-03-26 21:10 ` [PATCH 6/6] drm/radeon: " Wolfram Sang
2020-03-27 14:25 ` Alex Deucher
2020-03-27 15:25 ` Sam Ravnborg
2020-03-27 15:27 ` Alex Deucher [this message]
2020-03-27 15:45 ` Wolfram Sang
2020-03-27 17:03 ` Sam Ravnborg
2020-03-28 21:49 ` [PATCH 0/6] gpu: convert to use new I2C API Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_O-pXK1FeT1NfGBdXYZbqF6jmyXJNPgJt5qLaYMLiZy_Q@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).