From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,TVD_SPACE_RATIO, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31251C47089 for ; Thu, 27 May 2021 04:19:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E8303613CC for ; Thu, 27 May 2021 04:19:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E8303613CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 38E1B6EDF2; Thu, 27 May 2021 04:19:28 +0000 (UTC) Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8BAEF6E949; Thu, 27 May 2021 04:19:26 +0000 (UTC) Received: by mail-oi1-x235.google.com with SMTP id v22so3869718oic.2; Wed, 26 May 2021 21:19:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=GxApXEItPh1raGDrpdpbzF4cCWpre96Qop/w5eo9AH4=; b=uV2vMU5CdMvrqRlaky97MC3D0teGx7VHH8yKWf2LOSnCv/wkfttqnnyHi7/XdQPCn1 /2KgdpadhjBg31XJJO9gqCahvPtuwLTJnJShSeCaNQYGXbvPvmPlxxJXMM7bINw9XehF AiTa+iULDP4sNREsyOuVE5l8I2h+9sc/rLGEZ3NWBcGRpLZe3kjHN8CLTQTmA19nJdWe ds+J6vpsw71q+pUh3J0du0h1K9FdWzwZwx68eoKEeBOcVshDOACisnimmK7LB0tgXzlh U4qmS5LgPBd6E1ZhM6Z5FUvvyGqVpRQk8+/wmCHYyoXKCvpP1uT+wTx4fXpRI4QrEbvs q3sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=GxApXEItPh1raGDrpdpbzF4cCWpre96Qop/w5eo9AH4=; b=O5OHkT/fQJ9irxiRQzRTovJnxLzQizD0cia/+BC4KU8ZARPCdEMMljwmU4dfQ9qpiV buHpLvsdSIxxtOuTUxsPug8h027BhXsBAv3M2qn+PcIIJxIxt0lJIkH8V8m/RiZTTNmf mS1ycHv+8C40iC5uNdcLVDK5E41RSS6iuShX6Sng6MiJEX+yFAyL5ogmzROG+dn2c859 Ck047524zC1TMzc8vUV4KE1KXkdChQMZM9F6FTo9p8/q03CvjN5HYhMBQiV9fXsa66US +BXQn2W6VyVq2ybI77EAPNj4ucXV5JONZPzJkbM1J7qE9DylimyLRRNrnNGA5o691tFX vhvw== X-Gm-Message-State: AOAM532aWFGdgHbAtRU2eeY2na7UZtN1jFxKo4oU+EC2v8sCMKdeg2bW 6bJ3SUFqF9uDBlomuXgdMxWIRNYxhOg+1/dVA+0= X-Google-Smtp-Source: ABdhPJwRzRLtrY0LuUNzchMZWMetRzagOjLwXjzqQBkfGkeaUCxmv8eOs5mwrrp99/ek9z3LvjOx8XzgjsRD3y3ydH0= X-Received: by 2002:a05:6808:206:: with SMTP id l6mr4050235oie.5.1622089165937; Wed, 26 May 2021 21:19:25 -0700 (PDT) MIME-Version: 1.0 References: <20210526084726.552052-1-lee.jones@linaro.org> <20210526084726.552052-18-lee.jones@linaro.org> In-Reply-To: <20210526084726.552052-18-lee.jones@linaro.org> From: Alex Deucher Date: Thu, 27 May 2021 00:19:15 -0400 Message-ID: Subject: Re: [PATCH 17/34] drm/amd/display/dc/dce/dce_mem_input: Remove duplicate initialisation of GRPH_CONTROL__GRPH_NUM_BANKS_{SHIFT, MASK} To: Lee Jones Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , Mauro Rossi , LKML , Maling list - DRI developers , David Airlie , amd-gfx list , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Applied. Thanks! On Wed, May 26, 2021 at 4:48 AM Lee Jones wrote: > > Fixes the following W=3D1 kernel build warning(s): > > In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce= 60_resource.c:29: > drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_6_0_sh_mask.h:727= 0:45: warning: initialized field overwritten [-Woverride-init] > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_mem_input.h:155:28: not= e: in expansion of macro =E2=80=98GRPH_CONTROL__GRPH_NUM_BANKS__SHIFT=E2=80= =99 > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_mem_input.h:159:2: note= : in expansion of macro =E2=80=98SFB=E2=80=99 > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_mem_input.h:265:2: note= : in expansion of macro =E2=80=98MI_GFX6_TILE_MASK_SH_LIST=E2=80=99 > drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:657:3: n= ote: in expansion of macro =E2=80=98MI_DCE6_MASK_SH_LIST=E2=80=99 > drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_6_0_sh_mask.h:727= 0:45: note: (near initialization for =E2=80=98mi_shifts.GRPH_NUM_BANKS=E2= =80=99) > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_mem_input.h:155:28: not= e: in expansion of macro =E2=80=98GRPH_CONTROL__GRPH_NUM_BANKS__SHIFT=E2=80= =99 > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_mem_input.h:159:2: note= : in expansion of macro =E2=80=98SFB=E2=80=99 > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_mem_input.h:265:2: note= : in expansion of macro =E2=80=98MI_GFX6_TILE_MASK_SH_LIST=E2=80=99 > drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:657:3: n= ote: in expansion of macro =E2=80=98MI_DCE6_MASK_SH_LIST=E2=80=99 > drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_6_0_sh_mask.h:726= 9:43: warning: initialized field overwritten [-Woverride-init] > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_mem_input.h:155:28: not= e: in expansion of macro =E2=80=98GRPH_CONTROL__GRPH_NUM_BANKS_MASK=E2=80= =99 > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_mem_input.h:159:2: note= : in expansion of macro =E2=80=98SFB=E2=80=99 > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_mem_input.h:265:2: note= : in expansion of macro =E2=80=98MI_GFX6_TILE_MASK_SH_LIST=E2=80=99 > drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:662:3: n= ote: in expansion of macro =E2=80=98MI_DCE6_MASK_SH_LIST=E2=80=99 > drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_6_0_sh_mask.h:726= 9:43: note: (near initialization for =E2=80=98mi_masks.GRPH_NUM_BANKS=E2=80= =99) > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_mem_input.h:155:28: not= e: in expansion of macro =E2=80=98GRPH_CONTROL__GRPH_NUM_BANKS_MASK=E2=80= =99 > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_mem_input.h:159:2: note= : in expansion of macro =E2=80=98SFB=E2=80=99 > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_mem_input.h:265:2: note= : in expansion of macro =E2=80=98MI_GFX6_TILE_MASK_SH_LIST=E2=80=99 > drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:662:3: n= ote: in expansion of macro =E2=80=98MI_DCE6_MASK_SH_LIST=E2=80=99 > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian K=C3=B6nig" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Mauro Rossi > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones > --- > drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.h b/drivers= /gpu/drm/amd/display/dc/dce/dce_mem_input.h > index 23db5c72f07ed..9b1c4d56275a4 100644 > --- a/drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.h > +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.h > @@ -181,7 +181,6 @@ struct dce_mem_input_registers { > SFB(blk, GRPH_ENABLE, GRPH_ENABLE, mask_sh),\ > SFB(blk, GRPH_CONTROL, GRPH_DEPTH, mask_sh),\ > SFB(blk, GRPH_CONTROL, GRPH_FORMAT, mask_sh),\ > - SFB(blk, GRPH_CONTROL, GRPH_NUM_BANKS, mask_sh),\ > SFB(blk, GRPH_X_START, GRPH_X_START, mask_sh),\ > SFB(blk, GRPH_Y_START, GRPH_Y_START, mask_sh),\ > SFB(blk, GRPH_X_END, GRPH_X_END, mask_sh),\ > -- > 2.31.1 >