From: Alex Deucher <alexdeucher@gmail.com>
To: Jason Yan <yanaijie@huawei.com>
Cc: Dave Airlie <airlied@linux.ie>,
LKML <linux-kernel@vger.kernel.org>,
amd-gfx list <amd-gfx@lists.freedesktop.org>,
Hulk Robot <hulkci@huawei.com>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
"Deucher, Alexander" <alexander.deucher@amd.com>,
"Quan, Evan" <evan.quan@amd.com>,
Christian Koenig <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/amd/powerplay: remove defined but not used variables
Date: Fri, 17 Apr 2020 09:58:03 -0400 [thread overview]
Message-ID: <CADnq5_OTQEvOFZ3WaOAGQqMpkcsSkQ2fwge2+YUV59URnwLHgw@mail.gmail.com> (raw)
In-Reply-To: <20200417073219.40320-1-yanaijie@huawei.com>
On Fri, Apr 17, 2020 at 9:16 AM Jason Yan <yanaijie@huawei.com> wrote:
>
> Fix the following gcc warning:
>
> drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/vega10_powertune.c:710:46:
> warning: ‘PSMGCEDCThresholdConfig_vega10’ defined but not used
> [-Wunused-const-variable=]
> static const struct vega10_didt_config_reg
> PSMGCEDCThresholdConfig_vega10[] =
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/vega10_powertune.c:654:46:
> warning: ‘PSMSEEDCThresholdConfig_Vega10’ defined but not used
> [-Wunused-const-variable=]
> static const struct vega10_didt_config_reg
> PSMSEEDCThresholdConfig_Vega10[] =
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Applied. Thanks!
Alex
> ---
> .../amd/powerplay/hwmgr/vega10_powertune.c | 23 -------------------
> 1 file changed, 23 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c
> index ca9b23b5abc9..9757d47dd6b8 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c
> @@ -651,18 +651,6 @@ static const struct vega10_didt_config_reg PSMSEEDCStallDelayConfig_Vega10[] =
> { 0xFFFFFFFF } /* End of list */
> };
>
> -static const struct vega10_didt_config_reg PSMSEEDCThresholdConfig_Vega10[] =
> -{
> -/* ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> - * Offset Mask Shift Value
> - * ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> - */
> - /* SQ EDC THRESHOLD */
> - { ixDIDT_SQ_EDC_THRESHOLD, DIDT_SQ_EDC_THRESHOLD__EDC_THRESHOLD_MASK, DIDT_SQ_EDC_THRESHOLD__EDC_THRESHOLD__SHIFT, 0x0000 },
> -
> - { 0xFFFFFFFF } /* End of list */
> -};
> -
> static const struct vega10_didt_config_reg PSMSEEDCCtrlResetConfig_Vega10[] =
> {
> /* ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> @@ -707,17 +695,6 @@ static const struct vega10_didt_config_reg PSMSEEDCCtrlConfig_Vega10[] =
> { 0xFFFFFFFF } /* End of list */
> };
>
> -static const struct vega10_didt_config_reg PSMGCEDCThresholdConfig_vega10[] =
> -{
> -/* ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> - * Offset Mask Shift Value
> - * ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> - */
> - { mmGC_EDC_THRESHOLD, GC_EDC_THRESHOLD__EDC_THRESHOLD_MASK, GC_EDC_THRESHOLD__EDC_THRESHOLD__SHIFT, 0x0000000 },
> -
> - { 0xFFFFFFFF } /* End of list */
> -};
> -
> static const struct vega10_didt_config_reg PSMGCEDCDroopCtrlConfig_vega10[] =
> {
> /* ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> --
> 2.21.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-04-17 13:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 7:32 [PATCH] drm/amd/powerplay: remove defined but not used variables Jason Yan
2020-04-17 13:58 ` Alex Deucher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_OTQEvOFZ3WaOAGQqMpkcsSkQ2fwge2+YUV59URnwLHgw@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=evan.quan@amd.com \
--cc=hulkci@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).