From: Alex Deucher <alexdeucher@gmail.com>
To: "Koenig, Christian" <Christian.Koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/ttm: Break out the loops if need_resched in bo delayed delete worker
Date: Mon, 13 Apr 2020 11:35:13 -0400 [thread overview]
Message-ID: <CADnq5_ObHM4hJQ5Q4buq9n=1XRp7mt4S0ru-oqKxvnyR5yxvsw@mail.gmail.com> (raw)
In-Reply-To: <c76f92fc-b348-4d65-af6c-399e02969cf3@email.android.com>
Can you make sure this lands in drm-misc?
Thanks,
Alex
On Fri, Apr 10, 2020 at 8:15 AM Koenig, Christian
<Christian.Koenig@amd.com> wrote:
>
>
>
> Am 10.04.2020 12:58 schrieb "Pan, Xinhui" <Xinhui.Pan@amd.com>:
>
> The delayed delete list is per device which might be very huge. And in
> a heavy workload test, the list might always not be empty. That will
> trigger any RCU stall warnings or softlockups in non-preemptible kernels
> Lets do break out the loops in that case.
>
> Signed-off-by: xinhui pan <xinhui.pan@amd.com>
>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
> ---
> drivers/gpu/drm/ttm/ttm_bo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index 9e07c3f75156..c5b516fa4eae 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -518,7 +518,7 @@ static bool ttm_bo_delayed_delete(struct ttm_bo_device *bdev, bool remove_all)
> INIT_LIST_HEAD(&removed);
>
> spin_lock(&glob->lru_lock);
> - while (!list_empty(&bdev->ddestroy)) {
> + while (!list_empty(&bdev->ddestroy) && !need_resched()) {
> struct ttm_buffer_object *bo;
>
> bo = list_first_entry(&bdev->ddestroy, struct ttm_buffer_object,
> --
> 2.17.1
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-13 15:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-10 12:15 [PATCH] drm/ttm: Break out the loops if need_resched in bo delayed delete worker Koenig, Christian
2020-04-13 15:35 ` Alex Deucher [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-04-10 10:58 xinhui pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADnq5_ObHM4hJQ5Q4buq9n=1XRp7mt4S0ru-oqKxvnyR5yxvsw@mail.gmail.com' \
--to=alexdeucher@gmail.com \
--cc=Christian.Koenig@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).