dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Alex Deucher <alexdeucher@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: "Leo Li" <sunpeng.li@amd.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
	"David Airlie" <airlied@linux.ie>,
	"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 10/34] drm/amd/display/dc/bios/bios_parser: Fix formatting and misnaming issues
Date: Wed, 26 May 2021 23:57:27 -0400	[thread overview]
Message-ID: <CADnq5_OteJ0ZZSKqbZ-j3KD7kGajoEyq-F7=VFbruvgxRQC6yQ@mail.gmail.com> (raw)
In-Reply-To: <20210526084726.552052-11-lee.jones@linaro.org>

Applied.  Thanks!

On Wed, May 26, 2021 at 4:47 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:997: warning: expecting prototype for get_ss_info_from_table(). Prototype was for get_ss_info_from_tbl() instead
>  drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1562: warning: expecting prototype for BiosParserObject(). Prototype was for bios_parser_get_ss_entry_number() instead
>  drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1739: warning: expecting prototype for get_ss_entry_number_from_internal_ss_info_table_V3_1(). Prototype was for get_ss_entry_number_from_internal_ss_info_tbl_V3_1() instead
>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/gpu/drm/amd/display/dc/bios/bios_parser.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c b/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c
> index c67d21a5ee52f..9b8ea6e9a2b96 100644
> --- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c
> +++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c
> @@ -979,7 +979,7 @@ static enum bp_result get_ss_info_from_internal_ss_info_tbl_V2_1(
>         struct spread_spectrum_info *info);
>
>  /**
> - * get_ss_info_from_table
> + * get_ss_info_from_tbl
>   * Get spread sprectrum information from the ASIC_InternalSS_Info Ver 2.1 or
>   * SS_Info table from the VBIOS
>   * There can not be more than 1 entry for  ASIC_InternalSS_Info Ver 2.1 or
> @@ -1548,7 +1548,7 @@ static uint32_t get_ss_entry_number_from_ss_info_tbl(
>         uint32_t id);
>
>  /**
> - * BiosParserObject::GetNumberofSpreadSpectrumEntry
> + * bios_parser_get_ss_entry_number
>   * Get Number of SpreadSpectrum Entry from the ASIC_InternalSS_Info table from
>   * the VBIOS that match the SSid (to be converted from signal)
>   *
> @@ -1725,7 +1725,7 @@ static uint32_t get_ss_entry_number_from_internal_ss_info_tbl_v2_1(
>         return 0;
>  }
>  /**
> - * get_ss_entry_number_from_internal_ss_info_table_V3_1
> + * get_ss_entry_number_from_internal_ss_info_tbl_V3_1
>   * Get Number of SpreadSpectrum Entry from the ASIC_InternalSS_Info table of
>   * the VBIOS that matches id
>   *
> --
> 2.31.1
>

  reply	other threads:[~2021-05-27  3:57 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26  8:46 [PATCH 00/34] Rid W=1 warnings from GPU Lee Jones
2021-05-26  8:46 ` [PATCH 01/34] drm/amd/pm/inc/smu_v13_0: Move table into the only source file that uses it Lee Jones
2021-05-27  3:42   ` Alex Deucher
2021-05-26  8:46 ` [PATCH 02/34] drm/amd/pm/swsmu/smu13/aldebaran_ppt: Remove unused variable 'ret' Lee Jones
2021-05-27  3:49   ` Alex Deucher
2021-05-26  8:46 ` [PATCH 03/34] drm/amd/pm/powerplay/hwmgr/smu7_thermal: Provide function name for 'smu7_fan_ctrl_set_default_mode()' Lee Jones
2021-05-27  3:51   ` Alex Deucher
2021-05-26  8:46 ` [PATCH 04/34] drm/amd/pm/powerplay/hwmgr/vega12_thermal: Provide function name Lee Jones
2021-05-27  3:52   ` Alex Deucher
2021-05-26  8:46 ` [PATCH 05/34] drm/amd/pm/powerplay/hwmgr/vega12_hwmgr: Provide 'vega12_init_smc_table()' " Lee Jones
2021-05-27  3:53   ` Alex Deucher
2021-05-26  8:46 ` [PATCH 06/34] drm/amd/pm/powerplay/hwmgr/vega10_hwmgr: Kernel-doc headers must contain function names Lee Jones
2021-05-27  3:54   ` Alex Deucher
2021-05-26  8:46 ` [PATCH 07/34] drm/amd/pm/powerplay/hwmgr/vega20_hwmgr: Provide function name 'vega20_init_smc_table()' Lee Jones
2021-05-27  3:54   ` Alex Deucher
2021-05-26  8:47 ` [PATCH 08/34] drm/amd/display/dc/bios/command_table_helper: Fix function name for 'dal_cmd_table_helper_transmitter_bp_to_atom()' Lee Jones
2021-05-27  3:55   ` Alex Deucher
2021-05-26  8:47 ` [PATCH 09/34] drm/amd/display/dc/bios/command_table_helper2: Fix function name 'dal_cmd_table_helper_transmitter_bp_to_atom2()' Lee Jones
2021-05-27  3:56   ` Alex Deucher
2021-05-26  8:47 ` [PATCH 10/34] drm/amd/display/dc/bios/bios_parser: Fix formatting and misnaming issues Lee Jones
2021-05-27  3:57   ` Alex Deucher [this message]
2021-05-26  8:47 ` [PATCH 11/34] drm/nouveau/nvkm/subdev/mc/tu102: Make functions called by reference static Lee Jones
2021-05-26 11:16   ` [Nouveau] " Karol Herbst
2021-05-26  8:47 ` [PATCH 12/34] drm/amd/display/amdgpu_dm/amdgpu_dm: Functions must directly follow their headers Lee Jones
2021-05-27  3:59   ` Alex Deucher
2021-05-26  8:47 ` [PATCH 13/34] drm/amd/display/dc/dce/dmub_outbox: Convert over to kernel-doc Lee Jones
2021-05-27  4:00   ` Alex Deucher
2021-05-26  8:47 ` [PATCH 14/34] drm/amd/display/dc/gpio/gpio_service: Pass around correct dce_{version, environment} types Lee Jones
2021-05-27  4:06   ` Alex Deucher
2021-05-26  8:47 ` [PATCH 15/34] drm/amd/display/dc/dce110/dce110_hw_sequencer: Include our own header Lee Jones
2021-05-27  4:07   ` Alex Deucher
2021-05-26  8:47 ` [PATCH 16/34] drm/amd/display/dc/dce/dce_transform: Remove superfluous re-initialisation of DCFE_MEM_LIGHT_SLEEP_CNTL, Lee Jones
2021-05-27  4:12   ` Alex Deucher
2021-05-26  8:47 ` [PATCH 17/34] drm/amd/display/dc/dce/dce_mem_input: Remove duplicate initialisation of GRPH_CONTROL__GRPH_NUM_BANKS_{SHIFT, MASK} Lee Jones
2021-05-27  4:19   ` Alex Deucher
2021-05-26  8:47 ` [PATCH 18/34] drm/amd/display/dc/dce/dce_mem_input: Remove duplicate initialisation of GRPH_CONTROL__GRPH_NUM_BANKS_{SHIFT, MASK Lee Jones
2021-05-27  4:20   ` Alex Deucher
2021-05-26  8:47 ` [PATCH 19/34] drm/amd/amdgpu/amdgpu_device: Make local function static Lee Jones
2021-05-27  4:20   ` Alex Deucher
2021-05-26  8:47 ` [PATCH 20/34] drm/amd/display/amdgpu_dm/amdgpu_dm: Fix kernel-doc formatting issue Lee Jones
2021-05-27  4:22   ` Alex Deucher
2021-05-26  8:47 ` [PATCH 21/34] drm/amd/display/dc/dce110/dce110_hw_sequencer: Include header containing our prototypes Lee Jones
2021-05-27  4:25   ` Alex Deucher
2021-05-26  8:47 ` [PATCH 22/34] drm/amd/display/dc/core/dc: Convert function headers to kernel-doc Lee Jones
2021-05-27  4:26   ` Alex Deucher
2021-05-26  8:47 ` [PATCH 23/34] drm/amd/display/dmub/src/dmub_srv_stat: Convert function header " Lee Jones
2021-05-27  4:27   ` Alex Deucher
2021-05-26  8:47 ` [PATCH 24/34] drm/amd/display/modules/hdcp/hdcp_psp: Remove unused function 'mod_hdcp_hdcp1_get_link_encryption_status()' Lee Jones
2021-05-27  4:28   ` Alex Deucher
2021-05-26  8:47 ` [PATCH 25/34] drm/xlnx/zynqmp_disp: Fix incorrectly named enum 'zynqmp_disp_layer_id' Lee Jones
2021-05-26  8:47 ` [PATCH 26/34] drm/xlnx/zynqmp_dp: Fix incorrectly name function 'zynqmp_dp_train()' Lee Jones
2021-05-26  8:47 ` [PATCH 27/34] drm/ttm/ttm_tt: Demote non-conformant kernel-doc header Lee Jones
2021-05-26  8:47 ` [PATCH 28/34] drm/panel/panel-raspberrypi-touchscreen: Demote kernel-doc abuse Lee Jones
2021-05-26  8:47 ` [PATCH 29/34] drm/panel/panel-sitronix-st7701: " Lee Jones
2021-05-26  8:47 ` [PATCH 30/34] drm/vgem/vgem_drv: Standard comment blocks should not use kernel-doc format Lee Jones
2021-05-26 13:10   ` Daniel Vetter
2021-05-26  8:47 ` [PATCH 31/34] drm/exynos/exynos7_drm_decon: Fix incorrect naming of 'decon_shadow_protect_win()' Lee Jones
2021-05-26  8:47 ` [PATCH 32/34] drm/exynos/exynos_drm_ipp: Fix documentation for 'exynos_drm_ipp_get_{caps, res}_ioctl()' Lee Jones
2021-05-26  8:47 ` [PATCH 33/34] drm/vboxvideo/hgsmi_base: Place function names into headers Lee Jones
2021-05-26  8:47 ` [PATCH 34/34] drm/vboxvideo/modesetting: Provide function names for prototype headers Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADnq5_OteJ0ZZSKqbZ-j3KD7kGajoEyq-F7=VFbruvgxRQC6yQ@mail.gmail.com' \
    --to=alexdeucher@gmail.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sunpeng.li@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).