From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75240C4320E for ; Thu, 26 Aug 2021 18:00:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E47561004 for ; Thu, 26 Aug 2021 18:00:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3E47561004 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9C5176E893; Thu, 26 Aug 2021 18:00:02 +0000 (UTC) Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by gabe.freedesktop.org (Postfix) with ESMTPS id DA5016E056 for ; Thu, 26 Aug 2021 18:00:00 +0000 (UTC) Received: by mail-ot1-x331.google.com with SMTP id x10-20020a056830408a00b004f26cead745so4597033ott.10 for ; Thu, 26 Aug 2021 11:00:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=RcIYF9R/pHJGqLoLVM8C2PNIjlEdG+08V6XIw2z0GXA=; b=bEcMfQI7Jf4WT5ynaI3vWPhlVDv8Cva8+DmGatup6oPvlw20KIo97L2C2ScgUKHhVC hdUPgZ6+b4k87ono5IHVsrFOPhC67bHf4R3Tt00XuS3+xegaCJtLSJtW8sUdyUqUBR7b Ep9YqQSIAcuV+fwTcLMpIY5lLK3AD/zdnpTu8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=RcIYF9R/pHJGqLoLVM8C2PNIjlEdG+08V6XIw2z0GXA=; b=Zfp7ULgpVkcot/e3FYndyBoCirLOfZHwmVPqjAmXQt4dSiDqmgk30F7jxDfk3jVLCU Ffdzgiobua1BAZv1fg0KIutVo0mvE/weZeJkRiAxuxa5mGPKtlgVpLTPmM0IjVmkhmOT Oez9XHlERiNr1BqL15eyfFN+4v2nKHSYpSlJHcBKyMVAAIzkaUwh7kLmUuAq5so5hGt9 OlW6vTZ8PSW7JpZTtRSO2gMTpZmMb/JIEkLIE92NGjciEb9RTw+iUdIve6ZKL7s5NRJr cg6Tq22w4DJgfrsQPropW8Fy5oKQmP8gqKd4Hv6FaHVdeubRPij3MMj75d3dwb7Bx9ZF AGYw== X-Gm-Message-State: AOAM533s3yO+2q49QqZ5k1U7cUDZdkfVBP5hDlrcx9K2MCHB/hFnmkWh bHDSw/vEbh/Na8yq9Jb5Dl0wl68spewSs5GfeQFRQK11kVA= X-Google-Smtp-Source: ABdhPJyu2G2XRMt2TFHuTq1cHhTZmiAqHMH+7NXBJGNrokExA+VfOjpgGhUKc4kR5HSTLWP8EzKT6YUkZBeBKGhkVvw= X-Received: by 2002:a05:6830:2b24:: with SMTP id l36mr4312663otv.25.1630000799901; Thu, 26 Aug 2021 10:59:59 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 26 Aug 2021 17:59:59 +0000 MIME-Version: 1.0 In-Reply-To: References: <20210825234233.1721068-1-bjorn.andersson@linaro.org> <20210825234233.1721068-4-bjorn.andersson@linaro.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Thu, 26 Aug 2021 17:59:59 +0000 Message-ID: Subject: Re: [PATCH v2 3/5] drm/msm/dp: Support up to 3 DP controllers To: Bjorn Andersson Cc: Abhinav Kumar , Daniel Vetter , David Airlie , Dmitry Baryshkov , Kalyan Thota , Kuogee Hsieh , Rob Clark , Sean Paul , Rob Herring , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Bjorn Andersson (2021-08-26 09:57:18) > On Thu 26 Aug 00:13 PDT 2021, Stephen Boyd wrote: > > Quoting Bjorn Andersson (2021-08-25 16:42:31) > > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > [..] > > > @@ -203,8 +204,8 @@ static int dpu_kms_debugfs_init(struct msm_kms *kms, struct drm_minor *minor) > > > dpu_debugfs_vbif_init(dpu_kms, entry); > > > dpu_debugfs_core_irq_init(dpu_kms, entry); > > > > > > - if (priv->dp) > > > - msm_dp_debugfs_init(priv->dp, minor); > > > + for (i = 0; i < ARRAY_SIZE(priv->dp); i++) > > > + msm_dp_debugfs_init(priv->dp[i], minor); > > > > Does this need the same if (!priv->dp) continue check like the other > > loops over priv->dp? > > > [..] > > > @@ -800,7 +809,8 @@ static int dpu_irq_postinstall(struct msm_kms *kms) > > > if (!priv) > > > return -EINVAL; > > > > > > - msm_dp_irq_postinstall(priv->dp); > > > + for (i = 0; i < ARRAY_SIZE(priv->dp); i++) > > > + msm_dp_irq_postinstall(priv->dp[i]); > > > > This one too? Or maybe those gained NULL pointer checks. > > > > This already has a NULL check, that's why I added one to the adjacent > msm_dp_debugfs_init() as well. Ok. > > > > > > > return 0; > > > } > > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > [..] > > > @@ -1194,6 +1230,10 @@ static int dp_display_probe(struct platform_device *pdev) > > > if (!dp) > > > return -ENOMEM; > > > > > > + dp->id = dp_display_get_id(pdev); > > > > Ah ok, it's signed for this error check. Maybe assign dp->id in the > > function and return 0 instead of assigning it here? > > dp_display_assign_id() > > > > I like the fact that the "getter" doesn't have side effects, but making > dp->id unsigned makes sense. So let's pay the price of a local signed > variable here. > Sure. If that's the only change then feel free to add Reviewed-by: Stephen Boyd on the next version.