From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E341C432BE for ; Thu, 22 Jul 2021 19:08:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2174260EB6 for ; Thu, 22 Jul 2021 19:08:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2174260EB6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 90D766EB1A; Thu, 22 Jul 2021 19:08:05 +0000 (UTC) Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9B2AC6EB1A for ; Thu, 22 Jul 2021 19:08:04 +0000 (UTC) Received: by mail-ot1-x32c.google.com with SMTP id 59-20020a9d0ac10000b0290462f0ab0800so6272006otq.11 for ; Thu, 22 Jul 2021 12:08:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=scp+1rc24jdnxfL7eF19kK3DL+3J9gDohwlrgvGebZ0=; b=Kzg1+v+ASBz1l6YFdUYjoIJ1ycL30KyMVNUxiZbSsy/9xwgH7nYvbx0C2luXa/RK6v hHxo0L2IjE8alE4iJAA9A3eGelmKnpSy2X9ID5+zVi+2oucyhkHRSZFjbrdICtI1EGtp EERE2M2fk6+PWXVFGXH8veERzxrjmQZPsQdMI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=scp+1rc24jdnxfL7eF19kK3DL+3J9gDohwlrgvGebZ0=; b=Hb3pi9cdXyw2lAErA2gpCSJncU12+CEyytRQdVmHtKCVBQI3p1YIcdm/mb2EW7TRA/ Gqi0OBKONbBrfMcAxp6+tqna5s2714OPsUlZCFB97rtE45w/v9lpLlJ5k2zwyYGIDSDO rwlnUO6m1hbTaIMb0T8jCqhgEaWCkN6ZBBhUyTLLBP/QyvnwgUTsx7Xzct9LadBY4aui rJKoq+/jy7uN6QMzBzmt5ReGH+5VTon+qB7inQr9+mKL/RzzB73fp9ZjjdwvMRTwI+ZV 30GQi8HOu7nVqWtDMNhlMH/EPfOaJIr1F9x46YP9tERY+anp6HU7mUB6MCBP9Bz049vr wpXA== X-Gm-Message-State: AOAM531g/sU0oIRpi9V1Khv24m9XaESzSdMbw1wGsnabjcgTPlw2Wnat tfRW4XVH2KiHEXirQSJBlnVOH7s0DPtzvqyVEV3Xug== X-Google-Smtp-Source: ABdhPJzKPYX4blphNqYsrnAPfYagc8nG5lxdFDRdRvNxCcZa50YCfFPtbMdNhV6GjS7SG0R1yOQPOpaxxJ5vYACZZ0E= X-Received: by 2002:a9d:650e:: with SMTP id i14mr838011otl.233.1626980883940; Thu, 22 Jul 2021 12:08:03 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 22 Jul 2021 19:08:03 +0000 MIME-Version: 1.0 In-Reply-To: <1626191647-13901-4-git-send-email-khsieh@codeaurora.org> References: <1626191647-13901-1-git-send-email-khsieh@codeaurora.org> <1626191647-13901-4-git-send-email-khsieh@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Thu, 22 Jul 2021 19:08:03 +0000 Message-ID: Subject: Re: [PATCH v2 3/7] drm/msm/dp: reset aux controller after dp_aux_cmd_fifo_tx() failed. To: Kuogee Hsieh , dri-devel@lists.freedesktop.org, robdclark@gmail.com, sean@poorly.run Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, abhinavk@codeaurora.org, bjorn.andersson@linaro.org, aravindh@codeaurora.org, freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Kuogee Hsieh (2021-07-13 08:54:03) > Aux hardware calibration sequence requires resetting the aux controller > in order for the new setting to take effect. However resetting the AUX > controller will also clear HPD interrupt status which may accidentally > cause pending unplug interrupt to get lost. Therefore reset aux > controller only when link is in connection state when dp_aux_cmd_fifo_tx() > fail. This fixes Link Layer CTS cases 4.2.1.1 and 4.2.1.2. > > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd