From: Navid Emamdoost <navid.emamdoost@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Qiushi Wu <wu000273@umn.edu>, David Airlie <airlied@linux.ie>,
Stephen McCamant <smccaman@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
etnaviv@lists.freedesktop.org,
dri-devel <dri-devel@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Navid Emamdoost <emamd001@umn.edu>,
Russell King <linux+etnaviv@armlinux.org.uk>
Subject: Re: [PATCH] drm/etnaviv: fix ref count leak via pm_runtime_get_sync
Date: Mon, 15 Jun 2020 01:13:09 -0500 [thread overview]
Message-ID: <CAEkB2EQmtRh4HjhykCdKtw8SPaQWgLHgDc7VQ3=H0ssz=m1Y-Q@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VcLR2w9Ym0YOqUT9G8xT9qWrdD1-wP4UA-1wtuwCNxqSA@mail.gmail.com>
On Sun, Jun 14, 2020 at 4:48 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Sun, Jun 14, 2020 at 9:48 AM Navid Emamdoost
> <navid.emamdoost@gmail.com> wrote:
>
> ...
>
> > + if (ret < 0) {
>
> > + pm_runtime_put(gpu->dev);
>
> Please, in all your patches fix this to be _put_noidle(). We wouldn't
> bear the flag day of fixing these parts again.
> Yes, I know that *now* behaviour is the same, but calling put here is
> slightly inconsistent.
v2 is sent.
>
> ...
>
> > + pm_runtime_put(gpu->dev);
>
> --
> With Best Regards,
> Andy Shevchenko
--
Navid.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-06-15 7:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 6:46 [PATCH] drm/etnaviv: fix ref count leak via pm_runtime_get_sync Navid Emamdoost
2020-06-14 9:48 ` Andy Shevchenko
2020-06-15 6:12 ` [PATCH v2] " Navid Emamdoost
2020-06-17 9:53 ` Lucas Stach
2020-06-17 17:57 ` Navid Emamdoost
2020-06-15 6:13 ` Navid Emamdoost [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEkB2EQmtRh4HjhykCdKtw8SPaQWgLHgDc7VQ3=H0ssz=m1Y-Q@mail.gmail.com' \
--to=navid.emamdoost@gmail.com \
--cc=airlied@linux.ie \
--cc=andy.shevchenko@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emamd001@umn.edu \
--cc=etnaviv@lists.freedesktop.org \
--cc=kjlu@umn.edu \
--cc=linux+etnaviv@armlinux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=smccaman@umn.edu \
--cc=wu000273@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).