From: Rob Clark <robdclark@gmail.com>
To: Stephen Boyd <swboyd@chromium.org>
Cc: freedreno <freedreno@lists.freedesktop.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Abhinav Kumar <abhinavk@codeaurora.org>,
Kalyan Thota <kalyan_t@codeaurora.org>,
Sean Paul <sean@poorly.run>
Subject: Re: [Freedreno] [PATCH] drm/msm/dpu: Remove chatty vbif debug print
Date: Wed, 18 Nov 2020 07:49:31 -0800 [thread overview]
Message-ID: <CAF6AEGsDyvFVxAME1_VUprPKdrpEGdvP9XrQEG_-=1mRRcRBow@mail.gmail.com> (raw)
In-Reply-To: <160565358127.60232.4382778730228368993@swboyd.mtv.corp.google.com>
On Tue, Nov 17, 2020 at 2:53 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Quoting abhinavk@codeaurora.org (2020-11-17 12:34:56)
> > On 2020-11-17 09:26, Stephen Boyd wrote:
> > > I don't know what this debug print is for but it is super chatty,
> > > throwing 8 lines of debug prints in the logs every time we update a
> > > plane. It looks like it has no value. Let's nuke it so we can get
> > > better logs.
> > >
> > > Cc: Sean Paul <sean@poorly.run>
> > > Cc: Abhinav Kumar <abhinavk@codeaurora.org>
> > > Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> >
> > > ---
> > > drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c | 3 ---
> > > 1 file changed, 3 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c
> > > b/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c
> > > index 5e8c3f3e6625..5eb2b2ee09f5 100644
> > > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c
> > > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c
> > > @@ -245,9 +245,6 @@ void dpu_vbif_set_qos_remap(struct dpu_kms
> > > *dpu_kms,
> > > forced_on = mdp->ops.setup_clk_force_ctrl(mdp, params->clk_ctrl,
> > > true);
> > >
> > > for (i = 0; i < qos_tbl->npriority_lvl; i++) {
> > > - DPU_DEBUG("vbif:%d xin:%d lvl:%d/%d\n",
> > > - params->vbif_idx, params->xin_id, i,
> > > - qos_tbl->priority_lvl[i]);
> >
> > Instead of getting rid of this print, we should optimize the caller of
> > this.
>
> Does the print tell us anything? Right now it prints 8 lines where it
> feels like it could be trimmed down:
>
> [drm:dpu_vbif_set_qos_remap] vbif:0 xin:0 lvl:0/3
> [drm:dpu_vbif_set_qos_remap] vbif:0 xin:0 lvl:1/3
> [drm:dpu_vbif_set_qos_remap] vbif:0 xin:0 lvl:2/4
> [drm:dpu_vbif_set_qos_remap] vbif:0 xin:0 lvl:3/4
> [drm:dpu_vbif_set_qos_remap] vbif:0 xin:0 lvl:4/5
> [drm:dpu_vbif_set_qos_remap] vbif:0 xin:0 lvl:5/5
> [drm:dpu_vbif_set_qos_remap] vbif:0 xin:0 lvl:6/6
> [drm:dpu_vbif_set_qos_remap] vbif:0 xin:0 lvl:7/6
>
> maybe one line that combines the index into values?
>
> [drm:dpu_vbif_set_qos_remap] vbif:0 xin:0 [3 3 4 4 5 5 6 6]
>
or possibly convert to a tracepoint (so it doesn't spam the drm_trace buffer)
BR,
-R
> But again I have no idea if this print is really useful. Maybe we can
> print it only if the value changes from what was already there?
> Basically move the print into dpu_hw_set_qos_remap() and then skip out
> early if nothing changed or print and modify the register.
>
> > This is what
> > we are doing in downstream. So we need to update the property only if we
> > are switching from a RT client
> > to non-RT client for the plane and vice-versa. So we should try to do
> > the same thing here.
> >
> > is_rt = sde_crtc_is_rt_client(crtc, crtc->state);
> > if (is_rt != psde->is_rt_pipe) {
> > psde->is_rt_pipe = is_rt;
> > pstate->dirty |= SDE_PLANE_DIRTY_QOS;
> > }
> >
> >
> > if (pstate->dirty & DPU_PLANE_DIRTY_QOS)
> > _dpu_plane_set_qos_remap(plane);
> >
>
> Sounds great! Can you send the patch?
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-11-18 15:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 17:26 [PATCH] drm/msm/dpu: Remove chatty vbif debug print Stephen Boyd
2020-11-17 20:34 ` [Freedreno] " abhinavk
2020-11-17 22:53 ` Stephen Boyd
2020-11-18 15:49 ` Rob Clark [this message]
2020-11-18 20:03 ` abhinavk
2020-11-19 21:43 ` abhinavk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF6AEGsDyvFVxAME1_VUprPKdrpEGdvP9XrQEG_-=1mRRcRBow@mail.gmail.com' \
--to=robdclark@gmail.com \
--cc=abhinavk@codeaurora.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=kalyan_t@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).