From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Clark Subject: Re: [Intel-gfx] [PATCH 2/6] drm/atomic: Only destroy connector states with connection mutex held Date: Wed, 19 Nov 2014 15:22:38 -0500 Message-ID: References: <1416418691-24747-1-git-send-email-daniel.vetter@ffwll.ch> <1416418691-24747-2-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1416418691-24747-2-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , DRI Development List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBOb3YgMTksIDIwMTQgYXQgMTI6MzggUE0sIERhbmllbCBWZXR0ZXIgPGRhbmllbC52 ZXR0ZXJAZmZ3bGwuY2g+IHdyb3RlOgo+IE90aGVyd2lzZSB0aGUgY29ubmVjdG9yIG1pZ2h0IGhh dmUgYmVlbiB1bnBsdWdnZWQgYW5kIGRlc3Ryb3llZCB3aGlsZQo+IHdlIGRpZG4ndCBsb29rLiBZ ZXQgYW5vdGhlciBmYWxsb3V0IGZyb20gRFAgTVNUIGhvdHBsdWdnaW5nIHRoYXQgSQo+IGRpZG4n dCBjb25zaWRlci4KPgo+IFRvIG1ha2Ugc3VyZSB3ZSBnZXQgdGhpcyByaWdodCBhZGQgYW4gYXBw cm9wcmlhdGUgV0FSTl9PTiB0bwo+IGRybV9hdG9taWNfc3RhdGVfY2xlYXIgKG9idmlvdXNseSBv bmx5IHdoZW4gd2UgYWN0dWFsbHkgaGF2ZSBhIHN0YXRlCj4gdG8gY2xlYXIgdXApLiBBbmQgcmVv cmRlciBhbGwgdGhlIHN0YXRlX2NsZWFyIGFuZCBiYWNrb2ZmIGNhbGxzIHRvCj4gbWFrZSBpdCB3 b3JrIG91dCBwcm9wZXJseS4KPgo+IFNpZ25lZC1vZmYtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmll bC52ZXR0ZXJAaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IFJvYiBDbGFyayA8cm9iZGNsYXJrQGdt YWlsLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMgICAgICAgIHwg IDkgKysrKysrLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jIHwgMTQg KysrKysrKy0tLS0tLS0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAxMCBk ZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5j IGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYwo+IGluZGV4IDkwYjJkMTY0NGJkNy4uNjdj MWRjODk0YmQ5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jCj4gQEAgLTExMiwyMSArMTEyLDI0IEBA IEVYUE9SVF9TWU1CT0woZHJtX2F0b21pY19zdGF0ZV9hbGxvYyk7Cj4gIHZvaWQgZHJtX2F0b21p Y19zdGF0ZV9jbGVhcihzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4gIHsKPiAgICAg ICAgIHN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBzdGF0ZS0+ZGV2Owo+ICsgICAgICAgc3RydWN0 IGRybV9tb2RlX2NvbmZpZyAqY29uZmlnID0gJmRldi0+bW9kZV9jb25maWc7Cj4gICAgICAgICBp bnQgaTsKPgo+ICAgICAgICAgRFJNX0RFQlVHX0tNUygiQ2xlYXJpbmcgYXRvbWljIHN0YXRlICVw XG4iLCBzdGF0ZSk7Cj4KPiAtICAgICAgIGZvciAoaSA9IDA7IGkgPCBkZXYtPm1vZGVfY29uZmln Lm51bV9jb25uZWN0b3I7IGkrKykgewo+ICsgICAgICAgZm9yIChpID0gMDsgaSA8IGNvbmZpZy0+ bnVtX2Nvbm5lY3RvcjsgaSsrKSB7Cj4gICAgICAgICAgICAgICAgIHN0cnVjdCBkcm1fY29ubmVj dG9yICpjb25uZWN0b3IgPSBzdGF0ZS0+Y29ubmVjdG9yc1tpXTsKPgo+ICAgICAgICAgICAgICAg ICBpZiAoIWNvbm5lY3RvcikKPiAgICAgICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsKPgo+ ICsgICAgICAgICAgICAgICBXQVJOX09OKCFkcm1fbW9kZXNldF9pc19sb2NrZWQoJmNvbmZpZy0+ Y29ubmVjdGlvbl9tdXRleCkpOwo+ICsKPiAgICAgICAgICAgICAgICAgY29ubmVjdG9yLT5mdW5j cy0+YXRvbWljX2Rlc3Ryb3lfc3RhdGUoY29ubmVjdG9yLAo+ICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdGF0ZS0+Y29ubmVjdG9yX3N0YXRl c1tpXSk7Cj4gICAgICAgICB9Cj4KPiAtICAgICAgIGZvciAoaSA9IDA7IGkgPCBkZXYtPm1vZGVf Y29uZmlnLm51bV9jcnRjOyBpKyspIHsKPiArICAgICAgIGZvciAoaSA9IDA7IGkgPCBjb25maWct Pm51bV9jcnRjOyBpKyspIHsKPiAgICAgICAgICAgICAgICAgc3RydWN0IGRybV9jcnRjICpjcnRj ID0gc3RhdGUtPmNydGNzW2ldOwo+Cj4gICAgICAgICAgICAgICAgIGlmICghY3J0YykKPiBAQCAt MTM2LDcgKzEzOSw3IEBAIHZvaWQgZHJtX2F0b21pY19zdGF0ZV9jbGVhcihzdHJ1Y3QgZHJtX2F0 b21pY19zdGF0ZSAqc3RhdGUpCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBzdGF0ZS0+Y3J0Y19zdGF0ZXNbaV0pOwo+ICAgICAgICAgfQo+Cj4gLSAg ICAgICBmb3IgKGkgPSAwOyBpIDwgZGV2LT5tb2RlX2NvbmZpZy5udW1fdG90YWxfcGxhbmU7IGkr Kykgewo+ICsgICAgICAgZm9yIChpID0gMDsgaSA8IGNvbmZpZy0+bnVtX3RvdGFsX3BsYW5lOyBp KyspIHsKPiAgICAgICAgICAgICAgICAgc3RydWN0IGRybV9wbGFuZSAqcGxhbmUgPSBzdGF0ZS0+ cGxhbmVzW2ldOwo+Cj4gICAgICAgICAgICAgICAgIGlmICghcGxhbmUpCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2Ry bV9hdG9taWNfaGVscGVyLmMKPiBpbmRleCBmYWQyYjkzMmNmNzIuLjBjZDA1NDYxNTkyMCAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gQEAgLTEyMTcsOCArMTIxNyw4IEBA IGZhaWw6Cj4KPiAgICAgICAgIHJldHVybiByZXQ7Cj4gIGJhY2tvZmY6Cj4gLSAgICAgICBkcm1f YXRvbWljX2xlZ2FjeV9iYWNrb2ZmKHN0YXRlKTsKPiAgICAgICAgIGRybV9hdG9taWNfc3RhdGVf Y2xlYXIoc3RhdGUpOwo+ICsgICAgICAgZHJtX2F0b21pY19sZWdhY3lfYmFja29mZihzdGF0ZSk7 Cj4KPiAgICAgICAgIC8qCj4gICAgICAgICAgKiBTb21lb25lIG1pZ2h0IGhhdmUgZXhjaGFuZ2Vk IHRoZSBmcmFtZWJ1ZmZlciB3aGlsZSB3ZSBkcm9wcGVkIGxvY2tzCj4gQEAgLTEyODUsOCArMTI4 NSw4IEBAIGZhaWw6Cj4KPiAgICAgICAgIHJldHVybiByZXQ7Cj4gIGJhY2tvZmY6Cj4gLSAgICAg ICBkcm1fYXRvbWljX2xlZ2FjeV9iYWNrb2ZmKHN0YXRlKTsKPiAgICAgICAgIGRybV9hdG9taWNf c3RhdGVfY2xlYXIoc3RhdGUpOwo+ICsgICAgICAgZHJtX2F0b21pY19sZWdhY3lfYmFja29mZihz dGF0ZSk7Cj4KPiAgICAgICAgIC8qCj4gICAgICAgICAgKiBTb21lb25lIG1pZ2h0IGhhdmUgZXhj aGFuZ2VkIHRoZSBmcmFtZWJ1ZmZlciB3aGlsZSB3ZSBkcm9wcGVkIGxvY2tzCj4gQEAgLTE0NjIs OCArMTQ2Miw4IEBAIGZhaWw6Cj4KPiAgICAgICAgIHJldHVybiByZXQ7Cj4gIGJhY2tvZmY6Cj4g LSAgICAgICBkcm1fYXRvbWljX2xlZ2FjeV9iYWNrb2ZmKHN0YXRlKTsKPiAgICAgICAgIGRybV9h dG9taWNfc3RhdGVfY2xlYXIoc3RhdGUpOwo+ICsgICAgICAgZHJtX2F0b21pY19sZWdhY3lfYmFj a29mZihzdGF0ZSk7Cj4KPiAgICAgICAgIC8qCj4gICAgICAgICAgKiBTb21lb25lIG1pZ2h0IGhh dmUgZXhjaGFuZ2VkIHRoZSBmcmFtZWJ1ZmZlciB3aGlsZSB3ZSBkcm9wcGVkIGxvY2tzCj4gQEAg LTE1MjgsOCArMTUyOCw4IEBAIGZhaWw6Cj4KPiAgICAgICAgIHJldHVybiByZXQ7Cj4gIGJhY2tv ZmY6Cj4gLSAgICAgICBkcm1fYXRvbWljX2xlZ2FjeV9iYWNrb2ZmKHN0YXRlKTsKPiAgICAgICAg IGRybV9hdG9taWNfc3RhdGVfY2xlYXIoc3RhdGUpOwo+ICsgICAgICAgZHJtX2F0b21pY19sZWdh Y3lfYmFja29mZihzdGF0ZSk7Cj4KPiAgICAgICAgIGdvdG8gcmV0cnk7Cj4gIH0KPiBAQCAtMTU4 Nyw4ICsxNTg3LDggQEAgZmFpbDoKPgo+ICAgICAgICAgcmV0dXJuIHJldDsKPiAgYmFja29mZjoK PiAtICAgICAgIGRybV9hdG9taWNfbGVnYWN5X2JhY2tvZmYoc3RhdGUpOwo+ICAgICAgICAgZHJt X2F0b21pY19zdGF0ZV9jbGVhcihzdGF0ZSk7Cj4gKyAgICAgICBkcm1fYXRvbWljX2xlZ2FjeV9i YWNrb2ZmKHN0YXRlKTsKPgo+ICAgICAgICAgZ290byByZXRyeTsKPiAgfQo+IEBAIC0xNjQ2LDgg KzE2NDYsOCBAQCBmYWlsOgo+Cj4gICAgICAgICByZXR1cm4gcmV0Owo+ICBiYWNrb2ZmOgo+IC0g ICAgICAgZHJtX2F0b21pY19sZWdhY3lfYmFja29mZihzdGF0ZSk7Cj4gICAgICAgICBkcm1fYXRv bWljX3N0YXRlX2NsZWFyKHN0YXRlKTsKPiArICAgICAgIGRybV9hdG9taWNfbGVnYWN5X2JhY2tv ZmYoc3RhdGUpOwo+Cj4gICAgICAgICBnb3RvIHJldHJ5Owo+ICB9Cj4gQEAgLTE3MjUsOCArMTcy NSw4IEBAIGZhaWw6Cj4KPiAgICAgICAgIHJldHVybiByZXQ7Cj4gIGJhY2tvZmY6Cj4gLSAgICAg ICBkcm1fYXRvbWljX2xlZ2FjeV9iYWNrb2ZmKHN0YXRlKTsKPiAgICAgICAgIGRybV9hdG9taWNf c3RhdGVfY2xlYXIoc3RhdGUpOwo+ICsgICAgICAgZHJtX2F0b21pY19sZWdhY3lfYmFja29mZihz dGF0ZSk7Cj4KPiAgICAgICAgIC8qCj4gICAgICAgICAgKiBTb21lb25lIG1pZ2h0IGhhdmUgZXhj aGFuZ2VkIHRoZSBmcmFtZWJ1ZmZlciB3aGlsZSB3ZSBkcm9wcGVkIGxvY2tzCj4gLS0KPiAyLjEu MQo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJ bnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK