From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1D47C433E2 for ; Sat, 12 Sep 2020 18:25:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4573C21531 for ; Sat, 12 Sep 2020 18:25:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YvrlhxZR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4573C21531 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 569EE6E301; Sat, 12 Sep 2020 18:24:59 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id A89DD6E2ED; Sat, 12 Sep 2020 18:24:57 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id s12so14497656wrw.11; Sat, 12 Sep 2020 11:24:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tGJ7MqBZLv0eAFVjI5IdEGfiU4O8rQsPVnooROi6laU=; b=YvrlhxZRmzgDhT6xrPgh7jVcpAHPv91I8p1bnd/Ybyjw2xx04UgOiVehjFNGf/zdTZ gQ0jfYsMN1aXiFy8ncXY7biHgcFJxBNKTva0qEOsfvL8Wferx6Qwexf2brdyU7OrgxxH SiZLYXvlXgmh+qUr+YWjq534h/vUUMwKEHCEUHPq/9hTK1JhyxmgYaHANgJTCLbXPfpL gSmlSA70QICucG4alPltitONxnLqXhXtk9Ajv/rr3h7FQ9XCLRPnOUi9WnHE+hUqJ9ga E9TSVq4k18EzfRW0xnSjlX2NRWcAABlN7ZoNDh2QRMCS4aHx8sUBJ6NGm5VTSqb7bMrP ldvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tGJ7MqBZLv0eAFVjI5IdEGfiU4O8rQsPVnooROi6laU=; b=JChloIBjW2zOpVNl0Ri7PzT8rFVfT1JTAT7HJLjdLQDiahDUbARWDSpIk9yT8ylP2b wVjapPGLXlV5DN94txHLz3rUAQQry6g7mwj2XZ0xzfTfF+kPX4RcKrEElcTx4uqxUPUL m7RVpJpoKtr+DLEmydMeRQcosP+nuJJqgouhX3tr1x7Pzvg22lhx16BlwGDy6RPCFQaK etT/sr933/rxrzgDJs7UL99he9TQvDsSrO1o6Fms59UZ5qJagy7VVYbmTCP2Nqx7eUwD cYvPsi27YdAndEPAEj1zlkwHtsFZI8/5EPdmTVo23DfRt4iWyerU8VitlV/trKAIW0DY Nv9A== X-Gm-Message-State: AOAM531qK9v7esrer5W4MnI94//weBiVB9YMgzNOAQTD7lqydAtVtRoJ y7mWGTyeAvrO+7xWMafxpOM5bVjt3hC0vIoQZLE= X-Google-Smtp-Source: ABdhPJxnDbMbdSz2hPUfBzuQYfyUTosQbk+FaVCIPdDlwDrvWHXaJSinnkB//3oqC3oIBn+8QNJvFjyBHY+WTCVuogU= X-Received: by 2002:a5d:4a0c:: with SMTP id m12mr7873322wrq.83.1599935096172; Sat, 12 Sep 2020 11:24:56 -0700 (PDT) MIME-Version: 1.0 References: <20200827211658.27479-1-tanmay@codeaurora.org> In-Reply-To: <20200827211658.27479-1-tanmay@codeaurora.org> From: Rob Clark Date: Sat, 12 Sep 2020 11:25:52 -0700 Message-ID: Subject: Re: [PATCH v12 0/5] Add support for DisplayPort driver on SnapDragon To: Tanmay Shah X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-arm-msm , Linux Kernel Mailing List , dri-devel , Stephen Boyd , khsieh@codeaurora.org, Sean Paul , Abhinav Kumar , aravindh@codeaurora.org, freedreno Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fyi, I've pushed this series and the dp-compliance bits to msm-next-dp[1] I didn't include the dp audio series yet, which seems to need some minor rebasing. (And a small request, when resending, cc freedreno@lists.freedesktop.org, so it shows up in the patchwork instance[2] I use) You might want to double check that I got the correct versions of the series, etc. And that nothing else (other than audio) is missing. BR, -R [1] https://gitlab.freedesktop.org/drm/msm/-/commits/msm-next-dp [2] https://patchwork.freedesktop.org/project/freedreno On Thu, Aug 27, 2020 at 2:17 PM Tanmay Shah wrote: > > These patches add Display-Port driver on SnapDragon/msm hardware. > This series also contains device-tree bindings for msm DP driver. > It also contains Makefile and Kconfig changes to compile msm DP driver. > > The block diagram of DP driver is shown below: > > > +-------------+ > |DRM FRAMEWORK| > +------+------+ > | > +----v----+ > | DP DRM | > +----+----+ > | > +----v----+ > +------------+| DP +----------++------+ > + +---+| DISPLAY |+---+ | | > | + +-+-----+-+ | | | > | | | | | | | > | | | | | | | > | | | | | | | > v v v v v v v > +------+ +------+ +---+ +----+ +----+ +---+ +-----+ > | DP | | DP | |DP | | DP | | DP | |DP | | DP | > |PARSER| | HPD | |AUX| |LINK| |CTRL| |PHY| |POWER| > +--+---+ +---+--+ +---+ +----+ +--+-+ +-+-+ +-----+ > | | | > +--v---+ +v-----v+ > |DEVICE| | DP | > | TREE | |CATALOG| > +------+ +---+---+ > | > +---v----+ > |CTRL/PHY| > | HW | > +--------+ > > Changes in v12: > > -- Add support of pm ops in display port driver > -- Clear bpp depth bits before writing to MISC register > -- Fix edid read > > Previous change log: > https://lkml.kernel.org/lkml/20200818051137.21478-1-tanmay@codeaurora.org/ > > Chandan Uddaraju (4): > dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon > drm: add constant N value in helper file > drm/msm/dp: add displayPort driver support > drm/msm/dp: add support for DP PLL driver > > Jeykumar Sankaran (1): > drm/msm/dpu: add display port support in DPU > > Tanmay Shah (1): > drm/msm/dp: Add Display Port HPD feature > > drivers/gpu/drm/i915/display/intel_display.c | 2 +- > drivers/gpu/drm/msm/Kconfig | 9 + > drivers/gpu/drm/msm/Makefile | 14 + > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 27 +- > .../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 8 + > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 83 +- > drivers/gpu/drm/msm/dp/dp_aux.c | 535 ++++++ > drivers/gpu/drm/msm/dp/dp_aux.h | 30 + > drivers/gpu/drm/msm/dp/dp_catalog.c | 1045 ++++++++++ > drivers/gpu/drm/msm/dp/dp_catalog.h | 105 + > drivers/gpu/drm/msm/dp/dp_ctrl.c | 1693 +++++++++++++++++ > drivers/gpu/drm/msm/dp/dp_ctrl.h | 35 + > drivers/gpu/drm/msm/dp/dp_display.c | 1046 ++++++++++ > drivers/gpu/drm/msm/dp/dp_display.h | 31 + > drivers/gpu/drm/msm/dp/dp_drm.c | 168 ++ > drivers/gpu/drm/msm/dp/dp_drm.h | 18 + > drivers/gpu/drm/msm/dp/dp_hpd.c | 69 + > drivers/gpu/drm/msm/dp/dp_hpd.h | 79 + > drivers/gpu/drm/msm/dp/dp_link.c | 1214 ++++++++++++ > drivers/gpu/drm/msm/dp/dp_link.h | 132 ++ > drivers/gpu/drm/msm/dp/dp_panel.c | 486 +++++ > drivers/gpu/drm/msm/dp/dp_panel.h | 95 + > drivers/gpu/drm/msm/dp/dp_parser.c | 267 +++ > drivers/gpu/drm/msm/dp/dp_parser.h | 138 ++ > drivers/gpu/drm/msm/dp/dp_pll.c | 99 + > drivers/gpu/drm/msm/dp/dp_pll.h | 61 + > drivers/gpu/drm/msm/dp/dp_pll_10nm.c | 930 +++++++++ > drivers/gpu/drm/msm/dp/dp_pll_private.h | 89 + > drivers/gpu/drm/msm/dp/dp_power.c | 373 ++++ > drivers/gpu/drm/msm/dp/dp_power.h | 103 + > drivers/gpu/drm/msm/dp/dp_reg.h | 518 +++++ > drivers/gpu/drm/msm/msm_drv.c | 2 + > drivers/gpu/drm/msm/msm_drv.h | 59 +- > include/drm/drm_dp_helper.h | 1 + > 34 files changed, 9545 insertions(+), 19 deletions(-) > create mode 100644 drivers/gpu/drm/msm/dp/dp_aux.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_aux.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_catalog.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_catalog.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_ctrl.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_ctrl.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_display.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_display.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_drm.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_drm.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_hpd.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_hpd.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_link.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_link.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_panel.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_panel.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_parser.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_parser.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_pll.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_pll.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_pll_10nm.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_pll_private.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_power.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_power.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_reg.h > > > base-commit: d012a7190fc1fd72ed48911e77ca97ba4521bccd > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel