From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Clark Subject: Re: [PATCH 6/6] drm/atomic_helper: Make it clear that commit_planes gets the old state Date: Wed, 19 Nov 2014 15:29:30 -0500 Message-ID: References: <1416418691-24747-1-git-send-email-daniel.vetter@ffwll.ch> <1416418691-24747-6-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1416418691-24747-6-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , DRI Development List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBOb3YgMTksIDIwMTQgYXQgMTI6MzggUE0sIERhbmllbCBWZXR0ZXIgPGRhbmllbC52 ZXR0ZXJAZmZ3bGwuY2g+IHdyb3RlOgo+IE92ZXJzaWdodCBmcm9tIG15IGtlcm5lbGRvYyBjbGVh bnVwIHdoZW4gZG9pbmcgdGhlIG9yaWdpbmFsIGF0b21pYwo+IGhlbHBlciBzZXJpZXMgLSBJJ3Zl IG9ubHkgYXBwbGllZCB0aGlzIGNsYXJpZmljYXRpb24gdG8gdGhlIG1vZGVzZXQKPiByZWxhdGVk IGhlbHBlcnMsIGFuZCBub3QgdGhlIHBsYW5lIHVwZGF0ZSBjb2RlLiBSZW1lZHkgdGhpcyBhc2Fw Lgo+Cj4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBpbnRlbC5j b20+CgpSZXZpZXdlZC1ieTogUm9iIENsYXJrIDxyb2JkY2xhcmtAZ21haWwuY29tPgoKPiAtLS0K PiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMgfCAxMiArKysrKystLS0tLS0K PiAgMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKPgo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyBiL2RyaXZlcnMv Z3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gaW5kZXggOTkwOTVlZjE0N2VmLi42OTAzNjAw MzhkYzEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+IEBAIC05NzYsMTgg Kzk3NiwxOCBAQCBFWFBPUlRfU1lNQk9MKGRybV9hdG9taWNfaGVscGVyX3ByZXBhcmVfcGxhbmVz KTsKPiAgLyoqCj4gICAqIGRybV9hdG9taWNfaGVscGVyX2NvbW1pdF9wbGFuZXMgLSBjb21taXQg cGxhbmUgc3RhdGUKPiAgICogQGRldjogRFJNIGRldmljZQo+IC0gKiBAc3RhdGU6IGF0b21pYyBz dGF0ZQo+ICsgKiBAb2xkX3N0YXRlOiBhdG9taWMgc3RhdGUgb2JqZWN0IHdpdGggb2xkIHN0YXRl IHN0cnVjdHVyZXMKPiAgICoKPiAgICogVGhpcyBmdW5jdGlvbiBjb21taXRzIHRoZSBuZXcgcGxh bmUgc3RhdGUgdXNpbmcgdGhlIHBsYW5lIGFuZCBhdG9taWMgaGVscGVyCj4gICAqIGZ1bmN0aW9u cyBmb3IgcGxhbmVzIGFuZCBjcnRjcy4gSXQgYXNzdW1lcyB0aGF0IHRoZSBhdG9taWMgc3RhdGUg aGFzIGFscmVhZHkKPiAgICogYmVlbiBwdXNoZWQgaW50byB0aGUgcmVsZXZhbnQgb2JqZWN0IHN0 YXRlIHBvaW50ZXJzLCBzaW5jZSB0aGlzIHN0ZXAgY2FuIG5vCj4gICAqIGxvbmdlciBmYWlsLgo+ ICAgKgo+IC0gKiBJdCBzdGlsbCByZXF1aXJlcyB0aGUgZ2xvYmFsIHN0YXRlIG9iamVjdCBAc3Rh dGUgdG8ga25vdyB3aGljaCBwbGFuZXMgYW5kCj4gKyAqIEl0IHN0aWxsIHJlcXVpcmVzIHRoZSBn bG9iYWwgc3RhdGUgb2JqZWN0IEBvbGRfc3RhdGUgdG8ga25vdyB3aGljaCBwbGFuZXMgYW5kCj4g ICAqIGNydGNzIG5lZWQgdG8gYmUgdXBkYXRlZCB0aG91Z2guCj4gICAqLwo+ICB2b2lkIGRybV9h dG9taWNfaGVscGVyX2NvbW1pdF9wbGFuZXMoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAtICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGRybV9hdG9taWNfc3RhdGUg KnN0YXRlKQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgZHJt X2F0b21pY19zdGF0ZSAqb2xkX3N0YXRlKQo+ICB7Cj4gICAgICAgICBpbnQgbnBsYW5lcyA9IGRl di0+bW9kZV9jb25maWcubnVtX3RvdGFsX3BsYW5lOwo+ICAgICAgICAgaW50IG5jcnRjcyA9IGRl di0+bW9kZV9jb25maWcubnVtX2NydGM7Cj4gQEAgLTk5NSw3ICs5OTUsNyBAQCB2b2lkIGRybV9h dG9taWNfaGVscGVyX2NvbW1pdF9wbGFuZXMoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPgo+ICAg ICAgICAgZm9yIChpID0gMDsgaSA8IG5jcnRjczsgaSsrKSB7Cj4gICAgICAgICAgICAgICAgIHN0 cnVjdCBkcm1fY3J0Y19oZWxwZXJfZnVuY3MgKmZ1bmNzOwo+IC0gICAgICAgICAgICAgICBzdHJ1 Y3QgZHJtX2NydGMgKmNydGMgPSBzdGF0ZS0+Y3J0Y3NbaV07Cj4gKyAgICAgICAgICAgICAgIHN0 cnVjdCBkcm1fY3J0YyAqY3J0YyA9IG9sZF9zdGF0ZS0+Y3J0Y3NbaV07Cj4KPiAgICAgICAgICAg ICAgICAgaWYgKCFjcnRjKQo+ICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwo+IEBA IC0xMDEwLDcgKzEwMTAsNyBAQCB2b2lkIGRybV9hdG9taWNfaGVscGVyX2NvbW1pdF9wbGFuZXMo c3RydWN0IGRybV9kZXZpY2UgKmRldiwKPgo+ICAgICAgICAgZm9yIChpID0gMDsgaSA8IG5wbGFu ZXM7IGkrKykgewo+ICAgICAgICAgICAgICAgICBzdHJ1Y3QgZHJtX3BsYW5lX2hlbHBlcl9mdW5j cyAqZnVuY3M7Cj4gLSAgICAgICAgICAgICAgIHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lID0gc3Rh dGUtPnBsYW5lc1tpXTsKPiArICAgICAgICAgICAgICAgc3RydWN0IGRybV9wbGFuZSAqcGxhbmUg PSBvbGRfc3RhdGUtPnBsYW5lc1tpXTsKPgo+ICAgICAgICAgICAgICAgICBpZiAoIXBsYW5lKQo+ ICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwo+IEBAIC0xMDI1LDcgKzEwMjUsNyBA QCB2b2lkIGRybV9hdG9taWNfaGVscGVyX2NvbW1pdF9wbGFuZXMoc3RydWN0IGRybV9kZXZpY2Ug KmRldiwKPgo+ICAgICAgICAgZm9yIChpID0gMDsgaSA8IG5jcnRjczsgaSsrKSB7Cj4gICAgICAg ICAgICAgICAgIHN0cnVjdCBkcm1fY3J0Y19oZWxwZXJfZnVuY3MgKmZ1bmNzOwo+IC0gICAgICAg ICAgICAgICBzdHJ1Y3QgZHJtX2NydGMgKmNydGMgPSBzdGF0ZS0+Y3J0Y3NbaV07Cj4gKyAgICAg ICAgICAgICAgIHN0cnVjdCBkcm1fY3J0YyAqY3J0YyA9IG9sZF9zdGF0ZS0+Y3J0Y3NbaV07Cj4K PiAgICAgICAgICAgICAgICAgaWYgKCFjcnRjKQo+ICAgICAgICAgICAgICAgICAgICAgICAgIGNv bnRpbnVlOwo+IC0tCj4gMi4xLjEKPgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg==