From: Oded Gabbay <ogabbay@kernel.org>
To: Jeffrey Hugo <quic_jhugo@quicinc.com>
Cc: dri-devel@lists.freedesktop.org,
Maciej Kwapulinski <maciej.kwapulinski@linux.intel.com>,
Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>,
Kevin Hilman <khilman@baylibre.com>,
Christoph Hellwig <hch@infradead.org>,
Jagan Teki <jagan@amarulasolutions.com>,
Jason Gunthorpe <jgg@nvidia.com>,
John Hubbard <jhubbard@nvidia.com>, Arnd Bergmann <arnd@arndb.de>,
Jiho Chu <jiho.chu@samsung.com>,
Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>,
Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Alex Deucher <alexander.deucher@amd.com>
Subject: Re: [RFC PATCH v3 1/3] drivers/accel: define kconfig and register a new major
Date: Mon, 7 Nov 2022 23:05:34 +0200 [thread overview]
Message-ID: <CAFCwf10iNhi7=O_c==0dzyiMVSL05R8bJQ1HPJJo04bwz86e=w@mail.gmail.com> (raw)
In-Reply-To: <5fe8e8c0-d28b-3666-e437-10fa0c591ed8@quicinc.com>
On Mon, Nov 7, 2022 at 6:12 PM Jeffrey Hugo <quic_jhugo@quicinc.com> wrote:
>
> On 11/6/2022 2:02 PM, Oded Gabbay wrote:
> > +int __init accel_core_init(void)
> > +{
> > + int ret;
> > +
> > + ret = accel_sysfs_init();
> > + if (ret < 0) {
> > + DRM_ERROR("Cannot create ACCEL class: %d\n", ret);
> > + goto error;
> > + }
> > +
> > + accel_debugfs_root = debugfs_create_dir("accel", NULL);
> > +
> > + ret = register_chrdev(ACCEL_MAJOR, "accel", &accel_stub_fops);
> > + if (ret < 0)
> > + goto error;
>
> We are not jumping over anything here. Seems like this whole if block
> could just be removed.
correct, will be fixed.
>
> > +
> > +error:
> > + /* Any cleanup will be done in drm_core_exit() that will call
> > + * to accel_core_exit()
> > + */
>
> This doesn't look like the standard multi-line comment style. Are we
> going to say that the accel subsystem follows net and differs from the
> kernel standard?
I'll change it to the kernel standard.
Thx,
Oded
>
> > + return ret;
> > +}
next prev parent reply other threads:[~2022-11-07 21:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-06 21:02 [RFC PATCH v3 0/3] new subsystem for compute accelerator devices Oded Gabbay
2022-11-06 21:02 ` [RFC PATCH v3 1/3] drivers/accel: define kconfig and register a new major Oded Gabbay
2022-11-07 16:12 ` Jeffrey Hugo
2022-11-07 21:05 ` Oded Gabbay [this message]
2022-11-08 12:46 ` Stanislaw Gruszka
2022-11-08 12:48 ` Oded Gabbay
2022-11-06 21:02 ` [RFC PATCH v3 2/3] accel: add dedicated minor for accelerator devices Oded Gabbay
2022-11-07 16:20 ` Jeffrey Hugo
2022-11-07 21:06 ` Oded Gabbay
2022-11-08 13:13 ` Tvrtko Ursulin
2022-11-08 16:14 ` Oded Gabbay
2022-11-06 21:02 ` [RFC PATCH v3 3/3] drm: initialize accel framework Oded Gabbay
2022-11-07 16:24 ` Jeffrey Hugo
2022-11-07 21:04 ` Oded Gabbay
2022-11-07 16:07 ` [RFC PATCH v3 0/3] new subsystem for compute accelerator devices Jeffrey Hugo
2022-11-07 16:21 ` Matthew Wilcox
2022-11-07 16:20 ` Jason Gunthorpe
2022-11-11 22:03 ` Christopher Friedt
2022-11-13 15:05 ` Oded Gabbay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFCwf10iNhi7=O_c==0dzyiMVSL05R8bJQ1HPJJo04bwz86e=w@mail.gmail.com' \
--to=ogabbay@kernel.org \
--cc=alexander.deucher@amd.com \
--cc=arnd@arndb.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=jacek.lawrynowicz@linux.intel.com \
--cc=jagan@amarulasolutions.com \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=jiho.chu@samsung.com \
--cc=khilman@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.kwapulinski@linux.intel.com \
--cc=quic_jhugo@quicinc.com \
--cc=rdunlap@infradead.org \
--cc=stanislaw.gruszka@linux.intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=tzimmermann@suse.de \
--cc=yuji2.ishikawa@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).