From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97E5AC433FE for ; Thu, 3 Nov 2022 13:29:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 602A310E28A; Thu, 3 Nov 2022 13:29:34 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 88EB110E29B for ; Thu, 3 Nov 2022 13:29:30 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E547661EB0 for ; Thu, 3 Nov 2022 13:29:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F33B0C4314E for ; Thu, 3 Nov 2022 13:29:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667482168; bh=nYB3RB+AjUVoOwO1yDeiaVxLJ0D31WZD8FZbQ8TSmNg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=QOPPXS5e0ASzWMACM+JrTIUGNfwGgYeUpV2IfcynlwdO1Alh3NqgCfsKgpRhz1MxT JN7Y9INd2skjnLQ0U9lrhtuZW5hpKWHwfbsBja3qs4tQTfwcRaP8p4W3uvE4wsUzA2 o/+fVXncBf3Pm14dlBjgXWDBqHJXEYGEc0eQJKpatc9kFrdYBpQm/fzEm2Fk+4LChf j1th2ZNWsyh5NwENjUXSIsRNt4fk2Q6t/h7nL5bge4s7O6kFrCd+BiR7+ZrvY+mCRB NEKF8v5MjAg6oNfdWORbh1YSjCMw5H0BGcfLzEui0RZuZwpd55BekhGivAuFApSJWM XOgvOG3kiFEWA== Received: by mail-yb1-f172.google.com with SMTP id 185so2212584ybc.3 for ; Thu, 03 Nov 2022 06:29:27 -0700 (PDT) X-Gm-Message-State: ACrzQf3ALE7eXcxn5SZxtyMV/iJUXiN2j5hmhun/FvboZH0NBFBbV9pQ 1dtlNntYSJBMfQFrTyuCbr0vTpbscpPW9dBnygE= X-Google-Smtp-Source: AMsMyM7CWMX1wMsAxUqb0LEcvpP3bRnpLq13T6TY1U2hkCREcb5k3XiZQu0BvoxlFgSmAdWpotlBz2+3ZEC4sjb0Ik0= X-Received: by 2002:a25:1e89:0:b0:6bf:9e55:5cb4 with SMTP id e131-20020a251e89000000b006bf9e555cb4mr29629923ybe.642.1667482166923; Thu, 03 Nov 2022 06:29:26 -0700 (PDT) MIME-Version: 1.0 References: <20221102203405.1797491-1-ogabbay@kernel.org> <20221102203405.1797491-2-ogabbay@kernel.org> In-Reply-To: From: Oded Gabbay Date: Thu, 3 Nov 2022 15:29:00 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH v2 1/3] drivers/accel: define kconfig and register a new major To: Randy Dunlap Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Maciej Kwapulinski , Kevin Hilman , Christoph Hellwig , Jagan Teki , Jason Gunthorpe , John Hubbard , Jeffrey Hugo , Arnd Bergmann , Jiho Chu , Jacek Lawrynowicz , Yuji Ishikawa , Tvrtko Ursulin , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Thomas Zimmermann , Alex Deucher Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Nov 3, 2022 at 12:58 AM Randy Dunlap wrote: > > > > On 11/2/22 13:34, Oded Gabbay wrote: > > diff --git a/drivers/accel/Kconfig b/drivers/accel/Kconfig > > new file mode 100644 > > index 000000000000..282ea24f90c5 > > --- /dev/null > > +++ b/drivers/accel/Kconfig > > @@ -0,0 +1,24 @@ > > +# SPDX-License-Identifier: GPL-2.0-only > > +# > > +# Compute Acceleration device configuration > > +# > > +# This framework provides support for compute acceleration devices, such > > +# as, but not limited to, Machine-Learning and Deep-Learning acceleration > > +# devices > > +# > > +menuconfig ACCEL > > + tristate "Compute Acceleration Framework" > > + depends on DRM > > + help > > + Framework for device drivers of compute acceleration devices, such > > + as, but not limited to, Machine-Learning and Deep-Learning > > + acceleration devices. > > + If you say Y here, you need to select the module that's right for > > + your acceleration device from the list below. > > + This framework is integrated with the DRM subsystem as compute > > + accelerators and GPUs share a lot in common and can use almost the > > + same infrastructure code. > > + Having said that, acceleration devices will have a different > > + major number than GPUs, and will be exposed to user-space using > > + different device files, called accel/accel* (in /dev, sysfs > > + and debugfs) > > Please add a period at the end of the help text. > > + and debugfs). sure, thx. Oded > > -- > ~Randy