From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1ED2C4332F for ; Mon, 7 Nov 2022 21:05:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 432A910E4AF; Mon, 7 Nov 2022 21:05:16 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0CB9D10E4A9 for ; Mon, 7 Nov 2022 21:05:13 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 78C4CB816A0 for ; Mon, 7 Nov 2022 21:05:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3578BC4347C for ; Mon, 7 Nov 2022 21:05:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667855110; bh=Zu50tGqg124bPyOMVvcoQdIculJ+KYQtsiSpZtdQVq4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=AabtWJNmq1Z8Xd62qXornOCd4ZK3WhKppXVm4YynDe4++xb8YguttfBdNQXXw9utL ErdH/vNsCDN8KIsmTq9VxUiAtXIeQ4Ym2zOTYTesPPe8oPEIjn8k+qudKhLVrJsiCQ rSnVdbr93iQONLOAfi4cgOnEf/svFjIQ6d+uVIiVa2gHuhdFwrTMU5NlhLcyZuFsOJ M+/SaZrHlzd31Ao7huJTDQendPxB+OQUJLL6GzEmsFpt4IoDClYFHnxLljwjlPIf2M 0bVUNEqbvngAnGlGkK4+fQ3I16nfHkCVST+31DDbyv++DM73sb/Cb8PceNxog9/lzY kTz3wiMBcWqfQ== Received: by mail-yb1-f178.google.com with SMTP id g127so15122907ybg.8 for ; Mon, 07 Nov 2022 13:05:10 -0800 (PST) X-Gm-Message-State: ANoB5pkGGTgd36fwvLZ02mqXwt/KIdRdVBQNT+/R55VdySvjw0H7kDkr xeg99KOILfaCS3aggF2BH53HpWJspmi7BZPoekg= X-Google-Smtp-Source: AA0mqf4KjNwhvJXdZttzDTXzxLD0NEeHGqaOOG0YDar2hzM7Q2wpgsR23hYSEEYa6fKsS6NkPJtYHOUyqYwmtjLhNO0= X-Received: by 2002:a25:2389:0:b0:6d8:7f81:edaf with SMTP id j131-20020a252389000000b006d87f81edafmr3758306ybj.443.1667855109196; Mon, 07 Nov 2022 13:05:09 -0800 (PST) MIME-Version: 1.0 References: <20221106210225.2065371-1-ogabbay@kernel.org> <20221106210225.2065371-4-ogabbay@kernel.org> <2537e41d-f863-4819-57d2-09b9554f801b@quicinc.com> In-Reply-To: <2537e41d-f863-4819-57d2-09b9554f801b@quicinc.com> From: Oded Gabbay Date: Mon, 7 Nov 2022 23:04:42 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH v3 3/3] drm: initialize accel framework To: Jeffrey Hugo Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Maciej Kwapulinski , Stanislaw Gruszka , Kevin Hilman , Christoph Hellwig , Jagan Teki , Jason Gunthorpe , John Hubbard , Arnd Bergmann , Jiho Chu , Jacek Lawrynowicz , Yuji Ishikawa , Tvrtko Ursulin , Greg Kroah-Hartman , Randy Dunlap , linux-kernel@vger.kernel.org, Thomas Zimmermann , Alex Deucher Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Nov 7, 2022 at 6:25 PM Jeffrey Hugo wrote: > > On 11/6/2022 2:02 PM, Oded Gabbay wrote: > > > @@ -603,6 +626,14 @@ static int drm_dev_init(struct drm_device *dev, > > /* no per-device feature limits by default */ > > dev->driver_features = ~0u; > > > > + if (drm_core_check_feature(dev, DRIVER_COMPUTE_ACCEL) && > > + (drm_core_check_feature(dev, DRIVER_RENDER) || > > + drm_core_check_feature(dev, DRIVER_MODESET))) { > > Shouldn't the indentation for the 2nd and 3rd line be such that the > start of the lines is aligned with the "(" on the first line? afaik there is no such rule. If there was, checkpatch should have reported that. Oded