From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0AC4C433E6 for ; Sat, 23 Jan 2021 09:38:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B2E5233FA for ; Sat, 23 Jan 2021 09:38:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B2E5233FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F38B26EADF; Sat, 23 Jan 2021 09:38:54 +0000 (UTC) Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by gabe.freedesktop.org (Postfix) with ESMTPS id BD2A089B51 for ; Fri, 22 Jan 2021 16:23:01 +0000 (UTC) Received: by mail-lj1-x233.google.com with SMTP id i17so7191403ljn.1 for ; Fri, 22 Jan 2021 08:23:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=88Vl5wsF3LhouE+0mndGQ/+yVD0WCSAjrMW79+8hbAM=; b=Us7urmLGEwxHeZEMTzuxL/3zWhj0wu4J28lp40bhggvyz+92iK48WF2EJ1K0XlZJ3m LsWq6NMNpF74uSIkUo/cKyPs9WoFktH55Ls9L905qoa3c4CtftN+SRU/xwHo1Cc5zxod Kr1iMG9QeqMad/QqJrqMLeIXA1sMiX9k29dAi3TxV/PR3Kc/RzBuqU551PRoSW2Cy7Xl Uu2cLZmiDq5aIUnHsklJyKsBoMUp0cLINsLNDM8z/+52w+YT/EoEAZYpSNvPSw5gRY7u r6XrTThyzJwDojLrbkCoTZmGeaOXkxUVNdlOS7CuF77qJWfmgFeYhqGDl+ZjfGivq/Sj BAFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=88Vl5wsF3LhouE+0mndGQ/+yVD0WCSAjrMW79+8hbAM=; b=boyLa5flUNwQESpV+grS7plJkysc6MTy7rzAkxuPtNfExdn62PFOQrn3+u/ztuYeDU HYnIJgCiK3+xaSwYIyPmvOt/srY0eLafLqrg0SMSlE+QI+SYwP5LBGy8FLfe2AqezpWa TQGOUJa/PepMkVgWco+S4aUPMuX3YQC2KyhLtzCJr+jMru9OC4oBXn9NZRAqFWQB1+yJ VcLgiTHRMHKS1Iwnm9Lo9nDUhFG7vShfHQhUuabCINrsL3AEncleDaBSUSY54+3p57Az sWc+iDF3YflkxZtfSiaAPVJpSpwg/SW3xSJppmbgfJJuFZ+kphOqOIYktLRbw6FtB+bO HooA== X-Gm-Message-State: AOAM532L3U/EV5Xgx+JuKaNXMDECbJSMVSHU6P2RuP4SQWWYtw3v0Q5S vIxW62+L97JHwUdQ/2Gt9FsYlQQ89gLpi5Dlg04= X-Google-Smtp-Source: ABdhPJyWZRdgKUpo3TJpGFTQooQcCurQgqyPxBZSmMJibdHu4cMEuNs8RlC4FTKzhIQ1owSXMFJ6ODKxNdNQEtbop48= X-Received: by 2002:a2e:90c4:: with SMTP id o4mr93601ljg.268.1611332580266; Fri, 22 Jan 2021 08:23:00 -0800 (PST) MIME-Version: 1.0 References: <1609854367-2720-1-git-send-email-kevin3.tang@gmail.com> In-Reply-To: <1609854367-2720-1-git-send-email-kevin3.tang@gmail.com> From: Kevin Tang Date: Sat, 23 Jan 2021 00:22:29 +0800 Message-ID: Subject: Re: [PATCH v3 0/6] Add Unisoc's drm kms module To: Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Kevin Tang X-Mailman-Approved-At: Sat, 23 Jan 2021 09:38:10 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Orson Zhai , devicetree@vger.kernel.org, "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel , Chunyan Zhang Content-Type: multipart/mixed; boundary="===============0032325641==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --===============0032325641== Content-Type: multipart/alternative; boundary="0000000000000fd67e05b97f9abc" --0000000000000fd67e05b97f9abc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Daniel, Do you have some more comments for our patch? Kevin Tang =E4=BA=8E2021=E5=B9=B41=E6=9C=885=E6=97= =A5=E5=91=A8=E4=BA=8C =E4=B8=8B=E5=8D=889:46=E5=86=99=E9=81=93=EF=BC=9A > ChangeList: > RFC v1: > 1. only upstream modeset and atomic at first commit. > 2. remove some unused code; > 3. use alpha and blend_mode properties; > 3. add yaml support; > 4. remove auto-adaptive panel driver; > 5. bugfix > > RFC v2: > 1. add sprd crtc and plane module for KMS, preparing for multi crtc&encod= er > 2. remove gem drivers, use generic CMA handlers > 3. remove redundant "module_init", all the sub modules loading by KMS > > RFC v3: > 1. multi crtc&encoder design have problem, so rollback to v1 > > RFC v4: > 1. update to gcc-linaro-7.5.0 > 2. update to Linux 5.6-rc3 > 3. remove pm_runtime support > 4. add COMPILE_TEST, remove unused kconfig > 5. "drm_dev_put" on drm_unbind > 6. fix some naming convention issue > 7. remove semaphore lock for crtc flip > 8. remove static variables > > RFC v5: > 1. optimize encoder and connector code implementation > 2. use "platform_get_irq" and "platform_get_resource" > 3. drop useless function return type, drop unless debug log > 4. custom properties should be separate, so drop it > 5. use DRM_XXX replase pr_xxx > 6. drop dsi&dphy hal callback ops > 7. drop unless callback ops checking > 8. add comments for sprd dpu structure > > RFC v6: > 1. Access registers via readl/writel > 2. Checking for unsupported KMS properties (format, rotation, blend_mode, > etc) on plane_check ops > 3. Remove always true checks for dpu core ops > > RFC v7: > 1. Fix DTC unit name warnings > 2. Fix the problem of maintainers > 3. Call drmm_mode_config_init to mode config init > 4. Embed drm_device in sprd_drm and use devm_drm_dev_alloc > 5. Replace DRM_XXX with drm_xxx on KMS module, but not suitable for other > subsystems > 6. Remove plane_update stuff, dpu handles all the HW update in > crtc->atomic_flush > 7. Dsi&Dphy Code structure adjustment, all move to "sprd/" > > v0: > 1. Remove dpu_core_ops stuff layer for sprd drtc driver, but dpu_layer > need to keeping. > Because all the HW update in crtc->atomic_flush, we need temporary > storage all layers for > the dpu pageflip of atomic_flush. > 2. Add ports subnode with port@X. > > v1: > 1. Remove dphy and dsi graph binding, merge the dphy driver into the dsi. > 2. Add commit messages for Unisoc's virtual nodes. > > v2: > 1. Use drm_xxx to replace all DRM_XXX. > 2. Use kzalloc to replace devm_kzalloc for sprd_dsi/sprd_dpu structure > init. > 3. Remove dpu_core_ops midlayer. > > v3: > 1. Remove dpu_layer midlayer and commit layers by aotmic_update > > Kevin Tang (6): > dt-bindings: display: add Unisoc's drm master bindings > drm/sprd: add Unisoc's drm kms master > dt-bindings: display: add Unisoc's dpu bindings > drm/sprd: add Unisoc's drm display controller driver > dt-bindings: display: add Unisoc's mipi dsi controller bindings > drm/sprd: add Unisoc's drm mipi dsi&dphy driver > > .../display/sprd/sprd,display-subsystem.yaml | 64 + > .../bindings/display/sprd/sprd,sharkl3-dpu.yaml | 77 + > .../display/sprd/sprd,sharkl3-dsi-host.yaml | 102 ++ > drivers/gpu/drm/Kconfig | 2 + > drivers/gpu/drm/Makefile | 1 + > drivers/gpu/drm/sprd/Kconfig | 13 + > drivers/gpu/drm/sprd/Makefile | 8 + > drivers/gpu/drm/sprd/dw_dsi_ctrl.c | 794 +++++++++++ > drivers/gpu/drm/sprd/dw_dsi_ctrl.h | 1475 > ++++++++++++++++++++ > drivers/gpu/drm/sprd/dw_dsi_ctrl_ppi.c | 157 +++ > drivers/gpu/drm/sprd/dw_dsi_ctrl_ppi.h | 26 + > drivers/gpu/drm/sprd/megacores_pll.c | 317 +++++ > drivers/gpu/drm/sprd/megacores_pll.h | 146 ++ > drivers/gpu/drm/sprd/sprd_dpu.c | 985 +++++++++++++ > drivers/gpu/drm/sprd/sprd_dpu.h | 120 ++ > drivers/gpu/drm/sprd/sprd_drm.c | 224 +++ > drivers/gpu/drm/sprd/sprd_drm.h | 19 + > drivers/gpu/drm/sprd/sprd_dsi.c | 1162 ++++++++++++++= + > drivers/gpu/drm/sprd/sprd_dsi.h | 107 ++ > 19 files changed, 5799 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/sprd/sprd,display-subsystem.yam= l > create mode 100644 > Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dpu.yaml > create mode 100644 > Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml > create mode 100644 drivers/gpu/drm/sprd/Kconfig > create mode 100644 drivers/gpu/drm/sprd/Makefile > create mode 100644 drivers/gpu/drm/sprd/dw_dsi_ctrl.c > create mode 100644 drivers/gpu/drm/sprd/dw_dsi_ctrl.h > create mode 100644 drivers/gpu/drm/sprd/dw_dsi_ctrl_ppi.c > create mode 100644 drivers/gpu/drm/sprd/dw_dsi_ctrl_ppi.h > create mode 100644 drivers/gpu/drm/sprd/megacores_pll.c > create mode 100644 drivers/gpu/drm/sprd/megacores_pll.h > create mode 100644 drivers/gpu/drm/sprd/sprd_dpu.c > create mode 100644 drivers/gpu/drm/sprd/sprd_dpu.h > create mode 100644 drivers/gpu/drm/sprd/sprd_drm.c > create mode 100644 drivers/gpu/drm/sprd/sprd_drm.h > create mode 100644 drivers/gpu/drm/sprd/sprd_dsi.c > create mode 100644 drivers/gpu/drm/sprd/sprd_dsi.h > > -- > 2.7.4 > > --0000000000000fd67e05b97f9abc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Daniel,=C2=A0
Do you have some more comments for ou= r patch?

Kevin Tang <kevin3.tang@gmail.com> =E4=BA=8E2021=E5=B9=B41=E6=9C=885=E6= =97=A5=E5=91=A8=E4=BA=8C =E4=B8=8B=E5=8D=889:46=E5=86=99=E9=81=93=EF=BC=9A<= br>
ChangeList:
RFC v1:
1. only upstream modeset and atomic at first commit.
2. remove some unused code;
3. use alpha and blend_mode properties;
3. add yaml support;
4. remove auto-adaptive panel driver;
5. bugfix

RFC v2:
1. add sprd crtc and plane module for KMS, preparing for multi crtc&enc= oder
2. remove gem drivers, use generic CMA handlers
3. remove redundant "module_init", all the sub modules loading by= KMS

RFC v3:
1. multi crtc&encoder design have problem, so rollback to v1

RFC v4:
1. update to gcc-linaro-7.5.0
2. update to Linux 5.6-rc3
3. remove pm_runtime support
4. add COMPILE_TEST, remove unused kconfig
5. "drm_dev_put" on drm_unbind
6. fix some naming convention issue
7. remove semaphore lock for crtc flip
8. remove static variables

RFC v5:
1. optimize encoder and connector code implementation
2. use "platform_get_irq" and "platform_get_resource" 3. drop useless function return type, drop unless debug log
4. custom properties should be separate, so drop it
5. use DRM_XXX replase pr_xxx
6. drop dsi&dphy hal callback ops
7. drop unless callback ops checking
8. add comments for sprd dpu structure

RFC v6:
1. Access registers via readl/writel
2. Checking for unsupported KMS properties (format, rotation, blend_mode, e= tc) on plane_check ops
3. Remove always true checks for dpu core ops

RFC v7:
1. Fix DTC unit name warnings
2. Fix the problem of maintainers
3. Call drmm_mode_config_init to mode config init
4. Embed drm_device in sprd_drm and use devm_drm_dev_alloc
5. Replace DRM_XXX with drm_xxx on KMS module, but not suitable for other s= ubsystems
6. Remove plane_update stuff, dpu handles all the HW update in crtc->ato= mic_flush
7. Dsi&Dphy Code structure adjustment, all move to "sprd/"
v0:
1. Remove dpu_core_ops stuff layer for sprd drtc driver, but dpu_layer need= to keeping.
=C2=A0 =C2=A0Because all the HW update in crtc->atomic_flush, we need te= mporary storage all layers for
=C2=A0 =C2=A0the dpu pageflip of atomic_flush.
2. Add ports subnode with port@X.

v1:
1. Remove dphy and dsi graph binding, merge the dphy driver into the dsi. 2. Add commit messages for Unisoc's virtual nodes.

v2:
1. Use drm_xxx to replace all DRM_XXX.
2. Use kzalloc to replace devm_kzalloc for sprd_dsi/sprd_dpu structure init= .
3. Remove dpu_core_ops midlayer.

v3:
1. Remove dpu_layer midlayer and commit layers by aotmic_update

Kevin Tang (6):
=C2=A0 dt-bindings: display: add Unisoc's drm master bindings
=C2=A0 drm/sprd: add Unisoc's drm kms master
=C2=A0 dt-bindings: display: add Unisoc's dpu bindings
=C2=A0 drm/sprd: add Unisoc's drm display controller driver
=C2=A0 dt-bindings: display: add Unisoc's mipi dsi controller bindings<= br> =C2=A0 drm/sprd: add Unisoc's drm mipi dsi&dphy driver

=C2=A0.../display/sprd/sprd,display-subsystem.yaml=C2=A0 =C2=A0 =C2=A0 =C2= =A0|=C2=A0 =C2=A064 +
=C2=A0.../bindings/display/sprd/sprd,sharkl3-dpu.yaml=C2=A0 =C2=A0 |=C2=A0 = =C2=A077 +
=C2=A0.../display/sprd/sprd,sharkl3-dsi-host.yaml=C2=A0 =C2=A0 =C2=A0 =C2= =A0 |=C2=A0 102 ++
=C2=A0drivers/gpu/drm/Kconfig=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 2 +
=C2=A0drivers/gpu/drm/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 1 +
=C2=A0drivers/gpu/drm/sprd/Kconfig=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A013 +
=C2=A0drivers/gpu/drm/sprd/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 8 +
=C2=A0drivers/gpu/drm/sprd/dw_dsi_ctrl.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 794 +++++++++++
=C2=A0drivers/gpu/drm/sprd/dw_dsi_ctrl.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0| 1475 ++++++++++++++++++++
=C2=A0drivers/gpu/drm/sprd/dw_dsi_ctrl_ppi.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0|=C2=A0 157 +++
=C2=A0drivers/gpu/drm/sprd/dw_dsi_ctrl_ppi.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0|=C2=A0 =C2=A026 +
=C2=A0drivers/gpu/drm/sprd/megacores_pll.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 317 +++++
=C2=A0drivers/gpu/drm/sprd/megacores_pll.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 146 ++
=C2=A0drivers/gpu/drm/sprd/sprd_dpu.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 985 +++++++++++++
=C2=A0drivers/gpu/drm/sprd/sprd_dpu.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 120 ++
=C2=A0drivers/gpu/drm/sprd/sprd_drm.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 224 +++
=C2=A0drivers/gpu/drm/sprd/sprd_drm.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A019 +
=C2=A0drivers/gpu/drm/sprd/sprd_dsi.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 1162 +++++++++++++++
=C2=A0drivers/gpu/drm/sprd/sprd_dsi.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 107 ++
=C2=A019 files changed, 5799 insertions(+)
=C2=A0create mode 100644 Documentation/devicetree/bindings/display/sprd/spr= d,display-subsystem.yaml
=C2=A0create mode 100644 Documentation/devicetree/bindings/display/sprd/spr= d,sharkl3-dpu.yaml
=C2=A0create mode 100644 Documentation/devicetree/bindings/display/sprd/spr= d,sharkl3-dsi-host.yaml
=C2=A0create mode 100644 drivers/gpu/drm/sprd/Kconfig
=C2=A0create mode 100644 drivers/gpu/drm/sprd/Makefile
=C2=A0create mode 100644 drivers/gpu/drm/sprd/dw_dsi_ctrl.c
=C2=A0create mode 100644 drivers/gpu/drm/sprd/dw_dsi_ctrl.h
=C2=A0create mode 100644 drivers/gpu/drm/sprd/dw_dsi_ctrl_ppi.c
=C2=A0create mode 100644 drivers/gpu/drm/sprd/dw_dsi_ctrl_ppi.h
=C2=A0create mode 100644 drivers/gpu/drm/sprd/megacores_pll.c
=C2=A0create mode 100644 drivers/gpu/drm/sprd/megacores_pll.h
=C2=A0create mode 100644 drivers/gpu/drm/sprd/sprd_dpu.c
=C2=A0create mode 100644 drivers/gpu/drm/sprd/sprd_dpu.h
=C2=A0create mode 100644 drivers/gpu/drm/sprd/sprd_drm.c
=C2=A0create mode 100644 drivers/gpu/drm/sprd/sprd_drm.h
=C2=A0create mode 100644 drivers/gpu/drm/sprd/sprd_dsi.c
=C2=A0create mode 100644 drivers/gpu/drm/sprd/sprd_dsi.h

--
2.7.4

--0000000000000fd67e05b97f9abc-- --===============0032325641== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0032325641==--