From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C44BFC3F2D1 for ; Thu, 5 Mar 2020 08:15:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 987FC2073D for ; Thu, 5 Mar 2020 08:15:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J81u/LYb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 987FC2073D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 11CBB6EB89; Thu, 5 Mar 2020 08:14:40 +0000 (UTC) Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9877A89BF5 for ; Wed, 4 Mar 2020 10:01:13 +0000 (UTC) Received: by mail-qt1-x844.google.com with SMTP id 59so900942qtb.1 for ; Wed, 04 Mar 2020 02:01:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8DsdSZ64K0LPAMg8xgYOvioBKCRjLiHvdT1IfS9y3K8=; b=J81u/LYbLOC+HafupZZpwyve3T32z6YQErz64fwo8exGwB3v2sHOGkJhyEYWdeLIEk YMoPNpQzOQFu1ndbaYEMl7W5hOrr6giu4MKLdAFfYDfcZCE1cwWIerTXWlqCOEjhxLTl 5crpA+YA0BHlAMyNz+rP2mxysIxQacFLGoLbEZTVT7ugCbOSztHE7B/LLlu98UmVgOdr S8FrnXGDvtAh1ETChnZnkleX0ST+dwJbp2fp7l88vZ9O5DW3zQxN55valB2PGU3ooaCr sMcybDcplb0G3TvXeo3a1nXdZrrp1p6muqPEOvipNCAEG9B2PmknS/NUkL9AZ6KgmuNG KIyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8DsdSZ64K0LPAMg8xgYOvioBKCRjLiHvdT1IfS9y3K8=; b=CrlClrVAZ8dLzWHydNr6lWU8fBjExYXJTSiX2MpL18bR8ZKxdlWTV7KXRowElI0vmB BwHos6q0Ah2CDsKSOlxqbKF58fh91nZlvPE09rch1UY8IkaMx9qMY4Da12pqscrg+4vL EYWSbZKiDSMJ0bBtH73B8Pn+c9lCL0hjAqDmghaWZEB0+HuD2yvMQNKFGlE+AV1i68uH 8WJEVjdYtnUEIW7eCux7STWZIwPKyzmFwQuC7R7yclECMB3Ibv1j6y/d4SXraMSA323+ IVdTC3rAeOSyssz7PrwFfFSLjB/saEaFRiYKJ9RxEnyNGydLUcHHuc4BkXEccEmJMEZV poFw== X-Gm-Message-State: ANhLgQ2j6eetECRjem/OnPAtCMTYuKGVZ5CbGbIE6yFOWvaYdZZB11ht ODwmLJhBTWOgl7qnhIh8Cfb3h9IDRilSIwRG2oU= X-Google-Smtp-Source: ADFU+vuNWKgMDbs1LEgSp+TwDWYB1DWHj7hzGPRwnzpRr/e/pVs3NGawVS5+pmeXJ6OsBvUr/EgyeJjyvaBzAo7A12s= X-Received: by 2002:ac8:4994:: with SMTP id f20mr1694359qtq.2.1583316071803; Wed, 04 Mar 2020 02:01:11 -0800 (PST) MIME-Version: 1.0 References: <1582710377-15489-1-git-send-email-kevin3.tang@gmail.com> <1582710377-15489-2-git-send-email-kevin3.tang@gmail.com> In-Reply-To: From: tang pengchuan Date: Wed, 4 Mar 2020 18:01:00 +0800 Message-ID: Subject: Re: [PATCH RFC v4 1/6] dt-bindings: display: add Unisoc's drm master bindings To: Rob Herring X-Mailman-Approved-At: Thu, 05 Mar 2020 08:14:30 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Baolin Wang , David Airlie , Lyra Zhang , "linux-kernel@vger.kernel.org" , dri-devel , Orson Zhai , Sean Paul Content-Type: multipart/mixed; boundary="===============0401147032==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --===============0401147032== Content-Type: multipart/alternative; boundary="00000000000006f28005a0048072" --00000000000006f28005a0048072 Content-Type: text/plain; charset="UTF-8" On Fri, Feb 28, 2020 at 12:50 AM Rob Herring wrote: > On Wed, Feb 26, 2020 at 3:46 AM Kevin Tang wrote: > > > > From: Kevin Tang > > > > The Unisoc DRM master device is a virtual device needed to list all > > DPU devices or other display interface nodes that comprise the > > graphics subsystem > > > > Cc: Orson Zhai > > Cc: Baolin Wang > > Cc: Chunyan Zhang > > Signed-off-by: Kevin Tang > > --- > > .../devicetree/bindings/display/sprd/drm.yaml | 36 > ++++++++++++++++++++++ > > 1 file changed, 36 insertions(+) > > create mode 100644 > Documentation/devicetree/bindings/display/sprd/drm.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/sprd/drm.yaml > b/Documentation/devicetree/bindings/display/sprd/drm.yaml > > new file mode 100644 > > index 0000000..b5792c0 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/sprd/drm.yaml > > @@ -0,0 +1,36 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/sprd/drm.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Unisoc DRM master device > > + > > +maintainers: > > + - Mark Rutland > > + > > +description: | > > + The Unisoc DRM master device is a virtual device needed to list all > > + DPU devices or other display interface nodes that comprise the > > + graphics subsystem. > > + > > +properties: > > + compatible: > > + const: sprd,display-subsystem > > + > > + ports: > > + description: > > + Should contain a list of phandles pointing to display interface > port > > + of DPU devices. > > + > > +required: > > + - compatible > > + - ports > > + > > +examples: > > + - | > > + display-subsystem { > > + compatible = "sprd,display-subsystem"; > > + ports = <&dpu_out>; > > We try to avoid these virtual nodes and bind with actual h/w nodes. > Can you have more than one DPU and if so does it need to be a single > DRM driver instance? > I don't really understand what you mean, so reply as I understand... "dpu_out" node is the real h/w node, defined on dpu.yaml Yeah, we will be have multi DPU > > Rob > --00000000000006f28005a0048072 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Fri, Feb 28, 2020 at 12:50 AM Rob = Herring <robh+dt@kernel.org&= gt; wrote:
On We= d, Feb 26, 2020 at 3:46 AM Kevin Tang <kevin3.tang@gmail.com> wrote:
>
> From: Kevin Tang <kevin.tang@unisoc.com>
>
> The Unisoc DRM master device is a virtual device needed to list all > DPU devices or other display interface nodes that comprise the
> graphics subsystem
>
> Cc: Orson Zhai <orsonzhai@gmail.com>
> Cc: Baolin Wang <baolin.wang@linaro.org>
> Cc: Chunyan Zhang <zhang.lyra@gmail.com>
> Signed-off-by: Kevin Tang <kevin.tang@unisoc.com>
> ---
>=C2=A0 .../devicetree/bindings/display/sprd/drm.yaml=C2=A0 =C2=A0 =C2= =A0 | 36 ++++++++++++++++++++++
>=C2=A0 1 file changed, 36 insertions(+)
>=C2=A0 create mode 100644 Documentation/devicetree/bindings/display/spr= d/drm.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/sprd/drm.yaml b= /Documentation/devicetree/bindings/display/sprd/drm.yaml
> new file mode 100644
> index 0000000..b5792c0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/sprd/drm.yaml
> @@ -0,0 +1,36 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display= /sprd/drm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.= yaml#
> +
> +title: Unisoc DRM master device
> +
> +maintainers:
> +=C2=A0 - Mark Rutland <mark.rutland@arm.com>
> +
> +description: |
> +=C2=A0 The Unisoc DRM master device is a virtual device needed to lis= t all
> +=C2=A0 DPU devices or other display interface nodes that comprise the=
> +=C2=A0 graphics subsystem.
> +
> +properties:
> +=C2=A0 compatible:
> +=C2=A0 =C2=A0 const: sprd,display-subsystem
> +
> +=C2=A0 ports:
> +=C2=A0 =C2=A0 description:
> +=C2=A0 =C2=A0 =C2=A0 Should contain a list of phandles pointing to di= splay interface port
> +=C2=A0 =C2=A0 =C2=A0 of DPU devices.
> +
> +required:
> +=C2=A0 - compatible
> +=C2=A0 - ports
> +
> +examples:
> +=C2=A0 - |
> +=C2=A0 =C2=A0 display-subsystem {
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 compatible =3D "sprd,display-subsyst= em";
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 ports =3D <&dpu_out>;

We try to avoid these virtual nodes and bind with actual h/w nodes.
Can you have more than one DPU and if so does it need to be a single
DRM driver instance?
I don= 't really understand what you mean, so repl= y as I understand...
"dpu_out" node is th= e real h/w node, defined on dpu.yaml
= Yeah, we will be ha= ve multi DPU

Rob
--00000000000006f28005a0048072-- --===============0401147032== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0401147032==--