From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E088C47E4D for ; Thu, 15 Jul 2021 11:09:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD1EB613BA for ; Thu, 15 Jul 2021 11:09:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD1EB613BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CADF66E822; Thu, 15 Jul 2021 11:09:56 +0000 (UTC) Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by gabe.freedesktop.org (Postfix) with ESMTPS id A81606E822; Thu, 15 Jul 2021 11:09:55 +0000 (UTC) Received: by mail-ot1-x329.google.com with SMTP id h24-20020a9d64180000b029036edcf8f9a6so5759505otl.3; Thu, 15 Jul 2021 04:09:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VnIvSXzuiLKWuvgulqfarspmLG2dOzwb7htWyTzwsjw=; b=jZSvmaYSy8ADTgcCb9b7ny+VGlsNNLLNOYJdU7McebyVX4mq0pGAcstpYcMq1Aiv6S XOo3xy1FWet7MXd7e7bhh9ULV6oDNaPZwU83/HY/YN+avkBCc7WRn8rrw01zsWV94kqD zveDrhVhYXZNw9+xQg2SBfo7OMbtziipz+BPTRr2nVTwTX5Zbj3LNmo5gqPZla4YgjUr CMVnzDdH9YVyJCAxYWCz6i0n7jvRINXJv0bLBQO52VA4L5QduTy2cR8drOamqk/LOftw kysUkWgyiG6dY9FlEfnonTf57JurQjQ+0MQUH4y/eduUeozIhN6rWYTFT2mAUx+bFtCa eVcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VnIvSXzuiLKWuvgulqfarspmLG2dOzwb7htWyTzwsjw=; b=e6STrcDKzWNO3T2Ev2Bp9sh2akAJ2k6ao22iba10cUA7tbqKXEgf66H1/FXu4y1LJm iHRHJcB3hq/pF0ldX7y/dk2gWRfdcffWggazqp1YopOY1Cqyr3DOg1QENBoDdMXSI0Dh 0jyYQAHv6TTL/x9BgTgq3RJAcAgJ7ayxCpRnJnYv8p78YEAt7eZDP4veL7UT8ax5vk3o Lsu+WjA2iPu+PfW0WOPTg6nX6cOHPo5rKzm4Zhm0W0VsxHuCplIZflzu344oU1jqxyDc EmrnT/eR5NjMXcuy7ircbGygQ6le8oClZ8iUojpSXyWMIsn9R3kY2CVrQYRZS11Phgkw GveQ== X-Gm-Message-State: AOAM530pPwPyb8ecPcN9ifkzS4qArBvM+XulUmxvOxl+BykV7YRNn65D ZsHuxxwcD7uxS8jFwy2dzlXGm1XpIyJBxL/BTMU= X-Google-Smtp-Source: ABdhPJyE6O2CsuPYvTE0fEvIRod8YkMOcqSCGJb0RhRrpq/XyumDEFhAFhjuy8zGn19Bma0gQJuRs9BuxAPgAU8c3Mw= X-Received: by 2002:a05:6830:19cd:: with SMTP id p13mr2307456otp.362.1626347395013; Thu, 15 Jul 2021 04:09:55 -0700 (PDT) MIME-Version: 1.0 References: <20210624105517.3886963-1-hsinyi@chromium.org> <20210624105517.3886963-2-hsinyi@chromium.org> In-Reply-To: <20210624105517.3886963-2-hsinyi@chromium.org> From: Enric Balletbo Serra Date: Thu, 15 Jul 2021 13:09:43 +0200 Message-ID: Subject: Re: [PATCH v6 RESEND 2/3] drm/mediatek: init panel orientation property To: Hsin-Yi Wang Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , Thomas Zimmermann , devicetree , David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel , dri-devel , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , Sean Paul , Linux ARM Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Hsin-Yi, Thank you for your patch. Missatge de Hsin-Yi Wang del dia dj., 24 de juny 2021 a les 12:55: > > Init panel orientation property after connector is initialized. Let the > panel driver decides the orientation value later. > > Signed-off-by: Hsin-Yi Wang > Acked-by: Chun-Kuang Hu Tested-by: Enric Balletbo i Serra As together with the other two patches works and I don't see any problem on the Lenovo IdeaPad Duet, and the panel has the proper orientation > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > index ae403c67cbd92..9da1fd6491319 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -964,6 +964,13 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi) > ret = PTR_ERR(dsi->connector); > goto err_cleanup_encoder; > } > + > + ret = drm_connector_init_panel_orientation_property(dsi->connector); > + if (ret) { > + DRM_ERROR("Unable to init panel orientation\n"); > + goto err_cleanup_encoder; > + } > + > drm_connector_attach_encoder(dsi->connector, &dsi->encoder); > > return 0; > -- > 2.32.0.288.g62a8d224e6-goog >