From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F39DC433EF for ; Tue, 4 Jan 2022 17:09:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7A40F10E209; Tue, 4 Jan 2022 17:09:45 +0000 (UTC) Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by gabe.freedesktop.org (Postfix) with ESMTPS id AAF3610E209 for ; Tue, 4 Jan 2022 17:09:44 +0000 (UTC) Received: by mail-pl1-x635.google.com with SMTP id l16so15433679plg.10 for ; Tue, 04 Jan 2022 09:09:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=v+sdvu70C0xmlTgzjTDbY24EG0MXij5hjChqtwUwrTE=; b=D0ZRrzUwVLXrsRFqggla5SDwyIEXmpdKZMKeKZE0lFDV46OBeyw4nivbVEXPyR7Aqk xzZXhPwuA0sgvakMC93oo1lNepQ1jFM5Qa+mdlEvvclkuFhZz7vlWepY87AIwRLRmC1+ N4Oy3b5RRNdJ3k4c+VCTt6muEjIwyfe2mYXCvHLbDgBzvON68btwaKTJyjXF40CbP9No Z3MmDM8klu6u9rqvrtk/b7Z/QKXaMR9vbdTsCuhNYBLtgiMLWntatpxjGEQgGQ//Rsq6 vji59h4nU+EtbcJCDSluVcSp6PCV5cxQtjgIP0U7S0iILWvbwcsl075w6j/SDFJ1cMXB Cwhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=v+sdvu70C0xmlTgzjTDbY24EG0MXij5hjChqtwUwrTE=; b=zpOuAz8PHVhZZpSbZN4Noi717iwE/V1tytSYTTWc9X4dRpKvY7bDvDissTAcJ00HXi QUohhot1y3n4x/jy9hkeeJs+py1OINpM7d4w3E8dPcM9wxfO9rjiaqqihanJFBIA4MIA qet0QrBoSBXYr0THInjojSeIRcWE+HaJHM4S2Qq42qdHNiwGxUy4p+dGPxoVmZVtUy9D XfCXVlfJvkRhT/GEWvI8zLf0LzfkMmg+icvKHxUxVSHAE3x7jJOLZvpToN75oPFu+1J3 MomFF+xAgY8qcJqxUjZNqWtRNt70zVP82Rhny6ZUWcFICFcDsuraICELJw628bIvti1L zjEg== X-Gm-Message-State: AOAM530W1KJxDcStLzZe/SSu50gbqp9EPc1k7nMJnpzTRpPggK0Qqw2j smTXDg/8kj5MxWsYCQcOoUVvKL8foY/cek5RQ8zGLA== X-Google-Smtp-Source: ABdhPJzCnlENHJ5TZQp74nev5/hU1MtDxyd/KsXaOuRaJ3IXJz6/1SYEKOPP5gwrWa2feM4DJ47kJdIXaEfFub8557E= X-Received: by 2002:a17:90b:4b0f:: with SMTP id lx15mr62251454pjb.232.1641316184113; Tue, 04 Jan 2022 09:09:44 -0800 (PST) MIME-Version: 1.0 References: <20211110220050.2854-1-jirivanek1@gmail.com> In-Reply-To: From: Robert Foss Date: Tue, 4 Jan 2022 18:09:32 +0100 Message-ID: Subject: Re: [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS To: Vinay Simha B N Content-Type: multipart/alternative; boundary="0000000000001e6ac305d4c4b48e" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jiri Vanek , Jonas Karlman , David Airlie , "open list:DRM PANEL DRIVERS" , Neil Armstrong , open list , Jernej Skrabec , Zheng Bin , Andrzej Hajda , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --0000000000001e6ac305d4c4b48e Content-Type: text/plain; charset="UTF-8" On Tue, Jan 4, 2022, 17:56 Vinay Simha B N wrote: > Robert, > What is R-b tag? > It looks like this Reviewed-by: Name Lastname Maybe have a quick look at this document. https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html > > On Tue, Jan 4, 2022 at 7:21 PM Robert Foss wrote: > > > > Jiri: Are you able to test this patch? > > > > Vinay: Could you supply a R-b tag, if you feel that it is warranted? > > > > On Tue, 14 Dec 2021 at 09:13, Vinay Simha B N > wrote: > > > > > > Robert, > > > I do not have the hardware to test this feature. Sorry for the late > response. > > > > > > On Thu, Nov 18, 2021 at 8:20 PM Robert Foss > wrote: > > >> > > >> + Zhen & Vinay > > >> > > >> This patch looks good in itself, but I would like to see a tested by > > >> tag. At the very least testing for regression in single-link LVDS but > > >> ideally some third party verification of this patch. > > >> > > >> On Wed, 10 Nov 2021 at 23:01, Jiri Vanek > wrote: > > >> > > > >> > Fixed wrong register shift for single/dual link LVDS output. > > >> > > > >> > Signed-off-by: Jiri Vanek > > >> > --- > > >> > drivers/gpu/drm/bridge/tc358775.c | 2 +- > > >> > 1 file changed, 1 insertion(+), 1 deletion(-) > > >> > > > >> > diff --git a/drivers/gpu/drm/bridge/tc358775.c > b/drivers/gpu/drm/bridge/tc358775.c > > >> > index 2272adcc5b4a..1d6ec1baeff2 100644 > > >> > --- a/drivers/gpu/drm/bridge/tc358775.c > > >> > +++ b/drivers/gpu/drm/bridge/tc358775.c > > >> > @@ -241,7 +241,7 @@ static inline u32 > TC358775_LVCFG_PCLKDIV(uint32_t val) > > >> > } > > >> > > > >> > #define TC358775_LVCFG_LVDLINK__MASK > 0x00000002 > > >> > -#define TC358775_LVCFG_LVDLINK__SHIFT 0 > > >> > +#define TC358775_LVCFG_LVDLINK__SHIFT 1 > > >> > static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val) > > >> > { > > >> > return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & > > >> > -- > > >> > 2.30.2 > > >> > > > > > > > > > > > > > -- > > > regards, > > > vinaysimha > > > > -- > regards, > vinaysimha > --0000000000001e6ac305d4c4b48e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Jan 4, 2022, 17:56 Vinay Simha B N <simhavcs@gmail.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">Robert,
What is R-b tag?

It looks like this Reviewed-by: Name Lastname <email add= ress>

Maybe have a qu= ick look at this document.




On Tue, Jan 4, 2022 at 7:21 PM Robert Foss <robert.foss@linaro.org> wrote:
>
> Jiri: Are you able to test this patch?
>
> Vinay: Could you supply a R-b tag, if you feel that it is warranted? >
> On Tue, 14 Dec 2021 at 09:13, Vinay Simha B N <simhavcs@gmail.com> wrote:
> >
> > Robert,
> > I do not have the hardware to test this feature. Sorry for the la= te response.
> >
> > On Thu, Nov 18, 2021 at 8:20 PM Robert Foss <robert.foss@l= inaro.org> wrote:
> >>
> >> + Zhen & Vinay
> >>
> >> This patch looks good in itself, but I would like to see a te= sted by
> >> tag. At the very least testing for regression in single-link = LVDS but
> >> ideally some third party verification of this patch.
> >>
> >> On Wed, 10 Nov 2021 at 23:01, Jiri Vanek <jirivanek1@gma= il.com> wrote:
> >> >
> >> > Fixed wrong register shift for single/dual link LVDS out= put.
> >> >
> >> > Signed-off-by: Jiri Vanek <jirivanek1@gmail.com= >
> >> > ---
> >> >=C2=A0 drivers/gpu/drm/bridge/tc358775.c | 2 +-
> >> >=C2=A0 1 file changed, 1 insertion(+), 1 deletion(-)
> >> >
> >> > diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers= /gpu/drm/bridge/tc358775.c
> >> > index 2272adcc5b4a..1d6ec1baeff2 100644
> >> > --- a/drivers/gpu/drm/bridge/tc358775.c
> >> > +++ b/drivers/gpu/drm/bridge/tc358775.c
> >> > @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCL= KDIV(uint32_t val)
> >> >=C2=A0 }
> >> >
> >> >=C2=A0 #define TC358775_LVCFG_LVDLINK__MASK=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A00x00000002
> >> > -#define TC358775_LVCFG_LVDLINK__SHIFT=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 0
> >> > +#define TC358775_LVCFG_LVDLINK__SHIFT=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1
> >> >=C2=A0 static inline u32 TC358775_LVCFG_LVDLINK(uint32_t = val)
> >> >=C2=A0 {
> >> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return ((val) << = TC358775_LVCFG_LVDLINK__SHIFT) &
> >> > --
> >> > 2.30.2
> >> >
> >
> >
> >
> > --
> > regards,
> > vinaysimha



--
regards,
vinaysimha
--0000000000001e6ac305d4c4b48e--