From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FEA0C433E0 for ; Fri, 19 Mar 2021 14:35:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40A1564EE2 for ; Fri, 19 Mar 2021 14:35:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40A1564EE2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 98E916EA29; Fri, 19 Mar 2021 14:35:54 +0000 (UTC) Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5FD686EA29 for ; Fri, 19 Mar 2021 14:35:53 +0000 (UTC) Received: by mail-pj1-x102b.google.com with SMTP id q6-20020a17090a4306b02900c42a012202so4947246pjg.5 for ; Fri, 19 Mar 2021 07:35:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0R7vCUqOiWqusGQdLDA2yAGdzDAYsdMM6CojvsuIllk=; b=dYE81wS7DSKdB7GyR7+XAISp1t5pL/zSDfGVzIkbDNtoK9UFhOBsBQloCz5aWC1JAw lb3M2Iovl8eVPmG9iOIr/YUjCSJAhPTN/g+p6UMu6/Y1VjFTY32AXsOmDiENYV+o4uYU 2E6IrTuBArSyTrhCPYpg4mJiuwrSs7OAHvKo0A4CJV1bCBDO7aWZsxn8OtdcMNW1ZA7u S+elXIqViLr/nD7rTq4htiUkJ5lo2uGNeF21pedQKl0u5C8M9VsU/JvlO1Bjey6pA7C4 ANLJaApZfubVYKU033BWxll74mz1LZeSHXGAp7PYpcEbxUnJW9WBOVD/HMYy5a3wMAlo KCQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0R7vCUqOiWqusGQdLDA2yAGdzDAYsdMM6CojvsuIllk=; b=YLbSHi7jmxSbVA+FhwBVaPPJRHTvt0MRT3GOP6NrlyACYJ8quvrFIZCL0Dt+11YZYa ZQVuXGRzZ21PBryMZsbB0xdA2eR9+rvYmql0B6jHOYzRO+DD1twYQCvf/AlO9k3/rElJ 8P6S6vSfKkwn3HftimPtPVPZ8GZQgMWlwH1d7Xoutnm1ptHvxjTkJYw0XVVJOn7x4dhd lHmRWX+I6C74pxZSuZs/cPllj+CApju6c1xAIzzrXm/jmib+yp/CmLyCszkcEwA19mEL FOUoIeb7ZdvzkstbAz5ZaAgzNDJfe959P++7Y2Gar4BGPmwDXm0gNE7VdyVfVXxYVcEx ycnQ== X-Gm-Message-State: AOAM531Y0vIFlCdoVxdP3AfQ8cg1+v7zV2oABmut6xNnQZRkj1TpoD2Z 6507918nAuR45mGvLRbpfkKZr3FIx7/ZQMLhBHbHOg== X-Google-Smtp-Source: ABdhPJx6mz7QtxY42zHzQ4OwZrXSYkhmbs+ESa/8sPIZwAXqhmt9XhBi9MDQuYZrkn0CZzsEUeDWOtF7VrY+uzB9bCI= X-Received: by 2002:a17:90a:4a8f:: with SMTP id f15mr10307132pjh.19.1616164552793; Fri, 19 Mar 2021 07:35:52 -0700 (PDT) MIME-Version: 1.0 References: <20210219215326.2227596-1-lyude@redhat.com> <20210219215326.2227596-9-lyude@redhat.com> In-Reply-To: <20210219215326.2227596-9-lyude@redhat.com> From: Robert Foss Date: Fri, 19 Mar 2021 15:35:41 +0100 Message-ID: Subject: Re: [PATCH 08/30] drm/bridge/analogix/anx78xx: Setup encoder before registering connector To: Lyude Paul X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Torsten Duwe , Jernej Skrabec , dri-devel , Neil Armstrong , David Airlie , nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Jonas Karlman , open list , Andrzej Hajda , Tomi Valkeinen , Boris Brezillon , amd-gfx@lists.freedesktop.org, Thomas Zimmermann , Rodrigo Vivi , Sam Ravnborg , Laurent Pinchart Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hey Lyude, Thanks for the patch, it looks good to me. Reviewed-by: Robert Foss On Fri, 19 Feb 2021 at 22:56, Lyude Paul wrote: > > Since encoder mappings for connectors are exposed to userspace, we should > be attaching the encoder before exposing the connector to userspace. Just a > drive-by fix for an issue I noticed while fixing up usages of > drm_dp_aux_init()/drm_dp_aux_register() across the tree. > > Signed-off-by: Lyude Paul > --- > drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c > index ec4607dc01eb..338dd8531d4b 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c > @@ -924,12 +924,6 @@ static int anx78xx_bridge_attach(struct drm_bridge *bridge, > drm_connector_helper_add(&anx78xx->connector, > &anx78xx_connector_helper_funcs); > > - err = drm_connector_register(&anx78xx->connector); > - if (err) { > - DRM_ERROR("Failed to register connector: %d\n", err); > - return err; > - } > - > anx78xx->connector.polled = DRM_CONNECTOR_POLL_HPD; > > err = drm_connector_attach_encoder(&anx78xx->connector, > @@ -939,6 +933,12 @@ static int anx78xx_bridge_attach(struct drm_bridge *bridge, > return err; > } > > + err = drm_connector_register(&anx78xx->connector); > + if (err) { > + DRM_ERROR("Failed to register connector: %d\n", err); > + return err; > + } > + > return 0; > } > > -- > 2.29.2 > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel