dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] drm/bridge: anx7625: Fix power on delay
@ 2021-04-28 11:51 Hsin-Yi Wang
  2021-04-28 15:46 ` Robert Foss
  0 siblings, 1 reply; 2+ messages in thread
From: Hsin-Yi Wang @ 2021-04-28 11:51 UTC (permalink / raw)
  To: Robert Foss
  Cc: Jernej Skrabec, Neil Armstrong, David Airlie, Jonas Karlman,
	linux-kernel, dri-devel, Andrzej Hajda, Laurent Pinchart,
	Sam Ravnborg, Xin Ji

From anx7625 spec, the delay between powering on power supplies and gpio
should be larger than 10ms.

Fixes: 6c744983004e ("drm/bridge: anx7625: disable regulators when power off")
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
---
v1->v2: Extend sleep range a bit as the regulator on some device takes
more time to be powered on after regulator_enable() is called.
---
 drivers/gpu/drm/bridge/analogix/anx7625.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 23283ba0c4f9..b4e349ca38fe 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -893,7 +893,7 @@ static void anx7625_power_on(struct anx7625_data *ctx)
 		usleep_range(2000, 2100);
 	}
 
-	usleep_range(4000, 4100);
+	usleep_range(11000, 12000);
 
 	/* Power on pin enable */
 	gpiod_set_value(ctx->pdata.gpio_p_on, 1);
-- 
2.31.1.498.g6c1eba8ee3d-goog

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] drm/bridge: anx7625: Fix power on delay
  2021-04-28 11:51 [PATCH v2] drm/bridge: anx7625: Fix power on delay Hsin-Yi Wang
@ 2021-04-28 15:46 ` Robert Foss
  0 siblings, 0 replies; 2+ messages in thread
From: Robert Foss @ 2021-04-28 15:46 UTC (permalink / raw)
  To: Hsin-Yi Wang
  Cc: Jernej Skrabec, Neil Armstrong, David Airlie, Jonas Karlman,
	linux-kernel, dri-devel, Andrzej Hajda, Laurent Pinchart,
	Sam Ravnborg, Xin Ji


[-- Attachment #1.1: Type: text/plain, Size: 1312 bytes --]

Merged.

https://cgit.freedesktop.org/drm/drm-misc/commit/?id=1fcf24fb07e254ca69001ab14adc8cf567127c44

On Wed, 28 Apr 2021 at 13:51, Hsin-Yi Wang <hsinyi@chromium.org> wrote:

> From anx7625 spec, the delay between powering on power supplies and gpio
> should be larger than 10ms.
>
> Fixes: 6c744983004e ("drm/bridge: anx7625: disable regulators when power
> off")
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> v1->v2: Extend sleep range a bit as the regulator on some device takes
> more time to be powered on after regulator_enable() is called.
> ---
>  drivers/gpu/drm/bridge/analogix/anx7625.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c
> b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 23283ba0c4f9..b4e349ca38fe 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -893,7 +893,7 @@ static void anx7625_power_on(struct anx7625_data *ctx)
>                 usleep_range(2000, 2100);
>         }
>
> -       usleep_range(4000, 4100);
> +       usleep_range(11000, 12000);
>
>         /* Power on pin enable */
>         gpiod_set_value(ctx->pdata.gpio_p_on, 1);
> --
> 2.31.1.498.g6c1eba8ee3d-goog
>
>

[-- Attachment #1.2: Type: text/html, Size: 1968 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-28 15:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-28 11:51 [PATCH v2] drm/bridge: anx7625: Fix power on delay Hsin-Yi Wang
2021-04-28 15:46 ` Robert Foss

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).