From: Vinay Simha B N <simhavcs@gmail.com>
To: Jiri Vanek <jirivanek1@gmail.com>
Cc: Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
Robert Foss <robert.foss@linaro.org>,
"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
Neil Armstrong <narmstrong@baylibre.com>,
open list <linux-kernel@vger.kernel.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Andrzej Hajda <a.hajda@samsung.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v2] drm/bridge/tc358775: Fix for dual-link LVDS
Date: Fri, 7 Jan 2022 00:52:08 +0530 [thread overview]
Message-ID: <CAGWqDJ6T6EGNjoc2qfNHLMdcuwcnJArF7a7sToRXJ90Zs57E_A@mail.gmail.com> (raw)
In-Reply-To: <20220106190027.1498-1-jirivanek1@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]
Reviewed-by: Vinay Simha BN <simhavcs@gmail.com>
Jiri Vanek,
Could you please share the part number or datasheet of the dual-link LVDS
display/panel used.
On Fri, Jan 7, 2022 at 12:30 AM Jiri Vanek <jirivanek1@gmail.com> wrote:
> Fixed wrong register shift for single/dual link LVDS output.
>
> Tested-by: Jiri Vanek <jirivanek1@gmail.com>
> Signed-off-by: Jiri Vanek <jirivanek1@gmail.com>
>
> ---
> v1:
> * Initial version
>
> v2:
> * Tested-by tag added
>
> ---
> drivers/gpu/drm/bridge/tc358775.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/tc358775.c
> b/drivers/gpu/drm/bridge/tc358775.c
> index 2272adcc5b4a..1d6ec1baeff2 100644
> --- a/drivers/gpu/drm/bridge/tc358775.c
> +++ b/drivers/gpu/drm/bridge/tc358775.c
> @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val)
> }
>
> #define TC358775_LVCFG_LVDLINK__MASK 0x00000002
> -#define TC358775_LVCFG_LVDLINK__SHIFT 0
> +#define TC358775_LVCFG_LVDLINK__SHIFT 1
> static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val)
> {
> return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) &
> --
> 2.30.2
>
>
--
regards,
vinaysimha
[-- Attachment #2: Type: text/html, Size: 1966 bytes --]
next prev parent reply other threads:[~2022-01-07 8:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 22:00 [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS Jiri Vanek
2021-11-18 14:50 ` Robert Foss
2021-12-14 8:13 ` Vinay Simha B N
2022-01-04 13:50 ` Robert Foss
2022-01-04 14:29 ` Jiří Vaněk
2022-01-04 14:36 ` Robert Foss
2022-01-04 17:04 ` Vinay Simha B N
2022-01-04 16:56 ` Vinay Simha B N
2022-01-04 17:09 ` Robert Foss
2022-01-06 19:00 ` [PATCH v2] " Jiri Vanek
2022-01-06 19:22 ` Vinay Simha B N [this message]
2022-01-07 16:39 ` Robert Foss
2022-01-26 21:41 ` Jiří Vaněk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGWqDJ6T6EGNjoc2qfNHLMdcuwcnJArF7a7sToRXJ90Zs57E_A@mail.gmail.com \
--to=simhavcs@gmail.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jirivanek1@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=robert.foss@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).