* [PATCH] drm/mediatek: dsi: Add atomic {destroy, duplicate}_state, reset callbacks
@ 2022-07-21 17:27 AngeloGioacchino Del Regno
2022-07-25 6:46 ` Chen-Yu Tsai
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-07-21 17:27 UTC (permalink / raw)
To: chunkuang.hu
Cc: jitao.shi, airlied, linux-kernel, dri-devel, rex-bc.chen,
linux-mediatek, matthias.bgg, AngeloGioacchino Del Regno,
linux-arm-kernel, xinlei.lee
Add callbacks for atomic_destroy_state, atomic_duplicate_state and
atomic_reset to restore functionality of the DSI driver: this solves
vblank timeouts when another bridge is present in the chain.
Tested bridge chain: DSI <=> ANX7625 => aux-bus panel
Fixes: 7f6335c6a258 ("drm/mediatek: Modify dsi funcs to atomic operations")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
Note: The commit that has been mentioned in the Fixes tag should
*not* have my Reviewed-by tag, as the author changed it but
erroneously retained the tag that I had released for an
earlier version of that commit (which was fine, but the new
version broke mtk_dsi!).
drivers/gpu/drm/mediatek/mtk_dsi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
index 9cc406e1eee1..5b624e0f5b0a 100644
--- a/drivers/gpu/drm/mediatek/mtk_dsi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
@@ -808,10 +808,13 @@ static void mtk_dsi_bridge_atomic_post_disable(struct drm_bridge *bridge,
static const struct drm_bridge_funcs mtk_dsi_bridge_funcs = {
.attach = mtk_dsi_bridge_attach,
+ .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
.atomic_disable = mtk_dsi_bridge_atomic_disable,
+ .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,
.atomic_enable = mtk_dsi_bridge_atomic_enable,
.atomic_pre_enable = mtk_dsi_bridge_atomic_pre_enable,
.atomic_post_disable = mtk_dsi_bridge_atomic_post_disable,
+ .atomic_reset = drm_atomic_helper_bridge_reset,
.mode_set = mtk_dsi_bridge_mode_set,
};
--
2.35.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/mediatek: dsi: Add atomic {destroy, duplicate}_state, reset callbacks
2022-07-21 17:27 [PATCH] drm/mediatek: dsi: Add atomic {destroy, duplicate}_state, reset callbacks AngeloGioacchino Del Regno
@ 2022-07-25 6:46 ` Chen-Yu Tsai
2022-08-10 21:15 ` Nícolas F. R. A. Prado
2022-08-19 13:28 ` Chen-Yu Tsai
2 siblings, 0 replies; 5+ messages in thread
From: Chen-Yu Tsai @ 2022-07-25 6:46 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: chunkuang.hu, jitao.shi, xinlei.lee, airlied, linux-kernel,
dri-devel, matthias.bgg, linux-mediatek, rex-bc.chen,
linux-arm-kernel
On Fri, Jul 22, 2022 at 1:27 AM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
>
> Add callbacks for atomic_destroy_state, atomic_duplicate_state and
> atomic_reset to restore functionality of the DSI driver: this solves
> vblank timeouts when another bridge is present in the chain.
>
> Tested bridge chain: DSI <=> ANX7625 => aux-bus panel
>
> Fixes: 7f6335c6a258 ("drm/mediatek: Modify dsi funcs to atomic operations")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Tested-by: Chen-Yu Tsai <wenst@chromium.org>
on top of next-20220722 with additional DTSI changes for display related
device nodes [1] and modification to mt8192-asurada.dtsi to enable internal
display.
[1] https://lore.kernel.org/linux-mediatek/20220712114046.15574-1-allen-kh.cheng@mediatek.com/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/mediatek: dsi: Add atomic {destroy, duplicate}_state, reset callbacks
2022-07-21 17:27 [PATCH] drm/mediatek: dsi: Add atomic {destroy, duplicate}_state, reset callbacks AngeloGioacchino Del Regno
2022-07-25 6:46 ` Chen-Yu Tsai
@ 2022-08-10 21:15 ` Nícolas F. R. A. Prado
2022-08-19 13:28 ` Chen-Yu Tsai
2 siblings, 0 replies; 5+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-08-10 21:15 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: chunkuang.hu, jitao.shi, airlied, linux-kernel, dri-devel,
matthias.bgg, linux-mediatek, rex-bc.chen, linux-arm-kernel,
xinlei.lee
On Thu, Jul 21, 2022 at 07:27:27PM +0200, AngeloGioacchino Del Regno wrote:
> Add callbacks for atomic_destroy_state, atomic_duplicate_state and
> atomic_reset to restore functionality of the DSI driver: this solves
> vblank timeouts when another bridge is present in the chain.
>
> Tested bridge chain: DSI <=> ANX7625 => aux-bus panel
>
> Fixes: 7f6335c6a258 ("drm/mediatek: Modify dsi funcs to atomic operations")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Tested on mt8183-jacuzzi-juniper. As part of enabling IGT tests on that machine
in KernelCI, this regression needs to be fixed. [1]
Thanks,
Nícolas
[1] https://github.com/kernelci/kernelci-core/pull/1059
> ---
>
> Note: The commit that has been mentioned in the Fixes tag should
> *not* have my Reviewed-by tag, as the author changed it but
> erroneously retained the tag that I had released for an
> earlier version of that commit (which was fine, but the new
> version broke mtk_dsi!).
>
> drivers/gpu/drm/mediatek/mtk_dsi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 9cc406e1eee1..5b624e0f5b0a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -808,10 +808,13 @@ static void mtk_dsi_bridge_atomic_post_disable(struct drm_bridge *bridge,
>
> static const struct drm_bridge_funcs mtk_dsi_bridge_funcs = {
> .attach = mtk_dsi_bridge_attach,
> + .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
> .atomic_disable = mtk_dsi_bridge_atomic_disable,
> + .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,
> .atomic_enable = mtk_dsi_bridge_atomic_enable,
> .atomic_pre_enable = mtk_dsi_bridge_atomic_pre_enable,
> .atomic_post_disable = mtk_dsi_bridge_atomic_post_disable,
> + .atomic_reset = drm_atomic_helper_bridge_reset,
> .mode_set = mtk_dsi_bridge_mode_set,
> };
>
> --
> 2.35.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/mediatek: dsi: Add atomic {destroy, duplicate}_state, reset callbacks
2022-07-21 17:27 [PATCH] drm/mediatek: dsi: Add atomic {destroy, duplicate}_state, reset callbacks AngeloGioacchino Del Regno
2022-07-25 6:46 ` Chen-Yu Tsai
2022-08-10 21:15 ` Nícolas F. R. A. Prado
@ 2022-08-19 13:28 ` Chen-Yu Tsai
2022-08-25 15:01 ` Chun-Kuang Hu
2 siblings, 1 reply; 5+ messages in thread
From: Chen-Yu Tsai @ 2022-08-19 13:28 UTC (permalink / raw)
To: chunkuang.hu
Cc: jitao.shi, xinlei.lee, airlied, linux-kernel, dri-devel,
matthias.bgg, linux-mediatek, rex-bc.chen, linux-arm-kernel,
AngeloGioacchino Del Regno
On Fri, Jul 22, 2022 at 1:27 AM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
>
> Add callbacks for atomic_destroy_state, atomic_duplicate_state and
> atomic_reset to restore functionality of the DSI driver: this solves
> vblank timeouts when another bridge is present in the chain.
>
> Tested bridge chain: DSI <=> ANX7625 => aux-bus panel
>
> Fixes: 7f6335c6a258 ("drm/mediatek: Modify dsi funcs to atomic operations")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
This patch is now needed on top of v6.0-rc1, otherwise booting will
stall for a while waiting for display vblank, which never happens
because the DSI pipeline is not configured correctly.
ChenYu
> ---
>
> Note: The commit that has been mentioned in the Fixes tag should
> *not* have my Reviewed-by tag, as the author changed it but
> erroneously retained the tag that I had released for an
> earlier version of that commit (which was fine, but the new
> version broke mtk_dsi!).
>
> drivers/gpu/drm/mediatek/mtk_dsi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 9cc406e1eee1..5b624e0f5b0a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -808,10 +808,13 @@ static void mtk_dsi_bridge_atomic_post_disable(struct drm_bridge *bridge,
>
> static const struct drm_bridge_funcs mtk_dsi_bridge_funcs = {
> .attach = mtk_dsi_bridge_attach,
> + .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
> .atomic_disable = mtk_dsi_bridge_atomic_disable,
> + .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,
> .atomic_enable = mtk_dsi_bridge_atomic_enable,
> .atomic_pre_enable = mtk_dsi_bridge_atomic_pre_enable,
> .atomic_post_disable = mtk_dsi_bridge_atomic_post_disable,
> + .atomic_reset = drm_atomic_helper_bridge_reset,
> .mode_set = mtk_dsi_bridge_mode_set,
> };
>
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/mediatek: dsi: Add atomic {destroy, duplicate}_state, reset callbacks
2022-08-19 13:28 ` Chen-Yu Tsai
@ 2022-08-25 15:01 ` Chun-Kuang Hu
0 siblings, 0 replies; 5+ messages in thread
From: Chun-Kuang Hu @ 2022-08-25 15:01 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: Chun-Kuang Hu, Jitao Shi, xinlei.lee, David Airlie, linux-kernel,
DRI Development, Matthias Brugger,
moderated list:ARM/Mediatek SoC support, Rex-BC Chen, Linux ARM,
AngeloGioacchino Del Regno
Chen-Yu Tsai <wenst@chromium.org> 於 2022年8月19日 週五 晚上9:29寫道:
>
> On Fri, Jul 22, 2022 at 1:27 AM AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com> wrote:
> >
> > Add callbacks for atomic_destroy_state, atomic_duplicate_state and
> > atomic_reset to restore functionality of the DSI driver: this solves
> > vblank timeouts when another bridge is present in the chain.
> >
> > Tested bridge chain: DSI <=> ANX7625 => aux-bus panel
> >
Applied to mediatek-drm-fixes [1], thanks.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-fixes
Regards,
Chun-Kuang.
> > Fixes: 7f6335c6a258 ("drm/mediatek: Modify dsi funcs to atomic operations")
> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>
> This patch is now needed on top of v6.0-rc1, otherwise booting will
> stall for a while waiting for display vblank, which never happens
> because the DSI pipeline is not configured correctly.
>
> ChenYu
>
> > ---
> >
> > Note: The commit that has been mentioned in the Fixes tag should
> > *not* have my Reviewed-by tag, as the author changed it but
> > erroneously retained the tag that I had released for an
> > earlier version of that commit (which was fine, but the new
> > version broke mtk_dsi!).
> >
> > drivers/gpu/drm/mediatek/mtk_dsi.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> > index 9cc406e1eee1..5b624e0f5b0a 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> > @@ -808,10 +808,13 @@ static void mtk_dsi_bridge_atomic_post_disable(struct drm_bridge *bridge,
> >
> > static const struct drm_bridge_funcs mtk_dsi_bridge_funcs = {
> > .attach = mtk_dsi_bridge_attach,
> > + .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
> > .atomic_disable = mtk_dsi_bridge_atomic_disable,
> > + .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,
> > .atomic_enable = mtk_dsi_bridge_atomic_enable,
> > .atomic_pre_enable = mtk_dsi_bridge_atomic_pre_enable,
> > .atomic_post_disable = mtk_dsi_bridge_atomic_post_disable,
> > + .atomic_reset = drm_atomic_helper_bridge_reset,
> > .mode_set = mtk_dsi_bridge_mode_set,
> > };
> >
> > --
> > 2.35.1
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-08-25 15:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-21 17:27 [PATCH] drm/mediatek: dsi: Add atomic {destroy, duplicate}_state, reset callbacks AngeloGioacchino Del Regno
2022-07-25 6:46 ` Chen-Yu Tsai
2022-08-10 21:15 ` Nícolas F. R. A. Prado
2022-08-19 13:28 ` Chen-Yu Tsai
2022-08-25 15:01 ` Chun-Kuang Hu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).