From: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Oleksandr Suvorov <oleksandr.suvorov@toradex.com>,
David Airlie <airlied@linux.ie>,
Igor Opanyuk <igor.opanyuk@toradex.com>,
Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH 1/3] drm/panel: make LVDS panel driver DPI capable
Date: Mon, 20 Jan 2020 09:57:17 +0000 [thread overview]
Message-ID: <CAGgjyvHVg9OBWqpBd9k1hf561VjFQwh3o9QUFcy1A=_KNnK2Gg@mail.gmail.com> (raw)
In-Reply-To: <20200118130418.GA13417@ravnborg.org>
Hi Sam,
On Sat, Jan 18, 2020 at 3:04 PM Sam Ravnborg <sam@ravnborg.org> wrote:
> >
> > The LVDS panel driver has almost everything which is required to
> > describe a simple parallel RGB panel (also known as DPI, Display
> > Pixel Interface).
> >
> > ---
>
> There are a few high-level things we need to have sorted out.
>
> The driver, when this patch is added, assumes that certain properties
> are now mandatory when using the panel-dpi compatible.
> - data-mapping
> - width-mm
> - height-mm
> - panel-timing
>
> But this does not match the panel-dpi binding.
> So we need the panel-dpi binding updated first.
>
>
> The current driver specify the connector type in drm_panel_init().
> But a DPI panel is assumed to use a DRM_MODE_CONNECTOR_DPI,
> and not a DRM_MODE_CONNECTOR_LVDS.
> So the drm_panel_init() call needs to take into account the type
> of binding.
>
Thanks, I'll fix it in 2nd version.
>
> > @@ -257,7 +279,7 @@ static struct platform_driver panel_lvds_driver = {
> > .probe = panel_lvds_probe,
> > .remove = panel_lvds_remove,
> > .driver = {
> > - .name = "panel-lvds",
> > + .name = "panel-generic",
>
> I think changing the name of the driver like this is an UAPI change,
> which is not OK
I see 2 simple ways there:
- keep the original platform driver name;
- fork panel-lvds driver as panel-generic driver with dpi support.
What solution do you prefer?
> > .of_match_table = panel_lvds_of_table,
> > },
> > };
>
> Sam
--
Best regards
Oleksandr Suvorov
Toradex AG
Altsagenstrasse 5 | 6048 Horw/Luzern | Switzerland | T: +41 41 500
4800 (main line)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-01-20 17:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 12:34 [PATCH 0/3] Generic DPI panel on Colibri iMX7 / Col.Eval.board Oleksandr Suvorov
2020-01-15 12:34 ` [PATCH 1/3] drm/panel: make LVDS panel driver DPI capable Oleksandr Suvorov
2020-01-18 13:04 ` Sam Ravnborg
2020-01-20 9:57 ` Oleksandr Suvorov [this message]
2020-01-20 20:20 ` Sam Ravnborg
2020-01-15 12:34 ` [PATCH 2/3] drm/panel: pass video modes bus_flags Oleksandr Suvorov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGgjyvHVg9OBWqpBd9k1hf561VjFQwh3o9QUFcy1A=_KNnK2Gg@mail.gmail.com' \
--to=oleksandr.suvorov@toradex.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=igor.opanyuk@toradex.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).