From: Adam Ford <aford173@gmail.com>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
devicetree <devicetree@vger.kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
NXP Linux Team <linux-imx@nxp.com>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
Kyungmin Park <kyungmin.park@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Robert Foss <robert.foss@linaro.org>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Fancy Fang <chen.fang@nxp.com>,
Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
linux-amarula <linux-amarula@amarulasolutions.com>,
arm-soc <linux-arm-kernel@lists.infradead.org>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 04/11] drm: bridge: samsung-dsim: Add DSI init in bridge pre_enable()
Date: Mon, 11 Apr 2022 07:23:06 -0500 [thread overview]
Message-ID: <CAHCN7xJmiEBsbZRepsM0FLd8YDSQj8GUwwyYm4M_ViJFPoU8FQ@mail.gmail.com> (raw)
In-Reply-To: <20220408162108.184583-5-jagan@amarulasolutions.com>
On Fri, Apr 8, 2022 at 11:22 AM Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> Host transfer() in DSI master will invoke only when the DSI commands
> are sent from DSI devices like DSI Panel or DSI bridges and this
> host transfer wouldn't invoke for I2C-based-DSI bridge drivers.
>
> Handling DSI host initialization in transfer calls misses the
> controller setup for I2C configured DSI bridges.
>
> This patch adds the DSI initialization from transfer to bridge
> pre_enable as the bridge pre_enable API is invoked by core as
> it is common across all classes of DSI device drivers.
>
> v1:
> * keep DSI init in host transfer
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> drivers/gpu/drm/bridge/samsung-dsim.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
> index ff05c8e01cff..3e12b469dfa8 100644
> --- a/drivers/gpu/drm/bridge/samsung-dsim.c
> +++ b/drivers/gpu/drm/bridge/samsung-dsim.c
> @@ -1290,6 +1290,13 @@ static void samsung_dsim_atomic_pre_enable(struct drm_bridge *bridge,
> }
>
> dsi->state |= DSIM_STATE_ENABLED;
> +
> + if (!(dsi->state & DSIM_STATE_INITIALIZED)) {
> + ret = samsung_dsim_init(dsi);
> + if (ret)
> + return;
> + dsi->state |= DSIM_STATE_INITIALIZED;
Out of curiosity, is there a reason that dsi->state cannot add
DSIM_STATE_INITIALIZED inside the samsung_dsim_init function call? It
seems to me that if samsung_dsim_init returns successfully, it should
set that flag. I don't know if it's called from other places or not.
adam
> + }
> }
>
> static void samsung_dsim_atomic_enable(struct drm_bridge *bridge,
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-04-11 12:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220408162213eucas1p158d7c7ee27006a61d4af95d3c72c58e3@eucas1p1.samsung.com>
2022-04-08 16:20 ` [PATCH 00/11] drm: bridge: Add Samsung MIPI DSIM bridge Jagan Teki
2022-04-08 16:20 ` [PATCH 01/11] drm: bridge: Add Samsung DSIM bridge driver Jagan Teki
2022-04-12 9:45 ` Marek Szyprowski
2022-05-04 9:16 ` Jagan Teki
2022-05-04 9:44 ` Marek Szyprowski
2022-04-08 16:20 ` [PATCH 02/11] drm: bridge: samsung-dsim: Handle platform init via driver_data Jagan Teki
2022-04-12 9:55 ` Marek Szyprowski
2022-04-08 16:21 ` [PATCH 03/11] drm: bridge: samsung-dsim: Mark PHY as optional Jagan Teki
2022-04-08 16:21 ` [PATCH 04/11] drm: bridge: samsung-dsim: Add DSI init in bridge pre_enable() Jagan Teki
2022-04-11 12:23 ` Adam Ford [this message]
2022-04-08 16:21 ` [PATCH 05/11] drm: bridge: samsung-dsim: Fix PLL_P (PMS_P) offset Jagan Teki
2022-04-08 16:21 ` [PATCH 06/11] drm: bridge: samsung-dsim: Add module init, exit Jagan Teki
2022-04-08 16:21 ` [PATCH 07/11] drm: bridge: samsung-dsim: Add atomic_check Jagan Teki
2022-04-08 16:21 ` [PATCH 08/11] drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts Jagan Teki
2022-04-08 16:21 ` [PATCH 09/11] drm: bridge: samsung-dsim: Add input_bus_flags Jagan Teki
2022-04-08 16:21 ` [PATCH 10/11] dt-bindings: display: exynos: dsim: Add NXP i.MX8MM support Jagan Teki
2022-04-10 18:12 ` Laurent Pinchart
2022-04-29 9:40 ` Jagan Teki
2022-04-08 16:21 ` [PATCH 11/11] drm: bridge: samsung-dsim: Add " Jagan Teki
2022-04-10 18:06 ` Laurent Pinchart
2022-04-09 0:25 ` [PATCH 00/11] drm: bridge: Add Samsung MIPI DSIM bridge Tim Harvey
2022-04-11 13:11 ` (EXT) " Alexander Stein
2022-04-11 13:56 ` Marek Szyprowski
2022-04-11 14:39 ` Adam Ford
2022-04-11 15:29 ` Adam Ford
2022-04-11 16:25 ` Marek Szyprowski
2022-04-11 20:26 ` Adam Ford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHCN7xJmiEBsbZRepsM0FLd8YDSQj8GUwwyYm4M_ViJFPoU8FQ@mail.gmail.com \
--to=aford173@gmail.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=andrzej.hajda@intel.com \
--cc=chen.fang@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frieder.schrempf@kontron.de \
--cc=jagan@amarulasolutions.com \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=michael@amarulasolutions.com \
--cc=narmstrong@baylibre.com \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).