From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3BDBBC433F5 for ; Mon, 11 Apr 2022 14:39:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A27B110EAA7; Mon, 11 Apr 2022 14:39:57 +0000 (UTC) Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by gabe.freedesktop.org (Postfix) with ESMTPS id 449F310EAA7 for ; Mon, 11 Apr 2022 14:39:56 +0000 (UTC) Received: by mail-ed1-x530.google.com with SMTP id t25so6039460edt.9 for ; Mon, 11 Apr 2022 07:39:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RGN9dUJYj47JXi0a+41k06MGWJnJyWFM/qMvB07kZsg=; b=VxSsL0wEXbboLeOf2wmpHxXFgzdjwQ2liqKeQ0Wa8wPsAjiLD/84l8L8pNF/DdFI/P nEYEQgVyTR4y+ZFDUa7G7+w1548IZWDT6rfrXZiv6VC5kPRXRvqkqzBuntY0f45Mz8nr W8jV7goLTKnn2d9vYhj7DN1a6bxAMbkAFYfn+yNbCTDK8rwifQf0oKDBuj+sZoHEq59H pWHO+IyqQWm9MJ+WPQx75yGSCc42GEo3yPgQ6Dcm1GDOdz7WgUI5n0i9CodaajRSUaFJ PAduKSisg7qEozDjtk96LGac/tNitPOejdAFJAxgwlJ9WYQUST8JtCCbJnGgGbBjdzjD U+lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RGN9dUJYj47JXi0a+41k06MGWJnJyWFM/qMvB07kZsg=; b=mhBemjqEkKzSmcRHVS1WZ0sX/k0ct6uyak1+tfgRec8o/MiSA4RHtReu1UvyjdpixN 0/0+1o2lrxCZ8v7kR1QA3tO84AfMnwkJ2gy3i919FYCP8F7VttBbmx7T+TbXKQK1oo/3 /HGwIZMGVPvIgSdBwpB6iibkiyxhBY3EJkNkxTQw8NGU5XMcKN1M6LoCQHsaagNIRidM VcrHARxUyqgvsLXLfXfC/OguwS70m+ZEPVLYF5QmeCt41yuCe5Xe1g7Elf2hkziLfInc tKIjkLJO5LgOp2u+ZPnlv9jhSzbanlxDEfjlndlyyzI5STVLt9RgejjwRq/UZREx7r6C 1guA== X-Gm-Message-State: AOAM530OF2+d5lOo74tz4SyggPf4UCmvLZX6AvqC5opMX3POCKMk7RvA BNr28GrMxvLJj3opKpGT5BXajoQxfQsZma0qizQ= X-Google-Smtp-Source: ABdhPJwwgcOrCgzva5OHLdgmGhUkVRkz1EOhBjroc03r3EyT8eRz+X7v727q27f23vS1qHhjpn/8fDRQ0xyrx+vrUSs= X-Received: by 2002:a05:6402:2142:b0:413:6531:bd9e with SMTP id bq2-20020a056402214200b004136531bd9emr33389701edb.5.1649687994494; Mon, 11 Apr 2022 07:39:54 -0700 (PDT) MIME-Version: 1.0 References: <20220408162108.184583-1-jagan@amarulasolutions.com> <4c693c6e-512b-a568-948a-4a1af6a1313a@samsung.com> In-Reply-To: <4c693c6e-512b-a568-948a-4a1af6a1313a@samsung.com> From: Adam Ford Date: Mon, 11 Apr 2022 09:39:43 -0500 Message-ID: Subject: Re: [PATCH 00/11] drm: bridge: Add Samsung MIPI DSIM bridge To: Marek Szyprowski Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel , devicetree , linux-samsung-soc , Joonyoung Shim , Neil Armstrong , Robert Foss , Seung-Woo Kim , NXP Linux Team , Frieder Schrempf , Kyungmin Park , Rob Herring , Jagan Teki , Andrzej Hajda , Fancy Fang , Michael Nazzareno Trimarchi , linux-amarula , arm-soc , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Apr 11, 2022 at 8:56 AM Marek Szyprowski wrote: > > On 08.04.2022 18:20, Jagan Teki wrote: > > This series supports common bridge support for Samsung MIPI DSIM > > which is used in Exynos and i.MX8MM SoC's. > > > > Previous RFC can be available here [1]. > > > > The final bridge supports both the Exynos and i.MX8MM DSI devices. > > > > On, summary this patch-set break the entire DSIM driver into > > - platform specific glue code for platform ops, component_ops. > > - common bridge driver which handle platform glue init and invoke. > > > > Patch 0000: Samsung DSIM bridge > > > > Patch 0001: platform init flag via driver_data > > > > Patch 0002/9: bridge fixes, atomic API's > > > > Patch 0010: document fsl,imx8mm-mipi-dsim > > > > Patch 0011: add i.MX8MM DSIM support > > > > Tested in Engicam i.Core MX8M Mini SoM. > > > > Anyone interested, please have a look on this repo [2] > > > > [2] https://protect2.fireeye.com/v1/url?k=930e329a-f28527b5-930fb9d5-74fe485cbfe7-b0c53e2d688ddbc5&q=1&e=e6aa727d-5ae2-4ca5-bff3-7f62d8fae87e&u=https%3A%2F%2Fgithub.com%2Fopenedev%2Fkernel%2Ftree%2Fimx8mm-dsi-v1 > > [1] https://lore.kernel.org/linux-arm-kernel/YP2j9k5SrZ2%2Fo2%2F5@ravnborg.org/T/ > > > > Any inputs? > > I wanted to test this on the Exynos, but I wasn't able to find what base > should I apply this patchset. I've tried linux-next as well as > 95a2441e4347 ("drm: exynos: dsi: Switch to atomic funcs"). > > Please note that pointing a proper base for the patchset is really > essential if you really want others to test it. Can you clone his repo and test that? He posted it above. I was going to clone it at some point this week to give it a try. adam > > > > Jagan. > > > > Jagan Teki (11): > > drm: bridge: Add Samsung DSIM bridge driver > > drm: bridge: samsung-dsim: Handle platform init via driver_data > > drm: bridge: samsung-dsim: Mark PHY as optional > > drm: bridge: samsung-dsim: Add DSI init in bridge pre_enable() > > drm: bridge: samsung-dsim: Fix PLL_P (PMS_P) offset > > drm: bridge: samsung-dsim: Add module init, exit > > drm: bridge: samsung-dsim: Add atomic_check > > drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts > > drm: bridge: samsung-dsim: Add input_bus_flags > > dt-bindings: display: exynos: dsim: Add NXP i.MX8MM support > > drm: bridge: samsung-dsim: Add i.MX8MM support > > > > .../bindings/display/exynos/exynos_dsim.txt | 1 + > > MAINTAINERS | 12 + > > drivers/gpu/drm/bridge/Kconfig | 12 + > > drivers/gpu/drm/bridge/Makefile | 1 + > > drivers/gpu/drm/bridge/samsung-dsim.c | 1803 +++++++++++++++++ > > drivers/gpu/drm/exynos/Kconfig | 1 + > > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1704 +--------------- > > include/drm/bridge/samsung-dsim.h | 97 + > > 8 files changed, 1982 insertions(+), 1649 deletions(-) > > create mode 100644 drivers/gpu/drm/bridge/samsung-dsim.c > > create mode 100644 include/drm/bridge/samsung-dsim.h > > > Best regards > -- > Marek Szyprowski, PhD > Samsung R&D Institute Poland >