dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Andrew Morton <akpm@osdl.org>, Petr Mladek <pmladek@suse.com>,
	wangkefeng.wang@huawei.com,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Zhang Xiaoxu <zhangxiaoxu5@huawei.com>,
	linux-fbdev@vger.kernel.org,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [v4] vgacon: Fix a UAF in vgacon_invert_region
Date: Fri, 6 Mar 2020 06:55:05 -0600	[thread overview]
Message-ID: <CAHk-=wgA7wCXf2s+ihRopi7dzfzc7hWQ0jGiQiV8vMW-XVdD-A@mail.gmail.com> (raw)
In-Reply-To: <20200306103846.GS2363188@phenom.ffwll.local>

On Fri, Mar 6, 2020 at 4:38 AM Daniel Vetter <daniel@ffwll.ch> wrote:
>
> Linus, since this missed the -fixes pull from Dave maybe double check I'm
> not grossly wrong here and apply directly?

Hmm. I don't have the original email, mind just sending it to me (with
the proper added sign-off chain)?

It does strike me that there's nothing that seems to check for
overflow in the "(width << 1) * height" calculation. Hmm?

            Linus
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-03-06 12:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04  2:24 [v4] vgacon: Fix a UAF in vgacon_invert_region Zhang Xiaoxu
2020-03-06 10:38 ` Daniel Vetter
2020-03-06 12:55   ` Linus Torvalds [this message]
2020-03-06 13:12     ` Daniel Vetter
2020-03-06 13:24       ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wgA7wCXf2s+ihRopi7dzfzc7hWQ0jGiQiV8vMW-XVdD-A@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=akpm@osdl.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=wangkefeng.wang@huawei.com \
    --cc=zhangxiaoxu5@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).