From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75D46C433DF for ; Fri, 29 May 2020 01:49:36 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43BB320723 for ; Fri, 29 May 2020 01:49:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="OQI7g/LZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43BB320723 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C03D26E852; Fri, 29 May 2020 01:49:34 +0000 (UTC) Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 74CE76E852 for ; Fri, 29 May 2020 01:49:33 +0000 (UTC) Received: by mail-lj1-x243.google.com with SMTP id c11so617372ljn.2 for ; Thu, 28 May 2020 18:49:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KkwZFdug2ibfipHp51Hdh/MIpXAxoqnCWV3ptE8ypxM=; b=OQI7g/LZthfupWZGTaaD31P84Kb9G8XBQLwp0DDsDWA2HzBFoyGDMu31FtMKA9ET7J dDPGe9+x7OgAmQSeGW4sGXMu3sEUp7l35dkDgmSjURvllTM1xUIqeoN9hVSBQG1UpRgQ ta7w4tJ7XCis8TtVKRq2VSK4+I12I3r45wSLc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KkwZFdug2ibfipHp51Hdh/MIpXAxoqnCWV3ptE8ypxM=; b=KOS+XoaKm2QaEZGSeOEbPKhFLs4Enyw9MpyyhI2kDHuUQMCBcEHYnD66ZbsZJvGaH7 o0tXjl+O90mPG1l4fwvvBPs29FkMZBPw1ycJ/KEQJmScX60JJdMW798Djf+BY2zt5qnK WoLiMN6ewezTaMroy3+Y4ihVuTlRYr4UKtHrBbWYC5oGsAQpY7YQb19bG3wt+0LtKkD+ Jtl1JrIT763HT1ujoaXf9pd7CvCIyG8s9kGHMtRVfrj/7ejAd95m8CwDn9/SFQC7Ee2P nXy2xGe8WT+iiHdlWA6mzpF0K/x17f6OWiqvScbGn6yFSqwhu/RvD/uLz5jeVqs0w2Nl Bsug== X-Gm-Message-State: AOAM533Z/M7iTxGslPWWaOQKZV0BhznW9jPvfvitp4tEtY+DD0b7iMVJ G6ZhbPZ4lKpwUI2afyGOgmxWKQQOxrE= X-Google-Smtp-Source: ABdhPJzBQxo43NBTYKe2zBtADRnlh7yNPfOlZJeMChTalyLJIbmIKTiHBqiJzwWEFpvf6Y+UHG3Nbg== X-Received: by 2002:a2e:8e78:: with SMTP id t24mr3115187ljk.444.1590716971198; Thu, 28 May 2020 18:49:31 -0700 (PDT) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com. [209.85.167.53]) by smtp.gmail.com with ESMTPSA id w144sm1950643lff.67.2020.05.28.18.49.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 May 2020 18:49:30 -0700 (PDT) Received: by mail-lf1-f53.google.com with SMTP id d7so307598lfi.12 for ; Thu, 28 May 2020 18:49:30 -0700 (PDT) X-Received: by 2002:ac2:5a4c:: with SMTP id r12mr3133948lfn.10.1590716969967; Thu, 28 May 2020 18:49:29 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Thu, 28 May 2020 18:49:14 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [git pull] drm fixes for 5.7-rc8/final To: Dave Airlie , Chris Wilson , Rodrigo Vivi X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , LKML , dri-devel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, May 28, 2020 at 5:21 PM Dave Airlie wrote: > > Seems to have wound down nicely, a couple of i915 fixes, amdgpu fixes > and minor ingenic fixes. Dave, this doesn't even build. WTF? In drivers/gpu/drm/i915/gt/selftest_lrc.c, there's a engine_heartbeat_disable() function that takes two arguments, but the new "live_timeslice_nopreempt()" gives it only one. I'd blame a merge problem, since the failure is in new code, but the problem exists in your top-of-tree, not just my merge. In fact, it's not even your merge of the i915 tree that is the source of the problem (although the fact that you clearly didn't _test_ the end result most definitely is _part_ of the problem!). Because the problem exists in the commit that introduced that thing: commit 1f65efb624c4 ("drm/i915/gt: Prevent timeslicing into unpreemptable requests"). It's garbage, and never compiled. See here: git grep -1wh engine_heartbeat_disable 1f65efb62 \ drivers/gpu/drm/i915/gt/selftest_lrc.c and you'll see how the definition of that function looks like this: static void engine_heartbeat_disable(struct intel_engine_cs *engine, unsigned long *saved) but then in the middle of that grep, you'll find engine_heartbeat_disable(engine); WTF? That commit seems to be a cherry-pick of another commit, and maybe it worked in that other context (which I don't see), but it sure doesn't work in the context it was then cherry-picked into. So people took that thing, and it went through at least two different people WHO NEVER EVEN BOTHERED TO TEST IF IT BUILDS! Christ, people. This is why I absolutely DO NOT WANT TO SEE random rebases or cherry-picks and then sending the resulting untested crap on to me. Because it's exactly that: untested crap. It doesn't matter *how* well you have tested a commit in some original context: the moment you rebase it (or cherry-pick it, which is just another form of rebasing), it's a completely new commit in a completely new environment, and all your old testing is null and void. Guys, get your act together! I should not be getting these kinds of shit pull requests days before a release! And how the hell did this not get any build testing at any point before asking me to pull? Linus _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel