From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0A18C433ED for ; Fri, 14 May 2021 17:30:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A0BC561183 for ; Fri, 14 May 2021 17:30:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A0BC561183 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DD3E56F3BE; Fri, 14 May 2021 17:30:06 +0000 (UTC) Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by gabe.freedesktop.org (Postfix) with ESMTPS id B77096F3BE for ; Fri, 14 May 2021 17:30:05 +0000 (UTC) Received: by mail-lj1-x233.google.com with SMTP id w15so38705533ljo.10 for ; Fri, 14 May 2021 10:30:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1gCT3yFXN0nq6W0TvPfJDEC6ju7ngwBrbZ3V/R/ZJt4=; b=QrDM1vyn65+P14zzNE8NIxADOjzkXwgZ1OVSKlrR4yWXq5tE46/SGHEAy800t0p0KD 09lTLzF24eD7OUZIM3qJyL3BYanjfr/ddscyzFIcuOxS77RMISzoNAQdTSU8ej9mIAeW QqV6REiHKfhF0o2ztdoumCpotG6fc5BTXat8Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1gCT3yFXN0nq6W0TvPfJDEC6ju7ngwBrbZ3V/R/ZJt4=; b=GVx5ryIJPlaJ34tVYrtFch/uE2ZZf2WxDrWD/tOp8OO3fAnaJfhnweyCJAc4deP0BI WkpSzyxK30Xyzrz0GOmk1OT1dIiSG5T2CurvRgbMxo7ydjvi7Je94wgd6BY1o1Nziyxp wbJLjH9o0fL53oEBEz5pLK4Ss0ynw8Rs2FZdlFGtkMZO0lLr9GvBwi30QlPaZjjV8ENV sqcaDih0rI+0qXIj2i6gpU0JHGSm4uG+kVJaxMNNUTIhRwVPDv7VK/0wpuxd6l+R612q ZbaqdqQo/uMxaMDtjbHUrP5Xl377OJXNRt7xvWoJfUFCYlh97kSPvN8I3KddHfTm0o1u LAcw== X-Gm-Message-State: AOAM530LG2kPyhMrIcTDJqMObi+qCp4xyfAhzZDDLIlZoZSe9ck6gUWW IALF29o55Q7lvBK6x3tRgPRZUrRrJiSEtVwD X-Google-Smtp-Source: ABdhPJxuCw7luyNb0Fgc2dz5BChHBIL3KXP5tY1U3chmj4Q2xm8tQzzXX3l4b4zSWDA62ydIOhyl2Q== X-Received: by 2002:a2e:b0e5:: with SMTP id h5mr35322831ljl.453.1621013403742; Fri, 14 May 2021 10:30:03 -0700 (PDT) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com. [209.85.167.51]) by smtp.gmail.com with ESMTPSA id m5sm1274329ljc.120.2021.05.14.10.30.02 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 May 2021 10:30:03 -0700 (PDT) Received: by mail-lf1-f51.google.com with SMTP id j10so44079952lfb.12 for ; Fri, 14 May 2021 10:30:02 -0700 (PDT) X-Received: by 2002:ac2:4a9d:: with SMTP id l29mr270413lfp.201.1621013402775; Fri, 14 May 2021 10:30:02 -0700 (PDT) MIME-Version: 1.0 References: <0000000000006bbd0c05c14f1b09@google.com> <6e21483c-06f6-404b-4018-e00ee85c456c@i-love.sakura.ne.jp> <87d928e4-b2b9-ad30-f3f0-1dfb8e4e03ed@i-love.sakura.ne.jp> <05acdda8-dc1c-5119-4326-96eed24bea0c@i-love.sakura.ne.jp> In-Reply-To: <05acdda8-dc1c-5119-4326-96eed24bea0c@i-love.sakura.ne.jp> From: Linus Torvalds Date: Fri, 14 May 2021 10:29:47 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] video: fbdev: vga16fb: fix OOB write in vga16fb_imageblit() To: Tetsuo Handa Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux Fbdev development list , Bartlomiej Zolnierkiewicz , Jani Nikula , Greg Kroah-Hartman , syzkaller-bugs , Linux Kernel Mailing List , dri-devel , Colin King , Jiri Slaby , syzbot , "Maciej W. Rozycki" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, May 14, 2021 at 9:20 AM Tetsuo Handa wrote: > > Currently it is impossible to control upper limit of rows/columns values > based on amount of memory reserved for the graphical screen, for > resize_screen() calls vc->vc_sw->con_resize() only if vc->vc_mode is not > already KD_GRAPHICS Honestly, the saner approach would seem to be to simply error out if vc_mode is KD_GRAPHICS. Doing VT_RESIZE while in KD_GRAPHICS mode seems _very_ questionable, and is clearly currently very buggy. So why not just say "that clearly already doesn't work, so make it explicitly not permitted"? Linus