From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F383C433FE for ; Thu, 6 Oct 2022 23:48:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9B90F10E8E2; Thu, 6 Oct 2022 23:48:37 +0000 (UTC) Received: from mail-oa1-x36.google.com (mail-oa1-x36.google.com [IPv6:2001:4860:4864:20::36]) by gabe.freedesktop.org (Postfix) with ESMTPS id C1E6410E8E2 for ; Thu, 6 Oct 2022 23:48:34 +0000 (UTC) Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-132fb4fd495so3941855fac.12 for ; Thu, 06 Oct 2022 16:48:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=pJMiQ46/KiBnfg6+facy6y32ur475qAL7V2FIVVnoOc=; b=H1uJFisEq86b1igTJeZ3icitP5usONcBgntp3Bmdfd7L7c+PbhZBFOBQP0sdQg07ow qxLoPLeON8LDcpeAyeJpP8HIJaym87ZqEiNnbYwcA07TYw/IVxsX/YQ5VYNjq29zKAWi PPHD1nPoH08WKswGp2QF09NZBEnNJqKOysIbU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pJMiQ46/KiBnfg6+facy6y32ur475qAL7V2FIVVnoOc=; b=zu3xve6Eu7abFRY0ztMh4gVdZ3d9BHRLTDumPouZhvhFe+Xe5uwORy2rd+00n3G7f1 XRWzKKVyLToVSuGod4Y9YDk95aXC7V5ffTRB7FBHcu3yYi+5K5Fc3LkaUtT86osFXPVY mzeB2dW+lcgHRn6D4EqqpshRgbJdZzdYguMu1ywISM4s0M5vOspAAv6iJVQYhZdCjlwL ELmZr6JfrDO4DaJlo+zGewGpfUb79MYS2H/NFhqjoocIRmXOuAvkl2tayDpuNBjtBDdM moqRCsEU0RFjXFVKNIi+pjslDYMWyxnMKI93ix5ALqB2Xrfxusbn2G0kSwu9ZWC9RNPe 465w== X-Gm-Message-State: ACrzQf0hLFPoNeepMP1GCsnGJqyqX6mIf0nApwAIanxmrxGPKxjuN9IC HVVq5TYIx3/n+uH3dF3Vg5indmgBKDivIA== X-Google-Smtp-Source: AMsMyM7nzLQX/V8D0IGnOJHC9JIKPrFXOnNvg88z9ZO3B/sKa6lBpYoXSHshDXgbMyHy2hVunKUEiw== X-Received: by 2002:a05:6870:ac2b:b0:132:f761:8f4c with SMTP id kw43-20020a056870ac2b00b00132f7618f4cmr4052535oab.17.1665100113429; Thu, 06 Oct 2022 16:48:33 -0700 (PDT) Received: from mail-oo1-f44.google.com (mail-oo1-f44.google.com. [209.85.161.44]) by smtp.gmail.com with ESMTPSA id p18-20020a4a95d2000000b0047f72b6988fsm223702ooi.45.2022.10.06.16.48.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Oct 2022 16:48:29 -0700 (PDT) Received: by mail-oo1-f44.google.com with SMTP id m11-20020a4aab8b000000b00476743c0743so2476788oon.10 for ; Thu, 06 Oct 2022 16:48:29 -0700 (PDT) X-Received: by 2002:a05:6830:611:b0:65c:26ce:5dc with SMTP id w17-20020a056830061100b0065c26ce05dcmr1007394oti.176.1665100109301; Thu, 06 Oct 2022 16:48:29 -0700 (PDT) MIME-Version: 1.0 References: <202210061328.37FCC30@keescook> In-Reply-To: From: Linus Torvalds Date: Thu, 6 Oct 2022 16:48:13 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: mainline build failure due to 5d8c3e836fc2 ("drm/amd/display: fix array-bounds error in dc_stream_remove_writeback()") To: Sudip Mukherjee Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kees Cook , Leo Li , dri-devel@lists.freedesktop.org, "Pan, Xinhui" , Rodrigo Siqueira , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Nathan Chancellor , Hamza Mahfooz , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Oct 6, 2022 at 1:50 PM Sudip Mukherjee wrote: > > > And it looks like Sudip's proposed fix for this particular code is > > additionally fixing unsigned vs signed as well. I think -Warray-bounds > > did its job (though, with quite a confusing index range in the report). > > Not my. Linus's. I just tested. :) I suspect Kees meant Stephen's other patch that Hamza pointed at, and that is perhaps the cleaner version. That said, I hate how this forces us to write random code changes just to make a compiler just randomly _happen_ to not complain about it. Linus