From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3963C433B4 for ; Wed, 28 Apr 2021 22:22:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5BA5861423 for ; Wed, 28 Apr 2021 22:22:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BA5861423 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B36D76ECFD; Wed, 28 Apr 2021 22:22:18 +0000 (UTC) Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by gabe.freedesktop.org (Postfix) with ESMTPS id C97C96ECFD for ; Wed, 28 Apr 2021 22:22:16 +0000 (UTC) Received: by mail-lf1-x134.google.com with SMTP id 4so41813655lfp.11 for ; Wed, 28 Apr 2021 15:22:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8rY2O6I8V9olhtWB9b4/RtsHeRlI9151ci1isDXaebA=; b=D+vRDauZOJdt3mAK066Dxx+uj5KyRs+qmiKOMPZC9S/2G5C+tru2w9J4y2E8JNeasO +5HA2gsch9GyiZ783mgiJPhJ7Fh4Qwyh/TT5QHc/F5NDfPzNCp3R615E/jBxQxl0/kHd NxZkr4cC8HiIq4i8kmhALYx9My1iGo3NNacdw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8rY2O6I8V9olhtWB9b4/RtsHeRlI9151ci1isDXaebA=; b=KkCsfFJhys1KQb4WJOV+2wcscOCRGSeZTEnPvM8FdDRNErdfztm24XugkMDPlAoZxo EUXreiI9O85CIhF/wQ3CITyyeNej2rIpvqJt1XK7/G39vh3fVzOSBEpavM2RSk2fIq7x 7/nAkSIgb678JbLP8dDN0C7sOSxRqWy1Vqtyna9IfG4dSwU09Lk12KOAnQnEj46cg3KZ Nf6JOoW5Niz0nexKlOzf/AJhSlrpiwSRrtIXH2g6nUOB9eq5rpSpCGbKEI5SAHU0hFyZ 19fM3jwNWJ96QS6H+IST5c5Zc1t+geXtMzycH62Ge7yaeJtbOi8V+fJHM62YFb6K4ZBy ZVXA== X-Gm-Message-State: AOAM530gVscT0ZRZicuvr23FzUcalr9MAfRrfzCc2NT83IeSkiJs9er1 /dGNTy5IHIuXNeu8xib4MMFchmEo4pftAIfT X-Google-Smtp-Source: ABdhPJxxol6HftyxEOg28G5E9QNXbXexuKJJ1B1f4kW1LIIAKoK3082yStS9p7ZM77oGj5T15WhWoQ== X-Received: by 2002:a05:6512:2089:: with SMTP id t9mr22700869lfr.378.1619648535045; Wed, 28 Apr 2021 15:22:15 -0700 (PDT) Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com. [209.85.167.52]) by smtp.gmail.com with ESMTPSA id n7sm261404lft.65.2021.04.28.15.22.13 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Apr 2021 15:22:14 -0700 (PDT) Received: by mail-lf1-f52.google.com with SMTP id 2so8988634lft.4 for ; Wed, 28 Apr 2021 15:22:13 -0700 (PDT) X-Received: by 2002:ac2:5f97:: with SMTP id r23mr2129654lfe.377.1619648533751; Wed, 28 Apr 2021 15:22:13 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Wed, 28 Apr 2021 15:21:57 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [git pull] drm for 5.13-rc1 To: Dave Airlie , Mikita Lipski , Sun peng Li , Qingqing Zhuo , Alex Deucher X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , LKML , dri-devel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Apr 27, 2021 at 8:32 PM Dave Airlie wrote: > > This is the main drm pull request for 5.13. The usual lots of work all > over the place. [...] > > Mikita Lipski: > drm/amd/display: Add MST capability to trigger_hotplug interface Hmm. I've already merged this, but my clang build shows that this looks buggy: drivers/gpu/drm/amd/amdgpu/amdgpu_dm/amdgpu_dm_debugfs.c:3015:53: warning: address of 'aconnector->mst_port->mst_mgr' will always evaluate to 'true' [-Wpointer-bool-conversion] if (!(aconnector->port && &aconnector->mst_port->mst_mgr)) ~~ ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ and yeah, checking for the address of a member of a structure benign NULL doesn't really work. I'm assuming the '&' is just a left-over cut-and-paste error or something. Please fix after reviewing (I'm not going to blindly just remove the '&' just to silence the warning, since I don't know the code). Linus _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel