From: Andy Shevchenko <firstname.lastname@example.org>
To: Greg Kroah-Hartman <email@example.com>
"open list:FRAMEBUFFER LAYER" <firstname.lastname@example.org>,
Andy Shevchenko <email@example.com>,
Linux Kernel Mailing List <firstname.lastname@example.org>,
Subject: Re: [PATCH v2 1/4] fbtft: Replace custom ->reset() with generic one
Date: Tue, 27 Apr 2021 15:10:14 +0300 [thread overview]
Message-ID: <CAHp75VdkPWKVSYmYqerMs=6BpkS81KcL9DnYGL5XbkMm-rrW9g@mail.gmail.com> (raw)
On Tue, Apr 27, 2021 at 2:09 PM Greg Kroah-Hartman
> On Fri, Apr 16, 2021 at 05:20:41PM +0300, Andy Shevchenko wrote:
> > The custom ->reset() repeats the generic one, replace it.
> > Note, in newer kernels the context of the function is a sleeping one,
> > it's fine to switch over to the sleeping functions. Keeping the reset
> > line asserted longer than 20 microseconds is also okay, it's an idling
> > state of the hardware.
> > Fixes: b2ebd4be6fa1 ("staging: fbtft: add fb_agm1264k-fl driver")
> What does this "fix"? A bug or just a "it shouldn't have been done this
There is nothing to fix actually, it's rather a pointer where this
change has been missed for some reason. I'll remove the tag.
> And as others pointed out, if you could put "staging: fbtft:" as a
> prefix here, that would be much better.
Got it, thanks!
With Best Regards,
dri-devel mailing list
prev parent reply other threads:[~2021-04-27 12:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 14:20 [PATCH v2 1/4] fbtft: Replace custom ->reset() with generic one Andy Shevchenko
2021-04-16 14:20 ` [PATCH v2 2/4] fbtft: Rectify GPIO handling Andy Shevchenko
2021-04-16 14:20 ` [PATCH v2 3/4] fbtft: Don't spam logs when probe is deferred Andy Shevchenko
2021-04-16 14:20 ` [PATCH v2 4/4] fbtft: Update TODO Andy Shevchenko
2021-04-17 7:18 ` [PATCH v2 1/4] fbtft: Replace custom ->reset() with generic one Fabio Aiuto
2021-04-27 11:07 ` Greg Kroah-Hartman
2021-04-27 12:10 ` Andy Shevchenko [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).