From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: ChiaEn Wu <peterwu.pub@gmail.com>
Cc: "open list:FRAMEBUFFER LAYER" <linux-fbdev@vger.kernel.org>,
"Krogerus, Heikki" <heikki.krogerus@linux.intel.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Alice Chen <alice_chen@richtek.com>,
linux-iio <linux-iio@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Liam Girdwood <lgirdwood@gmail.com>,
cy_huang <cy_huang@richtek.com>, Pavel Machek <pavel@ucw.cz>,
Lee Jones <lee.jones@linaro.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Helge Deller <deller@gmx.de>, Rob Herring <robh+dt@kernel.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Guenter Roeck <linux@roeck-us.net>,
devicetree <devicetree@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
szuni chen <szunichen@gmail.com>, Mark Brown <broonie@kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Jingoo Han <jingoohan1@gmail.com>,
USB <linux-usb@vger.kernel.org>,
Sebastian Reichel <sre@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ChiaEn Wu <chiaen_wu@richtek.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v6 11/13] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support
Date: Mon, 25 Jul 2022 10:40:32 +0200 [thread overview]
Message-ID: <CAHp75VewxvEDGoPdRBvLSLQOQ6OZzVft1ce3DkF7MK_O1VXZkQ@mail.gmail.com> (raw)
In-Reply-To: <20220722102407.2205-12-peterwu.pub@gmail.com>
On Fri, Jul 22, 2022 at 12:25 PM ChiaEn Wu <peterwu.pub@gmail.com> wrote:
>
> From: ChiYuan Huang <cy_huang@richtek.com>
^^^^ (Note this and read below)
>
> The MediaTek MT6370 is a highly-integrated smart power management IC,
> which includes a single cell Li-Ion/Li-Polymer switching battery
> charger, a USB Type-C & Power Delivery (PD) controller, dual
> Flash LED current sources, a RGB LED driver, a backlight WLED driver,
> a display bias driver and a general LDO for portable devices.
>
> In MediaTek MT6370, there are four channel current-sink RGB LEDs that
> support hardware pattern for constant current, PWM, and breath mode.
> Isink4 channel can also be used as a CHG_VIN power good indicator.
> Signed-off-by: Alice Chen <alice_chen@richtek.com>
> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
In conjunction with above what SoB of Alice means?
You really need to take your time and (re-)read
https://www.kernel.org/doc/html/latest/process/submitting-patches.html.
...
> + * Author: Alice Chen <alice_chen@richtek.com>
> + * Author: ChiYuan Huang <cy_huang@richtek.com>
Would
* Authors:
* Name_of_Author 1
* Name_of_Author 2
work for you?
...
> +struct mt6370_led {
> + union {
> + struct led_classdev isink;
> + struct led_classdev_mc mc;
> + };
Where is the field that makes union work?
> + struct mt6370_priv *priv;
> + u32 default_state;
> + u32 index;
> +};
...
> +static int mt6370_gen_breath_pattern(struct mt6370_priv *priv,
> + struct led_pattern *pattern, u32 len,
> + u8 *pattern_val, u32 val_len)
> +{
> + enum mt6370_led_ranges sel_range;
> + struct led_pattern *curr;
> + unsigned int sel;
> + u8 val[P_MAX_PATTERNS / 2] = {};
> + int i;
> +
> + if (len < P_MAX_PATTERNS && val_len < P_MAX_PATTERNS / 2)
> + return -EINVAL;
> +
> + /*
> + * Pattern list
> + * tr1: byte 0, b'[7: 4]
> + * tr2: byte 0, b'[3: 0]
> + * tf1: byte 1, b'[7: 4]
> + * tf2: byte 1, b'[3: 0]
> + * ton: byte 2, b'[7: 4]
> + * toff: byte 2, b'[3: 0]
> + */
> + for (i = 0; i < P_MAX_PATTERNS; i++) {
> + curr = pattern + i;
> +
> + sel_range = i == P_LED_TOFF ? R_LED_TOFF : R_LED_TRFON;
> +
> + linear_range_get_selector_within(priv->ranges + sel_range,
> + curr->delta_t, &sel);
> +
> + val[i / 2] |= sel << (4 * ((i + 1) % 2));
> + }
> +
> + memcpy(pattern_val, val, 3);
Isn't it something like put_unaligned_be24()/put_unaligned_le24()?
> + return 0;
> +}
...
> +static inline int mt6370_mc_pattern_clear(struct led_classdev *lcdev)
> +{
> + struct led_classdev_mc *mccdev = lcdev_to_mccdev(lcdev);
> + struct mt6370_led *led = container_of(mccdev, struct mt6370_led, mc);
> + struct mt6370_priv *priv = led->priv;
> + struct mc_subled *subled;
> + int i, ret = 0;
Redundant assignment.
> + mutex_lock(&led->priv->lock);
> +
> + for (i = 0; i < mccdev->num_colors; i++) {
> + subled = mccdev->subled_info + i;
> +
> + ret = mt6370_set_led_mode(priv, subled->channel,
> + MT6370_LED_REG_MODE);
> + if (ret)
> + break;
> + }
> +
> + mutex_unlock(&led->priv->lock);
> +
> + return ret;
> +}
...
> + if (!fwnode_property_read_string(init_data->fwnode, "default-state",
> + &stat_str)) {
ret = fwnode_...(...);
if (!ret)
> + ret = match_string(states, ARRAY_SIZE(states), stat_str);
> + if (ret < 0)
> + ret = STATE_OFF;
> +
> + led->default_state = ret;
> + }
...
> + int i = 0, ret;
unsigned int i = 0;
int ret;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-07-25 8:41 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 10:23 [PATCH v6 00/13] Add MediaTek MT6370 PMIC support ChiaEn Wu
2022-07-22 10:23 ` [PATCH v6 01/13] dt-bindings: usb: Add MediaTek MT6370 TCPC ChiaEn Wu
2022-07-22 10:23 ` [PATCH v6 02/13] dt-bindings: power: supply: Add MediaTek MT6370 Charger ChiaEn Wu
2022-07-22 10:23 ` [PATCH v6 03/13] dt-bindings: leds: mt6370: Add MediaTek MT6370 current sink type LED indicator ChiaEn Wu
2022-07-22 10:23 ` [PATCH v6 04/13] dt-bindings: leds: Add MediaTek MT6370 flashlight ChiaEn Wu
2022-07-30 21:30 ` Pavel Machek
2022-07-22 10:23 ` [PATCH v6 05/13] dt-bindings: backlight: Add MediaTek MT6370 backlight ChiaEn Wu
2022-07-22 10:24 ` [PATCH v6 06/13] dt-bindings: mfd: Add MediaTek MT6370 ChiaEn Wu
2022-07-22 10:24 ` [PATCH v6 07/13] mfd: mt6370: Add MediaTek MT6370 support ChiaEn Wu
2022-07-25 7:59 ` Andy Shevchenko
2022-07-25 8:29 ` ChiaEn Wu
2022-07-25 8:43 ` Andy Shevchenko
2022-07-25 9:06 ` ChiaEn Wu
2022-07-25 9:09 ` Andy Shevchenko
2022-07-22 10:24 ` [PATCH v6 08/13] usb: typec: tcpci_mt6370: Add MediaTek MT6370 tcpci driver ChiaEn Wu
2022-07-22 14:19 ` Guenter Roeck
2022-07-25 7:06 ` Chunfeng Yun
2022-07-25 7:17 ` ChiaEn Wu
2022-07-25 8:03 ` Andy Shevchenko
2022-07-22 10:24 ` [PATCH v6 09/13] iio: adc: mt6370: Add MediaTek MT6370 support ChiaEn Wu
2022-07-25 8:10 ` Andy Shevchenko
2022-07-22 10:24 ` [PATCH v6 10/13] power: supply: mt6370: Add MediaTek MT6370 charger driver ChiaEn Wu
2022-07-25 8:25 ` Andy Shevchenko
2022-07-22 10:24 ` [PATCH v6 11/13] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support ChiaEn Wu
2022-07-22 10:52 ` AngeloGioacchino Del Regno
2022-07-25 8:40 ` Andy Shevchenko [this message]
2022-07-26 11:45 ` ChiaEn Wu
2022-07-26 12:17 ` Andy Shevchenko
2022-07-27 7:36 ` ChiaEn Wu
2022-07-27 10:03 ` Andy Shevchenko
2022-07-30 21:39 ` Pavel Machek
2022-07-22 10:24 ` [PATCH v6 12/13] leds: flash: mt6370: Add MediaTek MT6370 flashlight support ChiaEn Wu
2022-07-22 10:48 ` AngeloGioacchino Del Regno
2022-07-25 8:51 ` Andy Shevchenko
2022-07-29 6:17 ` szuni chen
2022-07-29 10:34 ` Andy Shevchenko
2022-07-25 8:55 ` Andy Shevchenko
2022-07-26 4:15 ` szuni chen
2022-07-26 6:10 ` Andy Shevchenko
2022-07-30 21:42 ` Pavel Machek
2022-08-04 9:53 ` Alice Chen
2022-07-22 10:24 ` [PATCH v6 13/13] video: backlight: mt6370: Add MediaTek MT6370 support ChiaEn Wu
2022-07-25 9:07 ` Andy Shevchenko
2022-07-25 10:31 ` Daniel Thompson
2022-07-26 2:20 ` ChiaEn Wu
2022-07-26 9:30 ` Daniel Thompson
2022-07-26 11:28 ` ChiaEn Wu
2022-07-26 11:59 ` Daniel Thompson
2022-07-27 6:24 ` ChiaEn Wu
2022-07-28 11:31 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VewxvEDGoPdRBvLSLQOQ6OZzVft1ce3DkF7MK_O1VXZkQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=alice_chen@richtek.com \
--cc=broonie@kernel.org \
--cc=chiaen_wu@richtek.com \
--cc=chunfeng.yun@mediatek.com \
--cc=cy_huang@richtek.com \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jic23@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
--cc=peterwu.pub@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=szunichen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).