From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA01DC433EF for ; Wed, 6 Apr 2022 16:10:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EF2B810E2C7; Wed, 6 Apr 2022 16:10:50 +0000 (UTC) Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by gabe.freedesktop.org (Postfix) with ESMTPS id A3C0710E2C7 for ; Wed, 6 Apr 2022 16:10:49 +0000 (UTC) Received: by mail-pj1-x102e.google.com with SMTP id j20-20020a17090ae61400b001ca9553d073so3161210pjy.5 for ; Wed, 06 Apr 2022 09:10:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=95RDoGyZtbEcoHnBFQepKxpMoAUWFwyWGwDHuUzcbMY=; b=zTEdfItkEUK2LGYDh68HRGrbmaItaQKULw+9lTwbEZaNWQ05CQRkXWASt2A7Qmhj8K YGMn50PZLtb7ypgA3b1nPiDm0qf0Mv3ndZBmL7rAsU/WuANTcI6C8A08/xkYCuGhWLKS PItQG6iDdRcofzI+yRZ3GcCEqpnnkET4k4bzz5g+2T2owMotAIBXShuBP2qJnHIyhZWp JCjqJ0UKzYCWKcRzlgzg3hI2Hp+zS69zcd8L4LMVuD4I9iJvsWoN1cLmAFk4OA5SGfrd SRU58ASegW/3oxsQ7FfT09ANtu+UI8wvdVAghhGIgJdowFKp0DMI+a9BBAlS1Qy3vrlF 7gIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=95RDoGyZtbEcoHnBFQepKxpMoAUWFwyWGwDHuUzcbMY=; b=wnMZe8pLiZ18qTQt+aT7Zwvvkx/EW7YWd1FgDxtJdH0sjkrmfk8c9ZT9YLHZ//3CTc A/FTgHnqFOCKphV+SDlA2FAuKsko4qSTNENWgcA81tuER2lBX1ru9yitIgTbjMs9MNGy ph+eP6OHBSXE/k86yObtIrrvxiRfDP+1kwvdPcsKHGkJmLKf2+56zHsm4ZVSoVG/Xh5h oVVzSg2W1LFPP9p5s+wA2DusrWJrcfNnCj3/zzX2F/8WJBICErb3uuIV8VWXwawsWvJ2 UZnFbkqsR5T434B5VgNcAZfEogHGjvUogOMfZmcrlTHvP6mxWPOV1+kjTsb6hnS/36An biEw== X-Gm-Message-State: AOAM5320o/kcJuc56OKW1vTRu5IwjwdxJD1Fhuj1BLDf47zI27ID9APP f2dxo9hzXwxX3dCC/DrLVfVzquuvXK/Zb8/Py224BA== X-Google-Smtp-Source: ABdhPJzlZiYbA1h7PZOpTXhFDSXJLbry3YFGlV7/j3Lx1oTWVTvgRcbYK3zPbBRS+2NsM3aFsrF3c9D6iK8fVBDPttI= X-Received: by 2002:a17:903:206:b0:153:ebab:a52f with SMTP id r6-20020a170903020600b00153ebaba52fmr9290143plh.118.1649261449125; Wed, 06 Apr 2022 09:10:49 -0700 (PDT) MIME-Version: 1.0 References: <20220406160123.1272911-1-l.stach@pengutronix.de> In-Reply-To: <20220406160123.1272911-1-l.stach@pengutronix.de> From: Tim Harvey Date: Wed, 6 Apr 2022 09:10:38 -0700 Message-ID: Subject: Re: [PATCH v0 00/10] i.MX8MP HDMI support To: Lucas Stach Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Device Tree Mailing List , Pengutronix Kernel Team , Neil Armstrong , DRI mailing list , Robert Foss , Kishon Vijay Abraham I , Vinod Koul , Rob Herring , NXP Linux Team , linux-phy@lists.infradead.org, Krzysztof Kozlowski , patchwork-lst@pengutronix.de, Shawn Guo , Linux ARM Mailing List , Andrzej Hajda Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Apr 6, 2022 at 9:01 AM Lucas Stach wrote: > > Hi all, > > this adds support for the HDMI output pipeline on the i.MX8MP. > It currently depends on the i.MX8MP HDMI power domain series [1] > and support for the new LCDIF [2] in the i.MX8MP. I guess the > implementation presented here also still has some warts that > require fixing and the individual patches most likely need to go > through different maintainer trees, so I don't expect this series > to be applied right away. > > However this complete series should allow people to test it more > easily and provide feedback on the implementation with the full > picture available. > > Compared to downstream this implementation actually allows to > power down the separate HDMI PHY power domain when the display > is inactive or no HDMI cable is connected. > > Regards, > Lucas > > [1] https://lore.kernel.org/all/20220406153402.1265474-1-l.stach@pengutronix.de/ > [2] https://lore.kernel.org/all/20220322142853.125880-1-marex@denx.de/ > > Lucas Stach (10): > drm/bridge: dw-hdmi: add low-active PHY reset > dt-bindings: display: imx: add binding for i.MX8MP HDMI TX > drm/imx: add bridge wrapper driver for i.MX8MP DWC HDMI > dt-bindings: display: imx: add binding for i.MX8MP HDMI PVI > drm/imx: add driver for HDMI TX Parallel Video Interface > dt-bindings: phy: add binding for the i.MX8MP HDMI PHY > phy: freescale: add Samsung HDMI PHY > arm64: dts: imx8mp: add HDMI irqsteer > arm64: dts: imx8mp: add HDMI display pipeline > arm64: dts: imx8mp-evk: enable HDMI > > .../display/imx/fsl,imx8mp-hdmi-pvi.yaml | 83 ++ > .../bindings/display/imx/fsl,imx8mp-hdmi.yaml | 72 ++ > .../bindings/phy/fsl,imx8mp-hdmi-phy.yaml | 62 + > arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 19 + > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 93 ++ > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 7 + > drivers/gpu/drm/imx/Kconfig | 1 + > drivers/gpu/drm/imx/Makefile | 2 + > drivers/gpu/drm/imx/bridge/Kconfig | 18 + > drivers/gpu/drm/imx/bridge/Makefile | 4 + > drivers/gpu/drm/imx/bridge/imx-hdmi-pvi.c | 209 +++ > drivers/gpu/drm/imx/bridge/imx-hdmi.c | 128 ++ > drivers/phy/freescale/Kconfig | 7 + > drivers/phy/freescale/Makefile | 1 + > drivers/phy/freescale/phy-fsl-samsung-hdmi.c | 1145 +++++++++++++++++ > include/drm/bridge/dw_hdmi.h | 1 + > 16 files changed, 1852 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8mp-hdmi-pvi.yaml > create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8mp-hdmi.yaml > create mode 100644 Documentation/devicetree/bindings/phy/fsl,imx8mp-hdmi-phy.yaml > create mode 100644 drivers/gpu/drm/imx/bridge/Kconfig > create mode 100644 drivers/gpu/drm/imx/bridge/Makefile > create mode 100644 drivers/gpu/drm/imx/bridge/imx-hdmi-pvi.c > create mode 100644 drivers/gpu/drm/imx/bridge/imx-hdmi.c > create mode 100644 drivers/phy/freescale/phy-fsl-samsung-hdmi.c > > -- > 2.30.2 > Lucas, Thanks for consolidating this - It's been difficult to try to merge these for testing. I still have not been able to apply these to origin/master or imx/master - what are you basing off of here? Best Regards, Tim I