Re: [PATCH] drm/panel-simple: Add Vivax TPC-9150 panel v3

[Nikola Pavlica <pavlica.nikola@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2660 bytes --]

Apologies for the spammy emails, I didn't see Sam's comment on time.

On Tue, Aug 17, 2021 at 6:36 PM Nikola Pavlica <pavlica.nikola@gmail.com>
wrote:

> The model and make of the LCD panel of the Vivax TPC-9150 is unknown,
> hence the panel settings that were retrieved with a FEX dump are named
> after the device NOT the actual panel.
>
> The LCD in question is a 50 pin MISO TFT LCD panel of the resolution
> 1024x600 used by the aforementioned device.
>
> Version 2, as Thierry kindly suggested that I fix the order in which the
> panel was ordered compared to others.
>
> Version 3, filling in the required info suggested by Sam. Plus some
> factual issues that I've corrected myself (tested working)
>
> Thanks,
> Nikola
>
> Signed-off-by: Nikola Pavlica <pavlica.nikola@gmail.com>
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c
> b/drivers/gpu/drm/panel/panel-simple.c
> index 4e2dad314c79..f6b3e58c162b 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -3989,6 +3989,32 @@ static const struct panel_desc
> urt_umsh_8596md_parallel = {
>         .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
>  };
>
> +static const struct drm_display_mode vivax_tpc9150_panel_mode = {
> +       .clock = 60000,
> +       .hdisplay = 1024,
> +       .hsync_start = 1024 + 160,
> +       .hsync_end = 1024 + 160 + 100,
> +       .htotal = 1024 + 160 + 100 + 60,
> +       .vdisplay = 600,
> +       .vsync_start = 600 + 12,
> +       .vsync_end = 600 + 12 + 10,
> +       .vtotal = 600 + 12 + 10 + 13,
> +};
> +
> +static const struct panel_desc vivax_tpc9150_panel = {
> +       .modes = &vivax_tpc9150_panel_mode,
> +       .num_modes = 1,
> +       .size = {
> +               .width = 200,
> +               .height = 115,
> +       },
> +       .bpc = 6,
> +       .bus_format = MEDIA_BUS_FMT_RGB666_1X24,
> +       .bus_flags = DRM_BUS_FLAG_DE_HIGH,
> +       .connector_type = DRM_MODE_CONNECTOR_LVDS,
> +};
> +
> +
>  static const struct drm_display_mode vl050_8048nt_c01_mode = {
>         .clock = 33333,
>         .hdisplay = 800,
> @@ -4490,6 +4516,9 @@ static const struct of_device_id platform_of_match[]
> = {
>         }, {
>                 .compatible = "urt,umsh-8596md-20t",
>                 .data = &urt_umsh_8596md_parallel,
> +       }, {
> +               .compatible = "vivax,tpc9150-panel",
> +               .data = &vivax_tpc9150_panel,
>         }, {
>                 .compatible = "vxt,vl050-8048nt-c01",
>                 .data = &vl050_8048nt_c01,
> --
> 2.32.0
>
>

[-- Attachment #2: Type: text/html, Size: 3448 bytes --]