From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07D7CC433E1 for ; Sat, 25 Jul 2020 19:20:01 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CBA61206D7 for ; Sat, 25 Jul 2020 19:20:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mvXHuh6j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CBA61206D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B8E16E2E3; Sat, 25 Jul 2020 19:20:00 +0000 (UTC) Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by gabe.freedesktop.org (Postfix) with ESMTPS id 93EBE6E2E3 for ; Sat, 25 Jul 2020 19:19:59 +0000 (UTC) Received: by mail-lj1-x235.google.com with SMTP id f5so13227964ljj.10 for ; Sat, 25 Jul 2020 12:19:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g4J6dkRqHFKiKhjcRC8q/JmeC/kbD2LNmS8StOCmtOU=; b=mvXHuh6jpM3ry5QoR34JW1d8FG1E/6i19D+6eHevdB/BJD97IyC8wD2xC+bM8l5Ujc 48KF5bxobuUlIlCULXPavhfxF3h1KYr8QgsIyILVedJSXIv54uInP6GcUT1iXSG+ayYu EUD7recqFSD++W9kn404rRgoXuFpxT5nBnjmX6YS6TX57Bn99MxgL9v8Ty2mxycVSlz9 lFPJy/ecKwv3YkQic14JYKpV3fDDMlwGCrzbXwY0ocmBn8/Wkw7sQcmAuR6xMs5JLrnE TvooKIp0/sJ+Z9iwMaWOvHuMMjRAhrsvnR6k1debndHhInU3NvFu9JxZ3LxaPSPWVaS3 e1Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g4J6dkRqHFKiKhjcRC8q/JmeC/kbD2LNmS8StOCmtOU=; b=QzF+1HS8gzIKSdrA77HpUhu48xZzPqQxaaGM0U41hnDvK39blkU7eJPssIPGj5346k 5oF/c2YlUT2BmS0f9msCZ3Bc+bHNOXMQ6yPG/QzlZiuP1iHpN+LQ9TUGTv2z+Zm2kRUH sgDRAbVktt5uL5dyzMuQvnGtsK4fe5gegAzIqWg6Ziwqp0EbxoHMMfqecXyPhWvXkuyP 6JdDw7xjd42hUPgDXCjlofRRxqk8IeAAEEcuoaV5TqRzl11h0KW2icIiAGRhznYnHBWh Fu9jNEfZJPe4LIQcsA1vG8NW7hBnWoelQTX6XT2TLXFWMFuT93phWM9OhX15TBoLrE+g 3ehw== X-Gm-Message-State: AOAM533OdKijgaTL0mFBI1tK7sHND+7DxDq3qKJU2jvQOgUMKtezcjkS 61jRc1EdfFHr777sfOM26Nro25YY6sl8Asc67wA= X-Google-Smtp-Source: ABdhPJwX2YWaS3FX13+Q0LtCtGPNZAsAPnsJBOyVicKVnyzv1PltkImBXj4c5goex61U5pVCv5ilQrP7FYqxDuxoALY= X-Received: by 2002:a2e:9d0b:: with SMTP id t11mr589477lji.365.1595704797729; Sat, 25 Jul 2020 12:19:57 -0700 (PDT) MIME-Version: 1.0 References: <20200722110411.ebkv6knvc6mzw5uf@smtp.gmail.com> <20200722120502.GK6419@phenom.ffwll.local> <20200722140604.27dfzfnzug5vb75r@smtp.gmail.com> <20200725011737.GA2851@realwakka> <20200725174514.esh4gqek6oddizvh@smtp.gmail.com> <20200725184918.togb54bxuifrq77c@smtp.gmail.com> In-Reply-To: <20200725184918.togb54bxuifrq77c@smtp.gmail.com> From: Melissa Wen Date: Sat, 25 Jul 2020 16:19:46 -0300 Message-ID: Subject: Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush To: Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Haneen Mohammed , Rodrigo Siqueira , David Airlie , Rodrigo Siqueira , Linux Kernel Mailing List , dri-devel , kernel-usp@googlegroups.com, Sidong Yang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > No, this very first warning continues (only once) :( > From here (drm_crtc_vblank_on): > if (atomic_read(&vblank->refcount) != 0 || drm_vblank_offdelay == 0) > drm_WARN_ON(dev, drm_vblank_enable(dev, pipe)); Sorry, not sure when this warning is triggered. > > > But I'm still wondering why after step 3 we don't get -EINVAL from > > vblank_get() - after vblank_off() vblank->enabled should be false > > again, getting us back to the same state as after 1. Is that not > > happening? > > Yes (sorry if it got confused), we got -EINVAL after setp 3: > > In step 3, at the end of the 2nd running, we have: > atomic_disable > --> vblank_off [!vblank->inmodeset + refcount going 0->1 + inmodeset=1] > and then in next vblank_get: -EINVAL (!vblank->enabled + refcount ends 1) > as in the first step. > > Melissa > > > -Daniel > > > > > > > > > > > > > > > Thanks > > > > > -Sidong > > > > > > > > > > > > > > > > > > > > > > crtc->state->event = NULL; > > > > > > > > > } > > > > > > > > > > > > > > > > > > -- > > > > > > > > > 2.27.0 > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > Daniel Vetter > > > > > > > > Software Engineer, Intel Corporation > > > > > > > > http://blog.ffwll.ch > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Daniel Vetter > > > > > > Software Engineer, Intel Corporation > > > > > > http://blog.ffwll.ch > > > > > > _______________________________________________ > > > > > > dri-devel mailing list > > > > > > dri-devel@lists.freedesktop.org > > > > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > > > > > > > > > > > > > > -- > > > > Daniel Vetter > > > > Software Engineer, Intel Corporation > > > > http://blog.ffwll.ch > > > > > > > > -- > > Daniel Vetter > > Software Engineer, Intel Corporation > > http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel