From: Molly Sophia <mollysophia379@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>,
Sumit Semwal <sumit.semwal@linaro.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: display: panel: Add Novatek NT35596S panel bindings
Date: Thu, 28 Jul 2022 10:04:14 +0800 [thread overview]
Message-ID: <CAK0UmJBkMBfGN8q-ap-zWAJWeD9-WsXErMWPtpvcDmNWiHSSvQ@mail.gmail.com> (raw)
In-Reply-To: <809e9c7d-7634-f690-675d-9eccac8c8de8@linaro.org>
Thanks! I'll handle that and send the new patches later.
Best regards,
Molly
On Wed, Jul 27, 2022 at 6:24 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 26/07/2022 12:15, Molly Sophia wrote:
> > Add documentation for "novatek,nt35596s" panel.
> >
> > Changes in v3:
> > - Embed the documentation into existing one (novatek,nt36672a).
> >
> > Signed-off-by: Molly Sophia <mollysophia379@gmail.com>
> > ---
> > .../display/panel/novatek,nt36672a.yaml | 20 ++++++++++++-------
> > 1 file changed, 13 insertions(+), 7 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml
> > index 563766d283f6..560fb66d0e5a 100644
> > --- a/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml
> > @@ -20,14 +20,20 @@ allOf:
> >
> > properties:
> > compatible:
> > - items:
> > - - enum:
> > - - tianma,fhd-video
> > - - const: novatek,nt36672a
> > + oneOf:
> > + - items:
> > + - enum:
> > + - tianma,fhd-video
> > + - const: novatek,nt36672a
> > +
> > + - items:
> > + - enum:
> > + - jdi,fhd-nt35596s
> > + - const: novatek,nt35596s
>
> This entire entry should be rather before nt36672a judging by numbers:
>
> + oneOf:
> + - items:
> + - enum:
> + - jdi,fhd-nt35596s
> + - const: novatek,nt35596s
> +
> + - items:
> + - enum:
> + - tianma,fhd-video
> + - const: novatek,nt36672a
>
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2022-07-28 2:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 10:15 [PATCH v3 0/2] Add driver for Novatek NT35596S panel Molly Sophia
2022-07-26 10:15 ` [PATCH v3 1/2] dt-bindings: display: panel: Add Novatek NT35596S panel bindings Molly Sophia
2022-07-27 10:24 ` Krzysztof Kozlowski
2022-07-28 2:04 ` Molly Sophia [this message]
2022-07-26 10:15 ` [PATCH v3 2/2] drm: panel: Add novatek nt35596s panel driver Molly Sophia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK0UmJBkMBfGN8q-ap-zWAJWeD9-WsXErMWPtpvcDmNWiHSSvQ@mail.gmail.com \
--to=mollysophia379@gmail.com \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=sumit.semwal@linaro.org \
--cc=thierry.reding@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).