From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 869E7C2BB1D for ; Tue, 14 Apr 2020 20:38:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F1592076B for ; Tue, 14 Apr 2020 20:38:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F1592076B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AEF2B6E262; Tue, 14 Apr 2020 20:38:48 +0000 (UTC) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 96CAB6E598 for ; Tue, 14 Apr 2020 20:38:46 +0000 (UTC) Received: from mail-qv1-f42.google.com ([209.85.219.42]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MeTwa-1ioIAC2XP2-00aRZH for ; Tue, 14 Apr 2020 22:38:44 +0200 Received: by mail-qv1-f42.google.com with SMTP id p19so640862qve.0 for ; Tue, 14 Apr 2020 13:38:44 -0700 (PDT) X-Gm-Message-State: AGi0Puausiyxq8oUW/rA2RLj79rRkpw7XADpH43rtQs+XYOUxhKjYITx RLmjZGILJLkyKHP1GDSPPqKZDsIXSQRHXpiMC3g= X-Google-Smtp-Source: APiQypItYypDsjCwUbSgds2sz8DtaSNucgF8fWN3bMg92RuY+7b77MZXAmlayTdn31FZhJ2svnHHXIwy2Ox7TvokgAw= X-Received: by 2002:a0c:9e2f:: with SMTP id p47mr1723210qve.211.1586896723453; Tue, 14 Apr 2020 13:38:43 -0700 (PDT) MIME-Version: 1.0 References: <20200408202711.1198966-1-arnd@arndb.de> <20200408202711.1198966-6-arnd@arndb.de> <20200414201739.GJ19819@pendragon.ideasonboard.com> In-Reply-To: <20200414201739.GJ19819@pendragon.ideasonboard.com> From: Arnd Bergmann Date: Tue, 14 Apr 2020 22:38:27 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC 5/6] drm/rcar-du: fix selection of CMM driver To: Laurent Pinchart X-Provags-ID: V03:K1:9JVd+gQBjL1UUR8KPEwnZUbka5PhMMLp/OQsVOF9QfSioZguJY5 0uNNTPtBZ91kTXZhO4pn0End+90E+SospLU6OgWsVv3z0Z6CQSN82D43V+LAz+EmRaqquhj hNDHh6BEv/wpSeAaNcxt0fsZHXZrG76PWwBS1vy7Xqj+cf5SiUyzs/GtXztexdX0ckvj9VL dGrHQ0N8PWEvMdSWvn54g== X-UI-Out-Filterresults: notjunk:1;V03:K0:lls/oU1qYkw=:aYtt0LYpXLCH4wfLLFhbf+ +xIm1ju7iF/KRIup8G/HlxCRgLiMNgIfKW+0XfR+VsFSlzRsEHaafXK8p+G5Vuxu8cjkMktFc woilmO1Y3cNH5t501FMhQpkHlrTPL1Hz4HT5ZPvsxS5H5Mbm4/TBkkRM/utgDwtzf0fDUH/ml QqUabo+i4edF/QW+g0mtM6h2A+A6HU5g5HeUwvmPWV+CnlHS2b+8rNjhurhoDzIJVKrBROUJW eZY3oZU2gTXEo+I/t8dKh/CjB0NDDJzzng1clAzKdri229ovQYHqHQKfRQmN1k0SxZhqO4MaU AoLZEJnBkaDIgXm8Dl+WZ8bscxXKXZrFZp9gsaO03JDDucqCdEGPC/gTvWpug9AhmHmo24PGA nTEiOssLiQdjDPBx+ENdoKVsr5TbHppi89L1/DL2hAM8cE4fyH2I0tJEm3oRlzl6PiJVZdrml 5VmYi+UbhPExg38aTazssVfDAxzoVLCyj47YmCFrufNXfAPeeRGUkYUiIaRnyzCFeUhDGd7Nb XnEL00irE92aRaLkLlYWauUc2SNhMl/bFGlO475aROzK2IlX2nImiVFiJPIjcBmoTH04evdns WJxSrzusmFnEHTnvon5nmBhZ4e2wqcF7DqRZAiFaLh3hXT74QkU1qQEp2ah30Pg6E1L4yuQBJ N5IH/y2/ptFKjipa13Lc1MXHezeDFO6OlUaM0ALVsB0IrJQAB5E/Dc01oXjUmT7PK68n/DgxP tSGFuzVLrmir1FZX5CiK/mssNQP5U+mvBtSuOdSyWCJ6JfWY6auy5QPItPsXhFMk5OubySdww 5sZ3U5M1Z0ieqea5CMFthfbZwelPNUXWB7u4dCfctzpkT7gvAA= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Leon Romanovsky , Neil Armstrong , David Airlie , Networking , Masahiro Yamada , Jonas Karlman , Saeed Mahameed , "linux-kernel@vger.kernel.org" , dri-devel , Nicolas Pitre , Linux-Renesas , Andrzej Hajda , Kieran Bingham , "David S. Miller" , linux-rdma Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Apr 14, 2020 at 10:17 PM Laurent Pinchart wrote: > > Hi Arnd, > > Thank you for the patch. > > On Wed, Apr 08, 2020 at 10:27:10PM +0200, Arnd Bergmann wrote: > > The 'imply' statement does not seem to have an effect, as it's > > still possible to turn the CMM code into a loadable module > > in a randconfig build, leading to a link error: > > > > arm-linux-gnueabi-ld: drivers/gpu/drm/rcar-du/rcar_du_crtc.o: in function `rcar_du_crtc_atomic_enable': > > rcar_du_crtc.c:(.text+0xad4): undefined reference to `rcar_lvds_clk_enable' > > arm-linux-gnueabi-ld: drivers/gpu/drm/rcar-du/rcar_du_crtc.o: in function `rcar_du_crtc_atomic_disable': > > rcar_du_crtc.c:(.text+0xd7c): undefined reference to `rcar_lvds_clk_disable' > > arm-linux-gnueabi-ld: drivers/gpu/drm/rcar-du/rcar_du_drv.o: in function `rcar_du_init': > > rcar_du_drv.c:(.init.text+0x4): undefined reference to `rcar_du_of_init' > > arm-linux-gnueabi-ld: drivers/gpu/drm/rcar-du/rcar_du_encoder.o: in function `rcar_du_encoder_init': > > > > Remove the 'imply', and instead use a silent symbol that defaults > > to the correct setting. > > This will result in the CMM always being selected when DU is, increasing > the kernel size even for devices that don't need it. I believe we need a > better construct in Kconfig to fix this. I had expected this to have the same meaning that we had before the Kconfig change: whenever the dependencies are available, turn it on, otherwise leave it disabled. Can you describe what behavior you actually want instead? > > --- a/drivers/gpu/drm/rcar-du/Kconfig > > +++ b/drivers/gpu/drm/rcar-du/Kconfig > > @@ -4,7 +4,6 @@ config DRM_RCAR_DU > > depends on DRM && OF > > depends on ARM || ARM64 > > depends on ARCH_RENESAS || COMPILE_TEST > > - imply DRM_RCAR_CMM > > imply DRM_RCAR_LVDS > > select DRM_KMS_HELPER > > select DRM_KMS_CMA_HELPER > > @@ -15,9 +14,8 @@ config DRM_RCAR_DU > > If M is selected the module will be called rcar-du-drm. > > > > config DRM_RCAR_CMM > > - tristate "R-Car DU Color Management Module (CMM) Support" > > + def_tristate DRM_RCAR_DU > > depends on DRM && OF > > - depends on DRM_RCAR_DU > > help It would be easy enough to make this a visible 'bool' symbol and build it into the rcu-du-drm.ko module itself. Would that help you? Arnd _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel