From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57406C33C9E for ; Wed, 8 Jan 2020 11:56:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32FEB205F4 for ; Wed, 8 Jan 2020 11:56:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32FEB205F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AA68C6E1BC; Wed, 8 Jan 2020 11:56:01 +0000 (UTC) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.187]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7B4ED6E1BC; Wed, 8 Jan 2020 11:55:59 +0000 (UTC) Received: from mail-lj1-f176.google.com ([209.85.208.176]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.129]) with ESMTPSA (Nemesis) id 1M3VAI-1iphuB2d62-000dJk; Wed, 08 Jan 2020 12:55:57 +0100 Received: by mail-lj1-f176.google.com with SMTP id l2so3013473lja.6; Wed, 08 Jan 2020 03:55:57 -0800 (PST) X-Gm-Message-State: APjAAAXtpk+eU8G/XidDm1NhiBX5iI5vQzRD5Doqo3WjPpQss9/6tF4/ lO0Z/6KcADBCunW1KGzqtJqfaQ5H+0Nocb/I6FQ= X-Google-Smtp-Source: APXvYqx76A/E4Ch8oNBJvonZ2jianfqelDGhZdcoyIiElnwI+5tX58xf2+wQq15Hqyr3lM5AXUWKqh7e7QV64xZG5mc= X-Received: by 2002:a2e:9095:: with SMTP id l21mr2608508ljg.175.1578484556968; Wed, 08 Jan 2020 03:55:56 -0800 (PST) MIME-Version: 1.0 References: <1578415992-24054-1-git-send-email-krzk@kernel.org> <2355489c-a207-1927-54cf-85c04b62f18f@c-s.fr> <20200108091549.GB10145@pi3> In-Reply-To: <20200108091549.GB10145@pi3> From: Arnd Bergmann Date: Wed, 8 Jan 2020 12:55:39 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFT 00/13] iomap: Constify ioreadX() iomem argument To: Krzysztof Kozlowski X-Provags-ID: V03:K1:OLXxgklWfaLMhKuV8Wm8W39kUcHf4a+JyIfGa7uJ3yUjlTzpkyq eUd43K01aWA0i0ihiEp0mFdU1+/TaTZ/mvHEN/LvbjMgj+pw8G3G130nvwrLwWWZ9rkwc9y kIqJX9t0G2fM4p+HKuF78v7pt07b490bIVjM/G5rXC1PfGFIuGJzrH6CtWhepiGwo3n8FoV f9mNGXU4LtPGfMjnCSQHg== X-UI-Out-Filterresults: notjunk:1;V03:K0:k1T+yO7/AYI=:wC3ZSi6xX/4CO8QldrMdvY JOzpZSuOnyZeuROZmx2xIAHn/3tJjCqCfl+D7wo1n9saXZ2eUIm4HLndFSGzDVvvm01nRYsjX IhkaQf/a/tlicda2eH8CmWenZ2z0oi/Hg/5SpWBa5XCdmHaH5aqWvz1hNijlmfPJVpNmRiEek gf5E0EauCFUo/eHgBERs1Zx+fhkyqOx3wpS/tKnKDyjA3loKbKczpoAxPMiNfxwX39n+J8R05 n98+jXAUURpGT8fBQH71ucrLqI5inC9FWvQrPaVlAXy3ggQjmlTPnOo0fHqDPhKw+mZWhHwrZ 5R8mE9dgM9gd4rVAGDqevM8kYL9VweOFm1aCRHDRH0X9Db7Ta2w9bOgrEBTOYqnSgCR4Yx0cE SPsAEmWWFWdwVNgAob7EgVNz67ZPHdvxPoDMbBXbLcWm1tLZoRRqLS6Gx08MLqOQCJI5ufBaf TdlqSWo5wgYc5Istd7nU3/JfFsXK26QdgGERofOrDvUk7v7LQgR/SD12YeuqiXMGEHeLW2ZEs w51Brg7z9ATxU9rc3lrFTyXAgdGg0qc+v/ua2ztsQf0r2bS+boy6Dsd6JtERtyetIsqIZj3eE a0ry8Opmz4QUO47vFtYuTfDq2VSyI7uoro1845lHmn9/OQpQq4ZLJ1e+wFQLKT9wWQIHHxQKY X0CbsTm4C/pg/ATi7nvKDXtHO+WNsRmYXxt6h97uVxYUVHs/0eNGuZ9t9B6MS6sg0aLiwXz0S aUn97u2vvRkanwYSEh6N4l8qIlPXGc+W5Ia4gHR4ScnqV6FYWCudsdFdL0NjFKkf/7mZQ8Kaw dsqRye3wNWFASPvIud6fqJKCLOITeL5k8vAftrql30E4S2C4niX9a1scUQyxGYgjyw5KkQ2sI 4pcaTkoVVB8VBrmP+Xlw== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Jiri Slaby , "Michael S. Tsirkin" , David Airlie , ML nouveau , Jason Wang , DRI Development , virtualization@lists.linux-foundation.org, "James E.J. Bottomley" , Paul Mackerras , Linux-Arch , Dave Jiang , Yoshinori Sato , Helge Deller , Linux-sh list , Alexey Brodkin , Geert Uytterhoeven , Ben Skeggs , Dave Airlie , Matt Turner , arcml , Nick Kossifidis , Allen Hubbe , Jon Mason , Ivan Kokshaysky , Thomas Gleixner , Mauro Carvalho Chehab , Kalle Valo , Richard Henderson , Christophe Leroy , Parisc List , netdev , linux-wireless , Linux Kernel Mailing List , Luis Chamberlain , Vineet Gupta , alpha , linux-ntb@googlegroups.com, Andrew Morton , Linux Media Mailing List , linuxppc-dev , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Jan 8, 2020 at 10:15 AM Krzysztof Kozlowski wrote: > > The __force-cast that removes the __iomem here also means that > > the 'volatile' keyword could be dropped from the argument list, > > as it has no real effect any more, but then there are a few drivers > > that mark their iomem pointers as either 'volatile void __iomem*' or > > (worse) 'volatile void *', so we keep it in the argument list to not > > add warnings for those drivers. > > > > It may be time to change these drivers to not use volatile for __iomem > > pointers, but that seems out of scope for what Krzysztof is trying > > to do. Ideally we would be consistent here though, either using volatile > > all the time or never. > > Indeed. I guess there are no objections around const so let me send v2 > for const only. Ok, sounds good. Maybe mention in the changelog then that the 'volatile' in the interface is intentionally left out, and that only users of readl/writel still have it to deal with existing drivers. Arnd _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel