From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 903D6C33C8C for ; Tue, 7 Jan 2020 17:10:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 703472087F for ; Tue, 7 Jan 2020 17:10:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 703472087F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CB67489A98; Tue, 7 Jan 2020 17:10:29 +0000 (UTC) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2558A89A98 for ; Tue, 7 Jan 2020 17:10:27 +0000 (UTC) Received: from mail-vs1-f42.google.com ([209.85.217.42]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MsqIi-1jhnLO0rvc-00t9uU; Tue, 07 Jan 2020 18:10:26 +0100 Received: by mail-vs1-f42.google.com with SMTP id v12so34354252vsv.5; Tue, 07 Jan 2020 09:10:25 -0800 (PST) X-Gm-Message-State: APjAAAXcFBPJhtnAplKjHRRjLF/K5QxJWJcXvXVymcNej2rvrXx/X0fi wVBu6JhvdAX+IlcD7MXeTvFjRIiiBGm7+ru0Wro= X-Google-Smtp-Source: APXvYqxwO5AyDQus85+IK5BIt7KfSsh7NvpnQb9bzWV5OgyrFYMfLh14xqWUd9CW/X7TSfP34I+W9RVMaa5KUvf/Vb8= X-Received: by 2002:a0c:bd20:: with SMTP id m32mr365813qvg.197.1578417023930; Tue, 07 Jan 2020 09:10:23 -0800 (PST) MIME-Version: 1.0 References: <1578415992-24054-1-git-send-email-krzk@kernel.org> <1578415992-24054-9-git-send-email-krzk@kernel.org> In-Reply-To: <1578415992-24054-9-git-send-email-krzk@kernel.org> From: Arnd Bergmann Date: Tue, 7 Jan 2020 18:10:07 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFT 06/13] arc: Constify ioreadX() iomem argument (as in generic implementation) To: Krzysztof Kozlowski X-Provags-ID: V03:K1:Wl3I5GL8oTuHF4B8uEWhwYLx8r7xgnH4MKtioAfPmsSS/JrPJvU TG6HFiwedNhpJ6mUOPialIISyutXK5Oog/2XhTpT6MaFdcte+//iRG9NyuQ4EvkOr6NYUOc J/U6C4PJ9yfOSIlagB1J0hniPJ5IBQawFd6F2t/LJUu/jofOwL6F3R/nXWUi4BUreCwiRWa dSsT0RysLpw37gzjP3tQQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:gODU33sDVPA=:/qq9hxY92f6xRXIe6UUSpT UJs5Y2vXH8WbG3KwflD/hI49fxCV+zNT+KJCf637LM9D6HT1vYyRB3fsns+siEnzXIPPY4nrv +8WisqYq0pl21yDZOR0kgNJ6UTQLE1kCsk9bhPYj+KpntYYdEUfpHWKTfgcJzOREfGYOzvSAP ZWujHMVhB9cyzMJ4oGgh/0/07jZzdtvJchVNvrs9HWQ8sd3TM58alJ9cO14M+WAUZJC8Ehjny Yol1XXcgXtZ/dTfbwaZ8qmdz79OC9PT3Tsvb9VlUWNaL14mSVNYaQePRz8JjbJdqvkwdJV4W4 AcWeQFalRb/23mXnn74g1XXP5EZifpNJKXxrekTpDUl+D44d8yemxxoVVA7DtF+iuTtUUsRpf wVyoSRmMWMG7VvB+9Dt7TfeNOydXCuCSGQpRv+jitlu0rlE0BMatzPM6agKWGUtyYqM60ulPX fb0saQxiHbByuHKwkMsc+CBOklRl8sav2m6QGrrtNBC034tHiwZ7YuUhfUGekmnPRBRF5vZ1N buLsuvmFUvpRkZ7Pjj0kzPdZEHsHG9rcZSejOmzbfxlNTEvuAHWkSBOE3kVrtRj6C92V9zPr2 jtxKkfyln5hu4WtkntnityEUcMueAA6r5YxaFXT2FIqf+u1NF9e/+FddSuagRsv6siDAKHsTO sHtbPEJBMKs80FYoXuLCrugfi20GB66c4bwjuPFsqnVW5SlsA7bpYZyzEua/+XOYcF9MMtRQd McvJC1tZGA+F2/9iCdV8DisnjiDkSA2ckpKXv6aQzhh43a54Dxz1xxKuHbIm0/Wlea6xe1OI+ tMJjz0BuFTJA6RDVPDhdz2BTD35JLL4tPkzAgzzDU22xf+aUFm9mb81FTJWUDKc94YvqFsrp2 LNb/n8abEIkT4v/ZisZg== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Jiri Slaby , "Michael S. Tsirkin" , David Airlie , Jason Wang , dri-devel , virtualization@lists.linux-foundation.org, "James E.J. Bottomley" , Networking , Paul Mackerras , linux-arch , Dave Jiang , Yoshinori Sato , Michael Ellerman , Helge Deller , Linux-sh list , Alexey Brodkin , Geert Uytterhoeven , Ben Skeggs , ML nouveau , Dave Airlie , Matt Turner , "open list:SYNOPSYS ARC ARCHITECTURE" , Nick Kossifidis , Allen Hubbe , alpha , Ivan Kokshaysky , Thomas Gleixner , Mauro Carvalho Chehab , Kalle Valo , Richard Henderson , Parisc List , Vineet Gupta , linux-wireless , "linux-kernel@vger.kernel.org" , Luis Chamberlain , Jon Mason , linux-ntb@googlegroups.com, Andrew Morton , Linux Media Mailing List , linuxppc-dev , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jan 7, 2020 at 5:54 PM Krzysztof Kozlowski wrote: > > The ioreadX() helpers have inconsistent interface. On some architectures > void *__iomem address argument is a pointer to const, on some not. > > Implementations of ioreadX() do not modify the memory under the > address so they can be converted to a "const" version for const-safety > and consistency among architectures. > > Signed-off-by: Krzysztof Kozlowski The patch looks correct, but I would not bother here, as it has no effect on the compiler or its output. Arnd _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel