From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A71DC2BA19 for ; Wed, 15 Apr 2020 15:18:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA654208E4 for ; Wed, 15 Apr 2020 15:18:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA654208E4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 676A46EA12; Wed, 15 Apr 2020 15:18:42 +0000 (UTC) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id B22586EA12 for ; Wed, 15 Apr 2020 15:18:39 +0000 (UTC) Received: from mail-qk1-f173.google.com ([209.85.222.173]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MK3mS-1jgxg80C8k-00LYHR for ; Wed, 15 Apr 2020 17:18:38 +0200 Received: by mail-qk1-f173.google.com with SMTP id o19so10272126qkk.5 for ; Wed, 15 Apr 2020 08:18:37 -0700 (PDT) X-Gm-Message-State: AGi0PuZA5vkl3u18fNnRemfolG4ILjIdrn/nv+VXabZLhE81QMXClO1N 2KPEtW9bDKtq+kW5G4Yh2TkCLaGXfnLxNcuzTHQ= X-Google-Smtp-Source: APiQypKR0HaZQKe1NU2qEEDNoosGf+Eiif2YA3+bZv4o1jlLLMUkDmtAFRquqje/5krjrQpj3uXRFFr+JLm/a3RbNKI= X-Received: by 2002:a37:ba47:: with SMTP id k68mr15682834qkf.394.1586963916750; Wed, 15 Apr 2020 08:18:36 -0700 (PDT) MIME-Version: 1.0 References: <20200408202711.1198966-1-arnd@arndb.de> <20200408202711.1198966-6-arnd@arndb.de> <20200414201739.GJ19819@pendragon.ideasonboard.com> <20200414205158.GM19819@pendragon.ideasonboard.com> In-Reply-To: From: Arnd Bergmann Date: Wed, 15 Apr 2020 17:18:20 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC 5/6] drm/rcar-du: fix selection of CMM driver To: Geert Uytterhoeven X-Provags-ID: V03:K1:TnwXMSIWyg+Z5m8jaMITdXPH1MN0h20nYh7NYJ/qgJVE7Jug9zI WxWwwzlq/7rv2YKd1EUEy0VtPr6SjezsOSIfd02eHb3A/BqYWNuT7BzIRhGss+vKDNywDyX YMBu0c6fy/olet1rUVQsW4dSO1KF2GGsdEZivxUQO6QHy6XA6wR+44KqipmAvInvtbJBFPm pR3gpwIqr8ZxQXu9fOMrQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:S66ge8R3Cpc=:4jz1lPk/YzSnmunSU0vodY zoGpRLIX9FUSPWgYhr8tgmunC4asNLagrLj6IPHPvRpZAZ2kncFj74l+vsTqwhfZa49hSBAGV DkXY+Lwf3YXHg9wj0v9kv+jZr3/cSB46uFjl9ACyBy1Kbw9LW4OpDpWMKPslGWI06rsQQbWOL 0Omu0p3c8+dThVpqiu8Wt9NdT+kM+vc0Rzd0uExi/bFfnUFZBhBIxcl3DzQMBs+cH8ZXdyRg4 YVabw0sgiHDedu2cgj761WrGQAVVCKK4vtkqc8KAr5ff7ivEBoo3oFQxmjKQj61mZZMVmjMAI 9g7bKjx1hti9CtipkBV6YGdmHDp/r/g33tgeIAAijfGv6vEa14yeC4ECB3fg1tSMriUX1modN MmB9QRGv9CNIz6jEuThtMWixupWnjzaDWmRELLLLaS7CoSvZIBuo/WYbzkmHJsOH6Nu8oxA+m ovV3g1Cp67fUQdap8ARS7Q59n+enxMeDWaa15ug/UJvhWhT3Ro9VRNiPupMp0AqhC6TW3mv/5 fdAS/+8LYV34zGyFZzERl5YkIOqivRg7Pc/NmyYGw9jJxJ8x5PSPVSZgHH4hk2Hxl9G4A3JJO P4seMKRfWH0SDJvZae2KEXMrQQuLIoYFiRmHjhSL00XsGlI7U12utI8zM7W+NQgGHNZUc+wJV j0TagmuqGyiz3SRUqPY6zP2JPcOfOeUsh9TUUHP+5LT8MNL8HID3TWesaZew5ZqhPAgYz6Aih 3vm5N9nwXlNzJoiocYUvxO2oA4G1Rocutth8vjeN14ohl3p+YRnjWznH7vnAQohsHrcSnDsQ5 EdoojL9TGh1in4zm5rtN0N2e5AfsxdP4uL/wjiY8B2sg2Gwl5w= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Leon Romanovsky , Neil Armstrong , David Airlie , Networking , Masahiro Yamada , Nicolas Pitre , Saeed Mahameed , "linux-kernel@vger.kernel.org" , dri-devel , Linux-Renesas , Andrzej Hajda , Jonas Karlman , Kieran Bingham , Laurent Pinchart , "David S. Miller" , linux-rdma Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Apr 15, 2020 at 4:13 PM Geert Uytterhoeven wrote: > On Wed, Apr 15, 2020 at 3:47 PM Arnd Bergmann wrote: > > On Tue, Apr 14, 2020 at 10:52 PM Laurent Pinchart wrote: > > > Doesn't "imply" mean it gets selected by default but can be manually > > > disabled ? > > > > That may be what it means now (I still don't understand how it's defined > > as of v5.7-rc1), but traditionally it was more like a 'select if all > > dependencies are met'. > > That's still what it is supposed to mean right now ;-) > Except that now it should correctly handle the modular case, too. Then there is a bug. If I run 'make menuconfig' now on a mainline kernel and enable CONFIG_DRM_RCAR_DU, I can set DRM_RCAR_CMM and DRM_RCAR_LVDS to 'y', 'n' or 'm' regardless of whether CONFIG_DRM_RCAR_DU is 'm' or 'y'. The 'implies' statement seems to be ignored entirely, except as reverse 'default' setting. > > > > In that case, a Makefile trick could also work, doing > > > > ifdef CONFIG_DRM_RCAR_CMM > > obj-$(CONFIG_DRM_RCAR_DU) += rcar-cmm.o > > endif > > > > Thereby making the cmm module have the same state (y or m) as > > the du module whenever the option is enabled. > > What about dropping the "imply DRM_RCAR_CMM", but defaulting to > enable CMM if DU is enabled? > > config DRM_RCAR_CMM > tristate "R-Car DU Color Management Module (CMM) Support" > depends on DRM_RCAR_DU && OF > default DRM_RCAR_DU That doesn't work because it allows DRM_RCAR_DU=y with DRM_RCAR_CMM=m, which causes a link failure. Arnd _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel