From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44802C55178 for ; Tue, 27 Oct 2020 16:47:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE3BE20791 for ; Tue, 27 Oct 2020 16:47:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="o0znKZzf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE3BE20791 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1050E6EB7B; Tue, 27 Oct 2020 16:47:46 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 268666EB7B for ; Tue, 27 Oct 2020 16:47:44 +0000 (UTC) Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A9B542225E for ; Tue, 27 Oct 2020 16:47:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603817263; bh=14VCZuMIZdKHx03aGNmXB5dNYm5faUHR21s+UNmqFh8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=o0znKZzfNARqXqXgudOl2dKYU4+zaQKp7LO7aPAT2kl5pThO7ZAUBZ2vp1j95lPFc Tu4tuL1O8y12YI4yyQT7eWSz75QETEQ/5X+Jarrad5ZSy7qJVZH1q7UU5khhskMWu1 D341/4pAjsSBGhRkR8Fvsg5RPnLEdDxhy63t3Dj4= Received: by mail-qt1-f169.google.com with SMTP id h19so1475707qtq.4 for ; Tue, 27 Oct 2020 09:47:43 -0700 (PDT) X-Gm-Message-State: AOAM533UogmNYq7u5gK370kfhhpLiPvACtJGCUK1CDFhliXJ5aVdeV+I hQkNo+MQDhd2Z6oK4FccOYT33RxSzTG6BbDRTnE= X-Google-Smtp-Source: ABdhPJzDxfxuqhyC3F1KlAS2KtqALZJShCvFATA4o/kSVnGw7CNfbS7DXVsgAuvYANqZQgGAATCzis/Yz3c7AX45550= X-Received: by 2002:ac8:7955:: with SMTP id r21mr2948934qtt.204.1603817262708; Tue, 27 Oct 2020 09:47:42 -0700 (PDT) MIME-Version: 1.0 References: <20201026194110.3817470-1-arnd@kernel.org> <19af29c5-91e7-055f-cffa-0c813ed5233b@ti.com> In-Reply-To: <19af29c5-91e7-055f-cffa-0c813ed5233b@ti.com> From: Arnd Bergmann Date: Tue, 27 Oct 2020 17:47:25 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/4] drm/tilcdc: avoid 'make W=2' build failure To: Jyri Sarha X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , "linux-kernel@vger.kernel.org" , dri-devel , Tomi Valkeinen , Thomas Zimmermann , Emil Velikov , Wambui Karuga Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Oct 27, 2020 at 4:31 PM Jyri Sarha wrote: > On 26/10/2020 21:41, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > The -Wmissing-field-initializer warning when building with W=2 > > turns into an error because tilcdc is built with -Werror: > > > > drm/tilcdc/tilcdc_drv.c:431:33: error: missing field 'data' initializer [-Werror,-Wmissing-field-initializers] { "regs", tilcdc_regs_show, 0 }, > > drm/tilcdc/tilcdc_drv.c:432:33: error: missing field 'data' initializer [-Werror,-Wmissing-field-initializers] { "mm", tilcdc_mm_show, 0 }, > > > > Add the missing field initializers to address the warning. > > > > Signed-off-by: Arnd Bergmann > > Reviewed-by: Jyri Sarha Thanks > Please let me know if you want me to merge this. Yes, it would be good if you can merge it directly. Arnd _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel