From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50FF9C433F5 for ; Thu, 5 May 2022 14:59:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 48EEF10E476; Thu, 5 May 2022 14:59:58 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id CB71510E4C3 for ; Thu, 5 May 2022 14:59:56 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1F06BB82D82 for ; Thu, 5 May 2022 14:59:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE05AC385AE for ; Thu, 5 May 2022 14:59:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651762793; bh=IhPlTG/RSP+SotNFea7Fr39MZz0OjsoIPseiihaGxkc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=XJlLANSBhBQidSLyIN3yrDU4IPbB/XHn0sC/EiuYCYow1pSZuwUL9RL7kUdqha4a5 TcZwUvlSFBjq9APojye7LJhrzoz3yJ1Ko0vn9bx+hzpMIKK1bpwEinzLoso9szamoU kt+btKxs0bHl5LryHinLhmeOqshoLiof4tF0E/+fz0OqXBqxiiNxRhqua3QhXT1gQ9 FZipVJ1eZuG5o8dbsSJoiqjohKH/oez5kM37x1L64XAIvA0K2/0Rnw6ymC8BCVOm/J AVlpwubLtD+RPAMcU/M895m2znx/K5SL30vRlO5ThZta1c3MM+UqdWVtRQXT105Row Q/EgykBswo6Gg== Received: by mail-wr1-f51.google.com with SMTP id i5so6462709wrc.13 for ; Thu, 05 May 2022 07:59:53 -0700 (PDT) X-Gm-Message-State: AOAM530MFJn7E/MivfMjg34fWfINFxANaUPYpZvouHPr87Q51YjXrVOF ElEyoMVi2ZpMD/ObiLNvgwEeUlSUOHkAeIXBwDc= X-Google-Smtp-Source: ABdhPJyKl/lyubFIqlgFQkig5zNAs/zvVqV8InTOhcfpAoriY4j8URNODYiLewygje3f2WDNulvuU9Rfg/N1L0FjaiU= X-Received: by 2002:a05:6000:707:b0:20c:4fd8:1d61 with SMTP id bs7-20020a056000070700b0020c4fd81d61mr21866057wrb.407.1651762791921; Thu, 05 May 2022 07:59:51 -0700 (PDT) MIME-Version: 1.0 References: <20220419163810.2118169-1-arnd@kernel.org> <20220419163810.2118169-19-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Thu, 5 May 2022 16:59:35 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio To: Mark Brown Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , USB list , "Rafael J. Wysocki" , Viresh Kumar , Linux Fbdev development list , Dominik Brodowski , "open list:BROADCOM NVRAM DRIVER" , IDE-ML , linux-mtd , Tomas Cech , Robert Jarzmik , linux-clk , linux-leds@vger.kernel.org, linux-rtc@vger.kernel.org, Helge Deller , Marek Vasut , Paul Parsons , Michael Turquette , Sergey Lapin , Arnd Bergmann , Linux PM list , "open list:HID CORE LAYER" , Haojian Zhuang , Lubomir Rintel , dri-devel , Linux ARM , Thomas Bogendoerfer , Stephen Boyd , patches@opensource.cirrus.com, Dmitry Torokhov , linux-mmc , Linux Kernel Mailing List , ALSA Development Mailing List , Daniel Mack Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, May 5, 2022 at 4:39 PM Mark Brown wrote: > On Thu, May 05, 2022 at 04:33:06PM +0200, Linus Walleij wrote: > > On Thu, May 5, 2022 at 8:04 AM Arnd Bergmann wrote: > > > > /* Headphones jack detection DAPM pin */ > > > static struct snd_soc_jack_pin hs_jack_pin[] = { > > > { > > > .pin = "Headphone Jack", > > > .mask = SND_JACK_HEADPHONE, > > > }, > > > { > > > .pin = "Speaker", > > > /* disable speaker when hp jack is inserted */ > > > .mask = SND_JACK_HEADPHONE, > > > .invert = 1, > > > }, > > > Hm some ASoC thingie. No idea what that is, but I suppose another > > place where a subsystem for legacy reasons try to do the gpiolib > > inversion on it's own accord. That one isn't flagged as active low in the > > descriptor so it's fine I guess. > > It's saying that when the headphone is inserted the headphone output > should be enabled and the speaker output should be disabled, and vice > versa. Ok, that sounds like I should remove the flag here if I declare the GPIO line as GPIO_ACTIVE_LOW instead of GPIO_ACTIVE_HIGH, right? Arnd